May 2008 - Wine-devel - list.winehq.org

winetest problems
by James Hawkins 06 May '08

06 May '08

Hi, I'm trying to fix the failing cross tests, but we haven't had a winetest build on Paul Millar's server in a few days. I'm not familiar with Paul's build process, so my only guess is that a recent commit has broken the build. In the meantime, I've tried a few things. I used John Klehm's crossbuild_tricks script [1] to build winetest. The build succeeded, but the submitted result [2] is empty or can't be parsed. I ran 'make crosstest' from the build directory which fails with: make[2]: Entering directory `/home/truiken/mywine/wine-build/dlls/advpack/tests' i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o advpack.cross.o ../../../../../wine/dlls/advpack/tests/advpack.c ../../../../../wine/dlls/advpack/tests/advpack.c:1: warning: -fPIC ignored for target (all code is position independent) i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o files.cross.o ../../../../../wine/dlls/advpack/tests/files.c ../../../../../wine/dlls/advpack/tests/files.c:1: warning: -fPIC ignored for target (all code is position independent) i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o install.cross.o ../../../../../wine/dlls/advpack/tests/install.c ../../../../../wine/dlls/advpack/tests/install.c:1: warning: -fPIC ignored for target (all code is position independent) ../../../tools/make_ctests -o testlist.c advpack.c files.c install.c i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o testlist.cross.o testlist.c testlist.c:1: warning: -fPIC ignored for target (all code is position independent) i586-mingw32msvc-gcc advpack.cross.o files.cross.o install.cross.o testlist.cross.o -o advpack_crosstest.exe -lcabinet -ladvapi32 -lkernel32 /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/bin/ld: cannot find -lcabinet collect2: ld returned 1 exit status make[2]: *** [advpack_crosstest.exe] Error 1 make[2]: Leaving directory `/home/truiken/mywine/wine-build/dlls/advpack/tests' make[1]: *** [advpack/tests/__crosstest__] Error 2 make[1]: Leaving directory `/home/truiken/mywine/wine-build/dlls' Which (I assume) is usually fixed by Paul Millar's win32api custom patches. Any thoughts or ideas? [1] http://klehm.net/wine/crossbuild_tricks.sh [2] http://test.winehq.org/data/1a5aab0ddcc7a0dcde4403add73dbd80be746020/ -- James Hawkins

5 9

Re: [PATCH] fixed if check before strchr
by Eric Pouech 06 May '08

06 May '08

Marcus Meissner a écrit : > Hi, > > spotted by Coverity (CID 701), a if (!spath) should be if (spath). > > Ciao, Marcus > --- > programs/winedbg/source.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/winedbg/source.c b/programs/winedbg/source.c > index 5519c57..1db7092 100644 > --- a/programs/winedbg/source.c > +++ b/programs/winedbg/source.c > @@ -128,7 +128,7 @@ static BOOL source_locate_file(const char* srcfile, char* path) > while (!found) > { > spath = strchr(spath, '\\'); > - if (!spath) spath = strchr(spath, '/'); > + if (spath) spath = strchr(spath, '/'); > if (!spath) break; > spath++; > found = SearchPathA(dbg_curr_process->search_path, spath, NULL, MAX_PATH, path, NULL); > actually no the code intends to find the first occurence of / or \ A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

4 3

Re: [PATCH 1/3] dinput: Remove redundant variable.
by Vitaliy Margolen 06 May '08

06 May '08

Vitaliy Margolen wrote: > --- > dlls/dinput/joystick_linux.c | 16 +++++++--------- > 1 files changed, 7 insertions(+), 9 deletions(-) > Forgot to add that this series of patches should finally address bugs 12052 and 11644. Was there anything wrong with these patches? Vitaliy.

1 1

draft Call for Testing
by Dan Kegel 06 May '08

06 May '08

So, what should we be asking wine users to be doing once rc1 is out? How about this: --- snip --- Calling all wine users! Today, after 15 years of development, the first release candidate for wine-1.0.0 was released. Wine has been under heavy development in recent months, and some applications that used to work well no longer do. But we don't know which ones! Please help us find them, so we can fix them. Here's how: 0. Make sure your machine runs glxgears properly (if it crashes, you may need to update your graphics drivers) 1. Install wine-1.0.0-rc1 (you can download it from http://www.winehq.org/site/download ). Make sure wine's notepad starts up ok and says "wine 1.0.0 rc1" when you do Help / About Wine. 2. Visit the Wine application database at http://appdb.winehq.org/browse_by_rating.php?sRating=Platinum and pick out a few applications that supposedly work perfectly under Wine but do not yet have any test reports with wine-1.0.0-rc1 or later. 3. Try installing and running those apps, one at a time. Before installing each app, delete your .wine directory; that way you get a clean run, uncontaminated by the previous app's settings. 4. For each app you test, add a test report into Wine's AppDB. As a token of our thanks, we will pick one of the users who submits a healthy set of useful test results and send him or her a tasteful Wine-themed goodie of some sort. So fire up your keyboards and start testing! Thanks, and good hunting! --- snip --- (Not sure how the goodie would be handled, but I'm willing to cover the expenses myself, especially if I get to pick the winner :-) How's that sound?

7 8

Re: [PATCH 3/3] ddraw/tests: Add tests for IDirect3DDevice7_Load.
by Stefan Dösinger 06 May '08

06 May '08

Am Montag, 5. Mai 2008 23:49:34 schrieb Alexander Dorofeyev: > + /* Freed in reverse order as native seems to dislike and crash on > freeing top level surface first. */ just fyi, native ignores refcounts on sublevels(if they are created as complex surface, not attached). As long as the top level exists, you can release the sublevels into oblivion if you want to, they'll stay around. If the top level is destroyed, the sublevels are destroyed regardless of their refcounts. There are some tests for this behavior in dsurface.c, and Wine does the same essentially. A very extensive test, wow!

1 0

Re: AppDB: update the general help page and also make it valid html
by Alexander Nicolaysen Sørnes 06 May '08

06 May '08

> I've updated the general help page with links to git instead of cvs, > updated building instructions and also changed the html a little so it > validates, I've also removed a link to a cracks website and replaced > it with a statement about third party software. > > before and after: http://img222.imageshack.us/img222/8647/baiz4.png It's great that you're fixing up the help pages. But i don't see why you are removing the link to MegaGames; I added it to make it easier for users to test games without a how-to; removing it would appear to do the opposite. Alexander N. Sørnes

1 0

Re: netapi32: Fix test crash occuring when NetWkstaUserGetInfo fails, try 2
by James Hawkins 06 May '08

06 May '08

On Tue, May 6, 2008 at 1:36 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Improved from James Hawkins suggestions. > --- > Just to clear my name, this is not what I suggested :-) -- James Hawkins

1 0

wineserver socket file and DOS attacks
by Steven Elliott 06 May '08

06 May '08

I have some concerns about the location of the socket file that wineserver uses. Since by default the current location is in /tmp my concern is that anyone can stop anyone else from using wine just by creating a directory named /tmp/.wine-500. As far as I know the only risk is denial of service in nature since wine seems to be smart enough to make sure the /tmp/.wine-500 is owned by the user invoking the wine application: > notepad wineserver: /tmp/.wine-500 is not owned by you Previously the socket file was under ~/.wine. I found this which briefly documents the change here: http://www.winehq.org/site/docs/winedev-guide/x2584 under section "7.3.2. The Wine server" it says: "In earlier versions of Wine the master socket mentioned above was actually created in the configuration directory; either your home directory's /wine subdirectory or wherever the WINEPREFIX environment variable points. Since that might not be possible the socket is actually created within the /tmp directory with a name that reflects the configuration directory." /tmp/.wine-<user Id> is hard coded in libs/wine/config.c, so that aspect of the socket file location is not configurable. Anyway, have alternatives such as the following been considered?: 1) Create the socket file in ~/.wine (or wherever WINEPREFIX points) like wine used to if the user's home directory exists and is writable. Use /tmp/.wine-<user Id> as a fallback. 2) Append some additional integer to /tmp/.wine-<user Id> that is incremented if that directory already exists and is owned by someone else. For example, if /tmp/.wine-500 already exists for user 500 but is owned by someone else then both wineserver and the wine application would append "-1" and then keep incrementing: /tmp/.wine-500 /tmp/.wine-500-1 /tmp/.wine-500-2 until they each found a directory owned by the current user (or until they are able to create one). Hopefully they would pick the same directory. I need to think more about how robust this would be. -- ----------------------------------------------------------------------- | Steven Elliott | selliott4(a)austin.rr.com | -----------------------------------------------------------------------

6 10

Bug#479659: RFH: wine -- Windows API implementation
by Ove Kaaven 06 May '08

06 May '08

Package: wnpp Severity: normal Since my time may be limited in the future, I am seeking comaintainers for the Wine package in Debian, at least to ensure that new Wine releases may continue to be uploaded in a timely fashion, and to keep the package's bug count down. (And given that pretty much half the open bugs are "missing manpage" bugs, documentation writers would also help...) I have created a project for this on alioth.debian.org. I've loaded the current packaging (all versions since etch) into a Git repository there, and put up some instructions on http://pkg-wine.alioth.debian.org/ -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (650, 'testing'), (600, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core) Locale: LANG=en_US.ISO-8859-1, LC_CTYPE=en_US.ISO-8859-1 (charmap=ISO-8859-1) Shell: /bin/sh linked to /bin/bash

1 0

bugzilla rights request
by Alexander Dorofeyev 05 May '08

05 May '08

Hi. I would like to have rights to change bug status. I fix some bugs myself and also occasionally do some bug-triaging, so it would be handy. Thanks.

1 0