January 2009 - Wine-devel - list.winehq.org

SHGetFileInfo flag SHGFI_USEFILEATTRIBUTES together with SHGFI_PIDL (regression)
by Petr Sumbera 30 Jan '09

30 Jan '09

Hi All, What is story behind following commit? This seems to broke Zoner Photo Studio (tested on OpenSolaris). According to some documentation combination of these flags is not allowed.. http://source.winehq.org/git/wine.git/?a=blobdiff;f=dlls/shell32/shell32_ma… --- a/dlls/shell32/shell32_main.c +++ b/dlls/shell32/shell32_main.c @@ -350,10 +350,6 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, (flags & SHGFI_PIDL)? "pidl" : debugstr_w(path), dwFileAttributes, psfi, psfi->dwAttributes, sizeofpsfi, flags); - if ( (flags & SHGFI_USEFILEATTRIBUTES) && - (flags & (SHGFI_ATTRIBUTES|SHGFI_EXETYPE|SHGFI_PIDL))) - return FALSE; - /* windows initializes these values regardless of the flags */ if (psfi != NULL) { --- Petr

1 0

Re: comctl32: Fix propsheet size calculation (resent)
by Alexandre Julliard 30 Jan '09

30 Jan '09

Vitaliy <vitaliy(a)kievinfo.com> writes: > + /* Get non-client size */ > + if (!psInfo->isModeless) > + { > + RECT rc1; > + > + GetWindowRect(hwndDlg, &rc); > + GetClientRect(hwndDlg, &rc1); > + tabOffsetX = rc.right - rc.left - (rc1.right - rc.left); > + tabOffsetY = rc.bottom - rc.top - (rc1.bottom - rc.top); That doesn't make sense. What are you trying to compute here? -- Alexandre Julliard julliard(a)winehq.org

2 3

DIB Engine - Rebased on current tree (Takes 2) - Part 2 - winedib.drv initial implementation
by Massimo Del Fedele 30 Jan '09

30 Jan '09

Here part 2. Ciao Max

1 0

DIB Engine - Rebased on current tree (Takes 2) - Part one - GDI32 patches
by Massimo Del Fedele 30 Jan '09

30 Jan '09

As there where some changes on GDI32 in latest commits, previous testing DIB Engine had to be modified too. I'm posting here (and in bug 421 page) the 2 needed patches, separated by GDI32 changes and winedib.drv folder. In order to keep patches smaller, I dropped the autogenerated 'configure', but leaving 'configure.ac'.... I guess this is the correct way, probably an autoconf is needed to regenerate the configure file. I was asked to separate the commits from Huw Davies, Jesse Allen and me, but as I changed most of the original author's code It'll be somehow difficult and, imho, will make few sense. It can be done, but that would mean to post a great number of patches with the final result quite different from the original one. I let of course the original copyright notices inside files; I'd like original author's opinion if for them is enough. Instructions on how to enable/disable the engine as the same as previous post, and are detailed in BUG 421 page. First part -- GDI32 patches Ciao Max

1 0

Re: gdiplus: GdipCreateBitmapFromHICON implemented (with some tests)
by Alexandre Julliard 30 Jan '09

30 Jan '09

Nikolay Sivov <bunglehead(a)gmail.com> writes: > @@ -4,7 +4,7 @@ SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = gdiplus.dll > IMPORTLIB = gdiplus > -IMPORTS = uuid shlwapi oleaut32 ole32 user32 gdi32 kernel32 > +IMPORTS = uuid shlwapi oleaut32 ole32 user32 gdi32 kernel32 shell32 It's a bit wasteful to import shell32 just to copy an icon. -- Alexandre Julliard julliard(a)winehq.org

2 1

Wined3d being used with VirtualBox D3D
by Zachary Goldberg 30 Jan '09

30 Jan '09

All, An interesting piece from Phoronix about new VirtualBox Direct3D support; which apparently uses WineD3D in the backend. I haven't noticed anything in particular but has Sun been filing bugs / sending patches? http://www.phoronix.com/scan.php?page=news_item&px=NzAyNA --Zach

3 2

Another MSVCRT problem, perhaps __RTDynamicCast()
by Uwe Bonnes 30 Jan '09

30 Jan '09

Hello, after registering at http://forms.analog.com/form_pages/rfcomms/adisimpll.asp?ref=ASC-PR-067 you can download ADIsimPLL Version 3.1 for free. Running the program (with richedit from winetricks) it offers to run a tutorial. In the course of clicking next in this tutorial, at some point some form gets filled with \ nonsense double values. This doesn't happen with native msvcrt. I have instrumented msvcrt._ecvt() to print out the number. The number printed is the nonsens number in the form. Appended +relay,+msvcrt looks fishy: 0023:Call msvcrt.__RTDynamicCast(006f7a58,00000000,00543030,00544838,00000000) ret=0044019e trace:msvcrt:MSVCRT___RTDynamicCast obj: 0x6f7a58 unknown: 0 src: 0x543030 {vtable=0x521568 name=.?AVYASymbol@@ ()} dst: 0x544838 {vtable=0x521568 name=.?AVLibDouble@@ ()} do_throw: 0) trace:msvcrt:dump_obj_locator 0x524218: sig=00000000 base_offset=00000000 flags=00000000 type=0x544838 {vtable=0x521568 name=.?AVLibDouble@@ ()} hierarchy=0x524208 trace:msvcrt:dump_obj_locator hierarchy: sig=00000000 attr=00000000 len=3 base classes=0x5241f8 trace:msvcrt:dump_obj_locator base class 0x5241e0: num 2 off 0,-1,0 attr 00000000 type 0x544838 {vtable=0x521568 name=.?AVLibDouble@@ ()} trace:msvcrt:dump_obj_locator base class 0x524190: num 1 off 0,-1,0 attr 00000000 type 0x544818 {vtable=0x521568 name=.?AVLibVariable@@ ()} trace:msvcrt:dump_obj_locator base class 0x5234d8: num 0 off 0,-1,0 attr 00000000 type 0x543030 {vtable=0x521568 name=.?AVYASymbol@@ ()} 0023:Ret msvcrt.__RTDynamicCast() retval=006f7a58 ret=0044019e 0023:Call msvcrt._ecvt(00000001,5f40255f,0000000a,00328dd4,00328ddc) ret=0040a952 0023:Call KERNEL32.TlsGetValue(00000000) ret=7ec3e471 0023:Ret KERNEL32.TlsGetValue() retval=001b0678 ret=7ec3e471 trace:msvcrt:_ecvt num 6606512752554031389059083466263841847175093544956949844249843220093860018640324866\ 420498348423671822060046924282328257865959227190774155226910868635648.000000, digits 10 0023:Call ntdll.RtlAllocateHeap(00110000,00000000,00000050) ret=7ec2de07 0023:Ret ntdll.RtlAllocateHeap() retval=006e4550 ret=7ec2de07 0023:Ret msvcrt._ecvt() retval=006e4550 ret=0040a952 I suspect __RTDynamicCast() to cause the error. Having not much C++ understanding, I don't feel like writing a sensible testcase. Can anybody perhaps have a look? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

report on obscure issues: running out of file handles with python under wine
by Luke Kenneth Casson Leighton 30 Jan '09

30 Jan '09

hiya folks, well the saga continues with using python under wine - i thought i'd let you know the analysis and clues so far, in case it rings any bells with anyone, now or in the future. as you're probably aware, there's a limit in nt of 2048 file descriptors which has caused a large number of free software projects quite a lot of grief , e.g. this: http://bugs.mysql.com/bug.php?id=24509. it turns out that python is no different, and i'm just in the process of investigating whether compiling every single c-based module as a builtin saves me enough file handles to be able to not hit the 2048 handles limit. it's really quite stunning. even something as simple as running a single small test script can result in 1,400 file handles being used up. by the time you get to things like the popen-replacement (see msdn KB: Q190351 for a simple code example). anyway - what prompted me to write was that i ran the python.exe with msvcr80 on wine, and the popen-like code segfaulted. under win32 naitive (an actual XP qemu) it failed - gracefully. but, weirdly, python.exe _without_ msvcr80 did _not_ segfault, but, again, same code on XP qemu'd failed gracefully. so, matrix: wine xp-qemu'd vc80 segfault error vc71 ok error in other words, i'm beginning to suspect that the reason for that msvcr80 segfault i was investigating last week is because of running out of file handles, and wine doesn't _have_ that 2048 file descriptor limit that msvcr80 is assuming actually exists. either that, or when you _do_ reach that limit, it results in corruption that an app running msvcr71 doesn't notice. or something. the reason i haven't raised this as a bugreport is because i really don't exactly know what's going on - there are just rather a lot of empirical observations that are ... "out there" :) so i apologise for this being a bit long, and not very specific, and if ever i get anything specific i'll of course raise it as a bugreqeuest, but i didn't want to leave this undocumented. l.

4 5

Re: D3D: Implement vertex blending in drawStridedSlow
by Henri Verbeet 30 Jan '09

30 Jan '09

2009/1/25 Claudio Ciccani <klan(a)users.sf.net>: > > + WORD vertexBlendSW : 1; /* vertexBlend software fallback used */ I'm not sure we want to implement vertex blending in software in the first place (rather than through a shader), but you can't just add a bitfield here without changing the padding.

3 9

First complete test run passing on a Windows platform
by Reece Dunn 30 Jan '09

30 Jan '09

Hi, The Wine tests are now passing on a Windows XP machine (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group…) Two of the other four only have 2 or 3 failures. The 2003 group has 3 machines with 1 failure each (urlmon:protocol on one, user32:menu on the others). Congratulations to everyone involved fixing the tests! - Reece

2 1