January 2009 - Wine-devel - list.winehq.org

Should winetest retrieve msi log file on msi test failures?
by Dan Kegel 28 Jan '09

28 Jan '09

Looking at test.winehq.org's XP results, it seems we're doing quite well; some of the remaining failures seem to be unusual situations. For instance: msi:msi.c is passing flawlessly on 7 out of 10 computers, and on one of the computers, it has just one failure: http://test.winehq.org/data/8f829034f3fe4da3e7adce2f4685e10ba2e2fe82/xp_fg-… says dlls/msi/tests/msi.c msi.c:254: Test failed: wrong error 1618 1618 is ERROR_INSTALL_ALREADY_RUNNING. Say, can winetest retrieve and display the msi log file on failure? That might be informative...

2 3

Re: Implement BiDi mirroring
by Juan Lang 28 Jan '09

28 Jan '09

Hi Khaled, +void doMirror(WCHAR* ch) This should be static. + else if(*ch == mirrored[k].first) + { + *ch = mirrored[k].mirror; + return; + } The else if block is indented one level too many. Thanks, --Juan

2 2

Consistency in programs/winecfg/drivedetect.c
by Ben Klein 28 Jan '09

28 Jan '09

I just noticed my first patch got accepted, yay :) commit 8df74a0edb3304dfc26bd524327f9128f63de47f Author: Ben Klein <shacklein(a)gmail.com> Date: Wed Jan 21 21:02:12 2009 +1100 winecfg: Fix a typo in autodetect_drives. I also noticed someone removed the superfluous () around the expression in my patch. I included this for consistency in the file, and note that the same superfluous () appears on lines 244 and 272 in drivedetect.c in current git HEAD. Since this is not a functional thing in any way, and it doesn't matter on the compiler level whether it's (a == (b + c)) or (a == b + c), I'm not sure if it's worth me submitting a patch to correct the consistency. What's the prefered coding style for this situation? :)

1 0

Re: server: Use kernel support for process affinity when available (try 2)
by Alexandre Julliard 28 Jan '09

28 Jan '09

Juan Lang <juan.lang(a)gmail.com> writes: > Is this better? This trades a single call to sched_getaffinity per > process to one every time the process affinity is queried. This seems > safer, since a non-Wine process can also change a process's affinity, > but it can have higher overhead. Yes, that's better. But AFAICT sched_get/setaffinity applies to a single thread, not to the whole process. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [twain_32 2/7] Add an interactive set of tests for a selected scanner.
by Jeremy White 28 Jan '09

28 Jan '09

> + rc = pDSM_Entry(appid, source, DG_CONTROL, DAT_CAPABILITY, MSG_GET, > &cap); Bletch. Forgot to add --attach. I'll resend the series. Sorry :-/. Cheers, Jeremy

1 0

Re: setupapi: implement pSetupInstallCatalog
by Alexandre Julliard 28 Jan '09

28 Jan '09

Aric Stewart <aric(a)codeweavers.com> writes: > + if (!CryptCATAdminAcquireContext(&admin,NULL,0)) > + { > + ERR("Could not acquire security context\n"); > + return ERROR_GEN_FAILURE; > + } > + if (!(cat = CryptCATAdminAddCatalog(admin,catalog,basename,0))) > + { > + ERR("Could not add catalog\n"); > + CryptCATAdminReleaseContext(admin, 0); > + return ERROR_GEN_FAILURE; You should return proper error codes based on the result of the called functions instead of a generic ERROR_GEN_FAILURE. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2]reg.exe: Implement ADD for REG_SZ
by Alexandre Julliard 28 Jan '09

28 Jan '09

Aric Stewart <aric(a)codeweavers.com> writes: > + if (key_name[0]=='\\' && key_name[1]=='\\') > + { > + static const WCHAR remoteW[] = {'U','n','a','b','l','e',' ','t','o',' ','a','d','d',' ','k','e','y','s',' ','t','o',' ','r','e','m','o','t','e',' ','m','a','c','h','i','n','e',' ','%','s','\n',0}; This should go in the resources like the other messages. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shdocvw: OnAmbientPropertyChange should refresh all properties with a DISPID_UNKNOWN
by Jacek Caban 28 Jan '09

28 Jan '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > shdocvw: OnAmbientPropertyChange should refresh all properties > with a DISPID_UNKNOWN It would be better to add test for it so we know which properties should we refresh (even if most of them would be todo_wine ATM). Thanks, Jacek

1 0

Updated DIB Engine
by Massimo Del Fedele 28 Jan '09

28 Jan '09

Here some news on my DIB Engine : Corrected some small bugs in text handling (still VERY poor) Corrected a couple of crashes Added code to enable/disable by environment or registry Made optionals all engine stubs FIXMEs (speeds up a lot....) The engine is disabled by default; can be changed by environment variable : export WINEDIB=ON (or ENABLE or ENABLED or TRUE) enables it export WINEDIB=OFF (or DISABLE or DISABLED or FALSE) disables it or by registry key : HKCU/Software/Wine/DIB Engine/Enable='Y' enables it HKCU/Software/Wine/DIB Engine/Enable='N' disables it the environment variable has precedence on registry, so for example if WINEDIB=ON and HKCU/Software/Wine/DIB Engine/Enable='N' the engine is enabled. I suggest to use the environment for the moment, at less you have an app that runs much better with the engine (autocad, for example...) which benefits from a default enabled engine in registry. Still many many things to do, the most noticeable by now is the missing ROP operations on blitting (and the semi-stub stretchblt...) which is quite noticeable in autocad, for example. I'm pasting a zipped patch of today's current git. Ciao Max

7 16

Re: DNS10 goes 12 minutes rather than 10 before crashing.
by Susan Cragin 28 Jan '09

28 Jan '09

>> As you may know, Dragon NaturallySpeaking 10 crashes on use with predictable regularity. >> Used to be every 10 minutes. >> However, yesterday (and today) that creeped up to 12 minutes. >> It could be due to anything, but I thought one of you might say EUREKA!! it's the foobar.c part of oleacc!! or something like that. >> If not, have a good day. >> Susan > >Hi Susan, > >Is there a demo for DNS 10 and do you need to do anything special for >it to crash? I presume you need to train it and then start speaking. > >- Reece Hi, Reece. There is no demo. DNS10 Standard costs $100. I have been somewhat successful in getting complimentary copies for developers. I'm meeting with one of the senior developers the second Tuesday in Feb. If you want a copy, send me something about you or a link to something about you, and a street address for mailing. What I do: Every day, I compile git and re-install DNS on a new .wine. Then I train it and run it. I use it in my work, which is writing. DNS10 used to be sort of flaky but it's getting better. Right now sometimes it crashes immediately on first run but then it runs GREAT -- fast and accurate -- for 10 minutes (now 12). Then it crashes. Always. Inevitably. It's always the time factor. Always just about the same amount of seconds between the time the recognition engine initializes and when it crashes. I can be dictating like a maniac -- hundreds of words per minute, or I can dictate nothing at all. I can transfer text every 10 seconds or leave it all in DictationBox. I can change the settings to save trained text or not. Nothing makes any difference other than time. BTW -- I always dictate into DictationBox, for transfer into Notepad. That is the way (under ALL configurations including Windows) that the program runs the best. Susan

1 0