January 2009 - Wine-devel - list.winehq.org

DNS10 goes 12 minutes rather than 10 before crashing.
by Susan Cragin 27 Jan '09

27 Jan '09

As you may know, Dragon NaturallySpeaking 10 crashes on use with predictable regularity. Used to be every 10 minutes. However, yesterday (and today) that creeped up to 12 minutes. It could be due to anything, but I thought one of you might say EUREKA!! it's the foobar.c part of oleacc!! or something like that. If not, have a good day. Susan

2 1

Re: include(1/1): Define flags used by CryptUIWizExport
by Alexandre Julliard 27 Jan '09

27 Jan '09

Juan Lang <juan.lang(a)gmail.com> writes: > @@ -297,6 +297,12 @@ typedef struct _CRYPTUI_WIZ_EXPORT_CERTCONTEXT_INFO > typedef const CRYPTUI_WIZ_EXPORT_CERTCONTEXT_INFO * > PCCRYPTUI_WIZ_EXPORT_CERTCONTEXT_INFO; > > +/* Values for CryptUIWizExport's dwFlags */ > +#define CRYPTUI_WIZ_IGNORE_NO_UI_FLAGS_FOR_CSPS 0x00000002 > +#define CRYPTUI_WIZ_NO_UI_EXCEPT_CSP 0x00000003 > +#define CRYPTUI_WIZ_EXPORT_PRIVATE_KEY 0x00000100 > +#define CRYPTUI_WIZ_EXPORT_NO_DELETE_PRIVATE_KEY 0x00000200 MSDN explicitly states that these are not defined in a public header. -- Alexandre Julliard julliard(a)winehq.org

2 1

Wine menu creation questions
by Reece Dunn 27 Jan '09

27 Jan '09

Hi, I have noticed that when wine creates a menu item (that for example, on Ubuntu gets put in the Applications > Wine > Programs menu), the command that gets written uses 'wine' as the program to run. This means that you need to have Wine in your PATH and cannot use more than one version of Wine. For example, if I wanted to use /opt/wine-1.0, /opt/crossover and /opt/wine for different applications I cannot access these correctly from the menu items created. Additionally, the user experience (yes, I have been watching Owen's Google talk :)) is that the application does not start (especially if the only version of Wine is not on the PATH). The solution to this is to add the full path to wine, e.g. '/opt/wine-1.0/bin/wine' when generating the menus. Are there any objections to this? Along similar lines, building on what Owen said in the talk that if all goes well Jane user will not notice that she is using Wine to run her Windows software: why is there an entry in the Applications section that says 'Wine' (and why does it have the folder icon and not the Wine icon)! It would be better if this said something like "Program Files", replacing Wine > Programs -- this removes a level of indirection and gives the user something that they are familiar with and is more discoverable than 'Wine'. Thoughts? - Reece

6 7

Re: comctl32: Fix propsheet size calculation
by Vitaliy Margolen 27 Jan '09

27 Jan '09

Vitaliy Margolen wrote: > Size of tabs has nothing to do with the size of a window title. > Fixes bug 8522. > --- > dlls/comctl32/propsheet.c | 17 ++++++++++++++--- > 1 files changed, 14 insertions(+), 3 deletions(-) > Was there anything wrong with this patch? Adding tests for this won't work all that well - size of non-client varies from distro to distro to WM to user settings. Vitaliy

1 0

Re: [PATCH] d3d9: initialize hr (coverity)
by Alexandre Julliard 27 Jan '09

27 Jan '09

Marcus Meissner <marcus(a)jet.franken.de> writes: > Spotted in CID 864 that hr is used uninitialized > in a codepath. Using S_OK as default return. Is S_OK really appropriate here? A test case is probably in order. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32[1/2]: toolbar: Str_SetPtr* assumes the destination pointer points to allocated memory or is NULL
by Alexandre Julliard 27 Jan '09

27 Jan '09

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > @@ -2924,6 +2925,7 @@ TOOLBAR_AddStringW (HWND hwnd, WPARAM wParam, LPARAM lParam) > } > > infoPtr->strings = ReAlloc(infoPtr->strings, sizeof(LPWSTR)*(infoPtr->nNumStrings+1)); > + infoPtr->strings[infoPtr->nNumStrings] = NULL; > Str_SetPtrW(&infoPtr->strings[infoPtr->nNumStrings], p); > infoPtr->nNumStrings++; > > @@ -2942,6 +2944,7 @@ TOOLBAR_AddStringW (HWND hwnd, WPARAM wParam, LPARAM lParam) > > TRACE("len=%d %s\n", len, debugstr_w(p)); > infoPtr->strings = ReAlloc(infoPtr->strings, sizeof(LPWSTR)*(infoPtr->nNumStrings+1)); > + infoPtr->strings[infoPtr->nNumStrings] = NULL; > Str_SetPtrW (&infoPtr->strings[infoPtr->nNumStrings], p); > infoPtr->nNumStrings++; ReAlloc initializes to 0, so this shouldn't make any difference. -- Alexandre Julliard julliard(a)winehq.org

1 0

Could someone test this wineinet:http fix on an XP or 2003 box without IE7
by Reece Dunn 27 Jan '09

27 Jan '09

Hopefully, we will then get a clean test run on some XP boxes and have several more 2003 boxes with 1 test failure :). Thanks, - Reece

4 4

Re: shell32: Fix SHFileOperation on empty destination (FO_COPY)
by James Hawkins 27 Jan '09

27 Jan '09

On Tue, Jan 27, 2009 at 3:20 AM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > http://bugs.winehq.org/show_bug.cgi?id=13394 > > Changelog: > - on FO_COPY and empty destination SHFileOperation should use > current directory > > >From 1684fd3c0d47fce3fcff31d316ec7b18291cd5af Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Tue, 27 Jan 2009 12:17:42 +0300 > Subject: Fix SHFileOperation on empty destination (FO_COPY) > > --- > dlls/shell32/shlfileop.c | 8 ++++++++ > dlls/shell32/tests/shlfileop.c | 14 ++++++++++++++ > 2 files changed, 22 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/shlfileop.c b/dlls/shell32/shlfileop.c > index ec7ba54..78b7352 100644 > --- a/dlls/shell32/shlfileop.c > +++ b/dlls/shell32/shlfileop.c > @@ -1498,6 +1498,7 @@ int WINAPI SHFileOperationW(LPSHFILEOPSTRUCTW lpFileOp) > FILE_OPERATION op; > FILE_LIST flFrom, flTo; > int ret = 0; > + WCHAR currd[MAX_PATH]; > > if (!lpFileOp) > return ERROR_INVALID_PARAMETER; > @@ -1510,6 +1511,13 @@ int WINAPI SHFileOperationW(LPSHFILEOPSTRUCTW lpFileOp) > if ((ret = parse_file_list(&flFrom, lpFileOp->pFrom))) > return ret; > > + if ((lpFileOp->wFunc == FO_COPY) && > + (lpFileOp->pTo[0] == 0)) > + { > + GetCurrentDirectoryW(MAX_PATH, currd); > + parse_file_list(&flTo, currd); > + } > + else > if (lpFileOp->wFunc != FO_DELETE) > parse_file_list(&flTo, lpFileOp->pTo); > Style is wrong. Should be 'else if' all on one line. Regardless, this functionality should be in copy_files, not SHFileOperationW. > diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c > index 433a131..3c85ecd 100644 > --- a/dlls/shell32/tests/shlfileop.c > +++ b/dlls/shell32/tests/shlfileop.c > @@ -1673,6 +1673,20 @@ static void test_copy(void) > ok(DeleteFileA("ab.txt"), "Expected file to exist\n"); > ok(RemoveDirectoryA("one"), "Expected dir to exist\n"); > ok(RemoveDirectoryA("two"), "Expected dir to exist\n"); > + > + /* pFrom contains a name larger than 8.3, pTo is an empty string */ > + CreateDirectoryA("one", NULL); > + createTestFile("one\\abcdefghi.abc"); > + shfo.pFrom = "one\\abcdefghi.abc\0"; > + shfo.pTo = "\0"; > + shfo.fFlags = FOF_NOCONFIRMATION | FOF_SILENT | FOF_NOERRORUI | FOF_FILESONLY | > + FOF_NOCONFIRMMKDIR; > + > + retval = SHFileOperationA(&shfo); > + ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", retval); > + ok(DeleteFileA("abcdefghi.abc"), "Expected file to exist\n"); > + ok(DeleteFileA("one\\abcdefghi.abc"), "Expected file to exist\n"); > + ok(RemoveDirectoryA("one"), "Expected dir to exist\n"); > } > > /* tests the FO_MOVE action */ > -- > 1.5.6.5 > > > > > > -- James Hawkins

1 0

Is there a way to set Z:\ as the whatever user's home folder?
by Scott Ritchie 27 Jan '09

27 Jan '09

I want to have a read-only wine prefix that multiple users might access, however I also want to have a Z:\ drive that refers to a dynamic location - a folder inside the current user's home folder. This isn't possible as far as I can tell, as Wine requires a symlink to the folder in the prefix's dosdevices directory, and a symlink can only point to a static file. Assuming this is possible, are there any downsides to using this read-only prefix? Assume for a moment that the application doesn't need write access to the registry or to its own folder. Thanks, Scott Ritchie

2 1

Re: [PATCH] wineps.drv: Add a simple implementation of PSDRV_SelectBitmap.
by Alexandre Julliard 27 Jan '09

27 Jan '09

Lei Zhang <thestig(a)google.com> writes: > Hi, > > This fixes bug 17103 for me. I'm not sure if PSDRV_SelectBitmap() need > to do more, but this is a start and it's better than a stub. If it doesn't do more, then removing it completely should work just as well. There doesn't seem to be much point in just storing the bitmap, this is easy to retrieve when needed. -- Alexandre Julliard julliard(a)winehq.org

2 1