January 2009 - Wine-devel - list.winehq.org

re: First complete test run passing on a Windows platform
by Dan Kegel 30 Jan '09

30 Jan '09

Wow, that's awesome! A day seven years in the making... 2002: the C test suite is started: http://source.winehq.org/git/wine.git/?a=commit;h=caa03388bcccc64f444f9b4ef… 2003: winetest committed: http://www.winehq.org/wwn/199#Winetest%20Integrated%20&%20Future%20Steps 2004: server to build winetest and parse winetest results set up http://www.winehq.org/wwn/216#A%20Distributed%20Test%20Environment 2009: the test suite passes for somebody besides Alexandre on Wine: http://www.winehq.org/wwn/355#Test%20Suite%20Passes! Anyone have a graph of test suite size vs. time?

2 1

A proposal for increased security in wine - respecting previously expressed needs
by Guillaume SH 29 Jan '09

29 Jan '09

Hi wine community, I took some time for reflexion following the thread "A step in the wrong direction, in an ocean of steps in the right direction" and to the explanations some of you kindly exposed to me. As a follow-up I am making a proposal. A - The proposal A1 - The core proposal All function callable from outside wine should implement, as the first task they perform(1), a sanity parameter check. This check hasn't to be systematic, only really used parameters should be checked and only checks assuring those parameters can be safely used the way they are in the function implementation (or in a function called by it). Other check are superfluous and must be discarded. So to decline the proposal operationally, I will take an example(2) : BOOL WINAPI GetOverlappedResult(HANDLE hFile, LPOVERLAPPED lpOverlapped, [...]) if ( lpOverlapped == NULL ) { #Call the function ExitWineCleanlyAndAdvertiseUser } This call being justified by the statement, following some lines later : status = lpOverlapped->Internal; The function ExitWineCleanlyAndAdvertiseUser being something like that : <Result to be determined> ExitWineCleanlyAndAdvertiseUser <Parameters to be determined> #1 - Advertise user outputting a message, for example : "The application you used present a defect. Using it directly expose you to some security issue and indirectly expose others users to some other security issue." #2 - Cleanly release all still allocated resources #3 - Cleanly exit wine A2 - offering flexibility As I have understood that wine community is willing to be able to run all applications written for a Windows platform, even those relying on the worse behaviours of windows, I will propose too to add a registry key for the purpose of enabling / disabling wine "safe" mode. In this case it would make sense that "safe" mode is the default, with possibility to fall-back to "unsafe" mode when needed. B - Advantages / Drawbacks to the proposal Drawback of this solution I can think of are : 1 - It is contrary to the current consensus 2 - It implies a lot of work (even if this can be done bit by bit over a long period time, direction is what matters here) 3 - Detailed implementation of what I presented may very well not be as simple as I imagine, or even impossible 4 - Maybe all the reasons have not been expressed in the previous thread, thus not considered here 5 - It can go against the interest of the author of those apps relying on Windows's bad behaviors (large firms for example) 6 - It doesn't cover all security issue in wine and it doesn't cover at all security issue in the calling app 7 - Performance drop-down may be expected (0,01%, 0,1%, 1%, more ? I don't know how to evaluate) Advantage of this solution I can think of are : 1 - Top-notch level of service to user : I can be informed when I use an unsafe software ! 2 - Encouragement to software industry : I must provide some clean and safe software or wine can judge me "unsafe" (=promoting "best-practices") 3 - Wine is better from it, so people will have a better opinion of wine 4 - Goal reached by wine are far beyond "Windows behaviours on free-OS platform" 5 - Wine is safer so more people will want to use it and to promote its usage I think I will go no further than this proposal, so I leave the rest to you, from simply ignoring it to demonstrate me than I'm wrong or applying a variation, Guillaume (1) TRACE, variable declaration or other task may come before though (2) Please don't argue about the coding style, I am not a technical expert (unlike you) and it would be off-topic

6 5

Re: [1/3] d3dxof: Make parsing more permissive about semicolon and comma in objects
by Paul Vriens 29 Jan '09

29 Jan '09

Christian Costa wrote: > > > ------------------------------------------------------------------------ > > Hi Christian, + if ((token != TOKEN_SEMICOLON) && (token != TOKEN_COMMA)) { /* Allow comma instead of semicolon in some specific cases */ if (!((token == TOKEN_COMMA) && ((i+1) < pt->nb_members) && (pt->members[i].type == pt->members[i+1].type) This introduced a DEADCODE warning in Coverity. The code changed was in d3dxof.c but was moved in a later patch to parsing.c. Could you have a look? -- Cheers, Paul.

2 1

Today's git installation error...
by Susan Cragin 29 Jan '09

29 Jan '09

When I installed DNS10 today, the included Visual C++ 8.0 runtime does not load, with the following message. fixme:advapi:LookupAccountNameW (null) L"susan" (nil) 0x33f80c (nil) 0x33f810 0x33f804 - stub fixme:advapi:LookupAccountNameW (null) L"susan" 0x131958 0x33f80c 0x132430 0x33f810 0x33f804 - stub ALSA lib pcm_dmix.c:1008:(snd_pcm_dmix_open) unable to open slave fixme:reg:GetNativeSystemInfo (0x7e1487b4) using GetSystemInfo() wine: Unhandled page fault on write access to 0x7de61520 at address 0x7de61520 (thread 0020), starting debugger... p\{EB7D44B1-C2F5-4B7B-9128-CE4C3D427024}\Visual C++ Runtime for Dragon NaturallySpeaking.msi: server.c:594: server_get_unix_fd: Assertion `wine_server_ptr_handle(fd_handle) == handle' failed. err:seh:raise_exception Exception frame is not in stack limits => unable to dispatch exception. Then I try again, and it does load, and the program installs and runs. ?? I imagine other people have reported this. No need to respond.

2 1

Re: wininet: Implement IsDomainLegalCookieDomainW.
by Juan Lang 29 Jan '09

29 Jan '09

Hi Hans, minor point: + FIXME("(%s, %s)\n", debugstr_w(s1), debugstr_w(s2)); Shouldn't that be TRACE? --Juan

2 3

Re: Ge van Geldorp : ole32/tests: Some Windows versions need the class to be registered.
by Rob Shearman 29 Jan '09

29 Jan '09

2009/1/26 Alexandre Julliard <julliard(a)winehq.org>: > hr = StringFromCLSID(&CLSID_WineTest, &pszClsid); > ok_ole_success(hr, "StringFromCLSID"); > - strcpy(buffer, "CLSID\\"); > + strcpy(buffer, "Software\\Classes\\CLSID\\"); > WideCharToMultiByte(CP_ACP, 0, pszClsid, -1, buffer + strlen(buffer), sizeof(buffer) - strlen(buffer), NULL, NULL); > CoTaskMemFree(pszClsid); > strcat(buffer, "\\InprocHandler32"); > - error = RegCreateKeyEx(HKEY_CLASSES_ROOT, buffer, 0, NULL, 0, KEY_SET_VALUE, NULL, &hkey, &dwDisposition); > - ok(error == ERROR_SUCCESS, "RegCreateKeyEx failed with error %d\n", error); > - error = RegSetValueEx(hkey, NULL, 0, REG_SZ, (const unsigned char *)"ole32.dll", strlen("ole32.dll") + 1); > - ok(error == ERROR_SUCCESS, "RegSetValueEx failed with error %d\n", error); > - RegCloseKey(hkey); > + if (Register) > + { > + error = RegCreateKeyEx(HKEY_CURRENT_USER, buffer, 0, NULL, 0, KEY_SET_VALUE, NULL, &hkey, &dwDisposition); > + ok(error == ERROR_SUCCESS, "RegCreateKeyEx failed with error %d\n", error); > + error = RegSetValueEx(hkey, NULL, 0, REG_SZ, (const unsigned char *)"ole32.dll", strlen("ole32.dll") + 1); > + ok(error == ERROR_SUCCESS, "RegSetValueEx failed with error %d\n", error); > + RegCloseKey(hkey); > + } > + else > + { > + RegDeleteKey(HKEY_CURRENT_USER, buffer); > + *strrchr(buffer, '\\') = '\0'; > + RegDeleteKey(HKEY_CURRENT_USER, buffer); > + } > +} Ge, This appears to have caused some regressions in running the tests on older versions of Windows: http://test.winehq.org/data/d0e77f8a47016c6f69e3a6b5a8bed8f620f1a8f1/nt4_cw… versus before: http://test.winehq.org/data/f63d950df75bdebbad3278790c6c9d11bfe1b226/nt4_cw… While I can see how using HKEY_CURRENT_USER instead of HKEY_CLASSES_ROOT can help developers using a standard user rather than Admin on Windows, I don't see it as useful in general as a lot of the tests emulate what installers do and hence depend on having full access to the system. -- Rob Shearman

2 1

Wine gecko: javascript in the frame
by Konstantin Kondratyuk 29 Jan '09

29 Jan '09

Hi! Javascript which is defined in the frame doesn't work. There is a test in attachement. Run index.html in 'wine iexplore' Correct events for this test (checked up in IE and Firefox): 1. "call f_right script" message 2. "call onLoad" message during loading 3. "call myOnClick" message after click to link Wine gecko ignores all these events. Do you have any advice? Thanks. -- Best regards, Konstantin Kondratyuk.

2 1

Re: advapi32: Fix potential NULL pointer dereference in RegSetValueExA [with test] (Saturn)
by Rob Shearman 29 Jan '09

29 Jan '09

2009/1/26 Aurimas Fišeras <aurimas(a)gmail.com>: > Saturn's error report: > (INCONSISTENT USE) Possible null dereference of variable data+(count-1). > This variable is checked for Null at lines: registry.c:1051 > > Tested on Windows XP > > Changelog: > advapi32: Fix potential NULL pointer dereference in RegSetValueExA > [with test] (Saturn) Excellent, this tool has spotted a corner-case that the code doesn't handle correctly. > From ea7773cc046992e327030fb99935afc5b25c1b4b Mon Sep 17 00:00:00 2001 > From: Aurimas Fischer <aurimas(a)gmail.com> > Date: Mon, 26 Jan 2009 21:55:05 +0200 > Subject: advapi32: Fix potential NULL pointer dereference in RegSetValueExA [with test] (Saturn) > > --- > dlls/advapi32/registry.c | 1 + > dlls/advapi32/tests/registry.c | 4 ++++ > 2 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/dlls/advapi32/registry.c b/dlls/advapi32/registry.c > index 52de6c5..88a89db 100644 > --- a/dlls/advapi32/registry.c > +++ b/dlls/advapi32/registry.c > @@ -1055,6 +1055,7 @@ LSTATUS WINAPI RegSetValueExA( HKEY hkey, LPCSTR name, DWORD reserved, DWORD typ > else if (count && is_string(type)) > { > /* if user forgot to count terminating null, add it (yes NT does this) */ > + if (!data) return ERROR_NOACCESS; This should be moved before the comment to avoid the comment relating to the wrong line. > if (data[count-1] && !data[count]) count++; > } > > diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c > index b63b3e2..0e1b673 100644 > --- a/dlls/advapi32/tests/registry.c > +++ b/dlls/advapi32/tests/registry.c > @@ -383,6 +383,10 @@ static void test_set_value(void) > test_hkey_main_Value_A(name2A, string2A, sizeof(string2A)); > test_hkey_main_Value_W(name2W, string2W, sizeof(string2W)); > > + /* test RegSetValueExA with invalid parameters*/ > + ret = RegSetValueExA(hkey_main, name1A, 0, REG_SZ, NULL, 1); > + ok(ret == ERROR_NOACCESS, "got %d (expected ERROR_NOACCESS)\n", ret); >From the source of RegSetValueExA, this appears to return ERROR_INVALID_PARAMETER on Win9x, so this test case needs to be run on Win9x and fixed if necessary to take this into account. -- Rob Shearman

3 9

Bug in INT32_FindNext blocking Winbench '96?
by Dan Kegel 29 Jan '09

29 Jan '09

http://bugs.winehq.org/show_bug.cgi?id=17181 seems to be a bug in our implementation of DOS FindNext. It's one of the bugs blocking Winbench 96 from running. I'm interested in Winbench 96 simply because it's the only mainstream magazine system benchmark for Windows I've ever even remotely gotten to run on Wine. And bless its soul, it carefully checks return values from DOS system calls. I've already sent in a patch for one problem, but would appreciate some help with this FindNext issue. The code is old and tricky; the interesting bit seems to have been written by Eric ficw years ago during dll separation. If anybody wants my copy of Winbench 96 to help get it running, I'd gladly send it... - Dan

1 0

Worldbench?
by Dan Kegel 29 Jan '09

29 Jan '09

It's hard to keep the benchmark programs straight. I ran into one called Worldbench today in this review http://www.washingtonpost.com/wp-dyn/content/article/2009/01/27/AR200901270… and I see it's used quite a bit: http://www.networkworld.com/reviews/2008/102908-hps-mini-1000-a-new.html It would be nice if we didn't see reviews like this: http://www.pcworld.com/article/142724/200_linux_desktop_systems_are_no_barg… which say "Because these PCs run Linux, not Windows, we couldn't run our WorldBench 6 Beta 2 test suite on them." It looks like Worldbench 6 has been stuck at beta 2 for a long time, so people still reference Worldbench 5 scores. More info: http://www.worldbench.com/ http://www.pcworld.com/article/122812/how_we_test.html http://www.pcworld.com/article/116888/pc_worlds_worldbench_50.html The benchmark costs $250. Has anybody here tried it on Wine? - Dan

2 2