October 2009 - Wine-devel - list.winehq.org

urlmon/protocol tests
by Paul Vriens 07 Oct '09

07 Oct '09

Hi Jacek, I've been looking at the tests reports and we seem to have a few spurious errors: http://test.winehq.org/data/tests/urlmon:protocol.html The ones I mean are: protocol.c:2535: Testing http protocol (direct read)... protocol.c:497: Test failed: unexpected call Switch and protocol.c:2546: Testing https protocol (from urlmon)... protocol.c:612: Test failed: unexpected call ReportProgress_COOKIE_SENT These failures don't happen on every run. Any idea where to start looking? -- Cheers, Paul.

2 4

Re: 1/3 winex11: move XRENDERINFO allocation in a separate function [attempt 2]
by Jacek Caban 07 Oct '09

07 Oct '09

Hi Roderick, Roderick Colenbrander wrote: > Hi, > > This is an updated version which uses a proper function prototype for > alloc_xrenderinfo. Further it checks whether the function succeeded in > XRender_SelectFont. > EnterCriticalSection(&xrender_cs); - if(!physDev->xrender) { - physDev->xrender = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, - sizeof(*physDev->xrender)); - physDev->xrender->cache_index = -1; + if(!physDev->xrender) + { + physDev->xrender = alloc_xrenderinfo(); + if(!physDev->xrender) + return 0; You return without leaving the critical section here. Jacek

1 0

advapi32 : event logging/tracing
by Paul Vriens 07 Oct '09

07 Oct '09

Hi, We currently have advapi32\eventlog.c that deals with event logging related functions. I somebody (i.e. me) would like to start working on the event tracing functions should these go to eventtrace.c or be combined with eventlog.c? Same question for the tests of course. -- Cheers, Paul.

1 0

Re: 2/3 winex11: add get_xrender_picture
by Henri Verbeet 07 Oct '09

07 Oct '09

2009/10/6 Roderick Colenbrander <thunderbird2k(a)gmail.com>: > + if(!physDev->xrender) > + alloc_xrenderinfo(physDev); This doesn't match what alloc_xrenderinfo() in your previous patch does. Note that the compiler would have returned an error here if alloc_xrenderinfo() had a proper prototype.

1 0

Re: 1/3 winex11: move XRENDERINFO allocation in a separate function
by Henri Verbeet 07 Oct '09

07 Oct '09

2009/10/6 Roderick Colenbrander <thunderbird2k(a)gmail.com>: > +static XRENDERINFO alloc_xrenderinfo() That's not a prototype. I'm not entirely sure how strict winex11.drv is about this, but it seems to me that if alloc_xrenderinfo() can return NULL, the calling code should be able to handle that as well.

1 0

Re: dlls/comctl32/monthcal.c fix
by Nikolay Sivov 07 Oct '09

07 Oct '09

Gerald Pfeifer wrote: > Looking at the code I'm 99.9% sure this should be a logical and here > in this new code. > > Gerald > > > ChangeLog: > Use local and instead of bitwise and in MONTHCAL_SetDayFocus(). > > diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c > index a35d261..cd8bd7f 100644 > --- a/dlls/comctl32/monthcal.c > +++ b/dlls/comctl32/monthcal.c > @@ -399,7 +399,7 @@ static void MONTHCAL_SetDayFocus(MONTHCAL_INFO *infoPtr, const SYSTEMTIME *st) > MONTHCAL_CalcPosFromDay(infoPtr, infoPtr->focusedSel.wDay, > infoPtr->focusedSel.wMonth, &r); > > - if(!st & MONTHCAL_ValidateDate(&infoPtr->focusedSel)) > + if(!st && MONTHCAL_ValidateDate(&infoPtr->focusedSel)) > { > static const SYSTEMTIME st_null; > Hi, Gerald. Already done: http://source.winehq.org/git/wine.git/?a=commit;h=87e9e3c37030c293df099395c…

1 0

Re: sti [2/2]: add aggregation tests for the IStillImageW interface
by Paul Vriens 06 Oct '09

06 Oct '09

On 10/05/2009 09:07 PM, Damjan Jovanovic wrote: > Changelog: > * add aggregation tests for the IStillImageW interface > > Unchanged since last time. > > Damjan Jovanovic > > > ------------------------------------------------------------------------ > > Hi Damjan, This patch introduced a test failure on all Windows boxes so far: http://test.winehq.org/data/tests/sti:sti.html Could you have a look? -- Cheers, Paul.

3 2

Try to find out why "Unity3d (3D application)" doesn't work with Wine.
by a qi 06 Oct '09

06 Oct '09

Hi,All I try to run a 3D application named "Unity 3d" with Wine, but failed. And there is already a bug report about that: Bug 18061 - Unity Indie Trial Editor window contents not drawn http://bugs.winehq.org/show_bug.cgi?id=18061 Now I try to find out the reason. So, I follow the error messages: ... err:wgl:internal_SetPixelFormat Couldn't set format of the window, returning failure err:d3d:CreateContext SetPixelFormat failed on HDC=0x1534 for iPixelFormat=3 err:d3d:IWineD3DDeviceImpl_CreateSwapChain Failed to create a new context ... do ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ vim dlls/winex11.drv/opengl.c /* This function is the core of X11DRV_SetPixelFormat and X11DRV_SetPixelFormatWINE. * Both functions are the same except that X11DRV_SetPixelFormatWINE allows you to * set the pixel format multiple times. */ static BOOL internal_SetPixelFormat(X11DRV_PDEVICE *physDev, int iPixelFormat, const PIXELFORMATDESCRIPTOR *ppfd) { WineGLPixelFormat *fmt; int value; HWND hwnd; .... if(!SendMessageW(hwnd, WM_X11DRV_SET_WIN_FORMAT, (WPARAM)fmt->fmt_id, 0)) { ERR("Couldn't set format of the window, returning failure\n"); return FALSE; } } ....... ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ But i can not find the definition of function "SendMessageW", in wine-1.1.30/dlls , i run " grep -ir --color SendMessageW . |grep spec ", just found something like this: ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ ./user32/user32.spec:@ stdcall SendMessageW(long long long long) ./unicows/unicows.spec:@ stdcall SendMessageW(long long long long) ./wtsapi32/wtsapi32.spec:@ stub WTSSendMessageW ./shlwapi/shlwapi.spec:136 stdcall -noname SendMessageWrapW(long long long long) user32.SendMessageW ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ And I am not familiar with C programming. Any ideas? Thanks.

3 2

Re: [user32/tests] Fix some test failures with 9x/Me on VMware (Resend)
by Paul Vriens 06 Oct '09

06 Oct '09

On 10/06/2009 12:54 PM, Alexandre Julliard wrote: > Paul Vriens<paul.vriens.wine(a)gmail.com> writes: > >> On 10/06/2009 11:51 AM, Alexandre Julliard wrote: >>> Paul Vriens<paul.vriens.wine(a)gmail.com> writes: >>> >>>> Hi, >>>> >>>> Resending as I didn't receive any comments. >>>> >>>> Apparently most Win9x and WinMe boxes running under VMware have this issue. >>>> >>>> Changelog >>>> Fix some test failures with 9x/Me on VMware >>> >>> That makes the test essentially useless. >>> >> You main, bail out on first failure? > > I mean figure out why it fails on VMWare, and make it not fail. I expect > the window to get scrolled there too. > Looks like a time/timing issue. Putting a Sleep(100) after the ScrollWindowEx makes the tests pass as well. Is that acceptable? -- Cheers, Paul.

2 1

Re: d3d10core/tests: Add acceptable error code for Win7 device test (Resend)
by Alexandre Julliard 06 Oct '09

06 Oct '09

Ge van Geldorp <ggeldorp(a)vmware.com> writes: > Changelog: > d3d10core/tests: Add acceptable error code for Win7 device test So why does it fail? -- Alexandre Julliard julliard(a)winehq.org

1 0