December 2009 - Wine-devel - list.winehq.org

Re: ddraw: Fix an incorrect refcount test
by Stefan Dösinger 17 Dec '09

17 Dec '09

Am 17.12.2009 um 20:20 schrieb Luke Benstead: > Luke. > <0001-ddraw-Fix-an-incorrect-refcount-test.txt> This patch is correct. The test intends to test DDraw7, there's a DDraw4 test below. So the variable name was wrong, not the macro.

1 0

Re: [shell32/tests] Initialize an APPBARDATA struct (Valgrind)
by Alexandre Julliard 17 Dec '09

17 Dec '09

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > Fixes some Valgrind warnings. > > Changelog > Initialize an APPBARDATA struct (Valgrind) That's just hiding the problem, an app can pass the same structure. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [usrmarshal] Adjust new tests to pass on win9x platforms.
by Jacek Caban 17 Dec '09

17 Dec '09

Hi Jeremy, On 12/17/09 12:13 AM, Jeremy White wrote: > --- > dlls/oleaut32/tests/usrmarshal.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/dlls/oleaut32/tests/usrmarshal.c b/dlls/oleaut32/tests/usrmarshal.c > index e9c53e9..1c770de 100644 > --- a/dlls/oleaut32/tests/usrmarshal.c > +++ b/dlls/oleaut32/tests/usrmarshal.c > @@ -306,7 +306,8 @@ static void test_marshal_LPSAFEARRAY(void) > buffer = HeapAlloc(GetProcessHeap(), 0, size); > init_user_marshal_cb(&umcb,&stub_msg,&rpc_msg, buffer, size, MSHCTX_DIFFERENTMACHINE); > next = LPSAFEARRAY_UserMarshal(&umcb.Flags, buffer,&lpsa); > - ok(next - buffer == expected, "Marshaled %u bytes, expected %u\n", (ULONG) (next - buffer), expected); > + ok(next - buffer == expected || next - buffer + sizeof(DWORD) == expected /*win9x*/, > + "Marshaled %u bytes, expected %u\n", (ULONG) (next - buffer), expected); > It looks like a good place to use broken(). Thanks, Jacek

3 2

Re: [PATCH 6/7] urlmon: Report redirected URL to object created by BindToObject.
by Paul Vriens 17 Dec '09

17 Dec '09

On 12/15/2009 09:16 PM, Jacek Caban wrote: > --- > dlls/urlmon/binding.c | 6 +++++ > dlls/urlmon/tests/url.c | 58 ++++++++++++++++++++++++++++++---------------- > 2 files changed, 44 insertions(+), 20 deletions(-) > Hi Jacek, This one introduced a test failure: http://test.winehq.org/data/tests/urlmon:url.html I didn't find anything common for the boxes/OS, race? Could you have a look? -- Cheers, Paul.

4 4

Re: [PATCH] secur32: Fix memory leak in SECUR32_addPackages. (valgrind)
by James Hawkins 17 Dec '09

17 Dec '09

On Wed, Dec 16, 2009 at 5:07 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, this is for bug 21045. > + SecurePackage *prev_package = NULL; LIST_FOR_EACH_ENTRY(package, &packageTable->table, SecurePackage, entry) { + if (prev_package) + HeapFree(GetProcessHeap(), 0, prev_package); + prev_package = package; HeapFree(GetProcessHeap(), 0, package->infoW.Name); HeapFree(GetProcessHeap(), 0, package->infoW.Comment); } + if (prev_package) + HeapFree(GetProcessHeap(), 0, prev_package); I believe the construct you're looking for is LIST_FOR_EACH_SAFE. grep through the code for examples on using that to safely free and remove elements from a list. -- James Hawkins

2 1

Re: [1/2] gdiplus: Explicitly copy the bits from dib sections to new bitmaps.
by Paul Vriens 17 Dec '09

17 Dec '09

On 12/13/2009 12:59 AM, Vincent Povirk wrote: > Hi Vincent, It appears that this one introduced a test failure: http://test.winehq.org/data/tests/gdiplus:image.html One of the tests that fails now (line 533) was there for a long time it's just that you've added some stuff before that. The other one (line 1058) is because of the other patch "Add test for image palette functions." Could you have a look? -- Cheers, Paul.

2 5

Re: [PATCH] inetcomm/smtptransport.c : Remove some unneeded variables and assigns.
by Juan Lang 16 Dec '09

16 Dec '09

Hi Amine, this patch has no functional benefit. For example, - HRESULT hr; TRACE("\n"); - hr = SMTPTransport_ParseResponse(This, pBuffer, &response); - if (FAILED(hr)) + if (FAILED(SMTPTransport_ParseResponse(This, pBuffer, &response))) This has the dubious benefit of removing a local variable that was used before. I can't fathom why this is a good thing. --Juan

4 7

Re: [PATCH] inetcomm/smtptransport.c : Fix a typo ?
by Juan Lang 16 Dec '09

16 Dec '09

Hi Amine, -static void SMTPTransport_CallbackMessageSendTo(IInternetTransport *iface, char *pBuffer, int cbBuffer); - > The actual function is a little bit under. Um, it's called a prototype, and it's needed to compile smtptransport.c. Have you tested this patch at all? --Juan

2 2

Re: inetcomm/smtptransport.c : Remove some unneeded variables and assigns.
by Austin English 16 Dec '09

16 Dec '09

On Wed, Dec 16, 2009 at 12:28 PM, Amine Khaldi <amine48rz(a)gmail.com> wrote: > WBR, > Amine Khaldi. Out of curiosity, what tool are you using to find these bugs? -- -Austin

3 3

Re: hlink/hlink_main.c : Remove an unneeded assignment.
by Jacek Caban 16 Dec '09

16 Dec '09

Hi Amine, > r = register_clsid(&CLSID_StdHlink); > if (SUCCEEDED(r)) > - r = register_clsid(&CLSID_StdHlinkBrowseContext); > + register_clsid(&CLSID_StdHlinkBrowseContext); > > return S_OK; In this case the correct fix is to return r. Please be more careful then doing janitorial work. There are more places in your patches that seem questionable. You should make sure that we want to ignore an error instead of handling it (and usually we don't) before deleting such assignments. Otherwise it's just hiding bugs. Thanks, Jacek

2 1