December 2009 - Wine-devel - list.winehq.org

Re: inetcomm/smtptransport.c : Remove some unneeded variables and assigns.
by Austin English 16 Dec '09

16 Dec '09

On Wed, Dec 16, 2009 at 12:28 PM, Amine Khaldi <amine48rz(a)gmail.com> wrote: > WBR, > Amine Khaldi. Out of curiosity, what tool are you using to find these bugs? -- -Austin

1 0

Re: [PATCH 07/10] urlmon: Added PARSE_DOMAIN to CoInternetParseUrl
by Paul Vriens 16 Dec '09

16 Dec '09

On 12/15/2009 11:47 PM, Piotr Caban wrote: > --- > dlls/urlmon/internet.c | 32 ++++++++++++++++++++++++++++++++ > dlls/urlmon/tests/misc.c | 23 +++++++++++++++++------ > 2 files changed, 49 insertions(+), 6 deletions(-) > > Hi Piotr, This one has introduced some test failures: http://test.winehq.org/data/tests/urlmon:misc.html Looks more OS than IE specific? Could you have a look? -- Cheers, Paul.

1 0

chromium wine valgrind bot up...
by Dan Kegel 16 Dec '09

16 Dec '09

More progress on my http://wiki.winehq.org/UnitTestSuites effort: Lei and I are running a buildbot that runs win32 chromium's unit tests under wine under valgrind. It just came up yesterday, and we're still working out some kinks, but you can see it at http://build.chromium.org/buildbot/waterfall.fyi/builders/Chromium%20Linux%… Running a real app's test suite under valgrind+wine can find both bugs in wine and bugs in the app; here are examples of both found today by that bot: http://bugs.winehq.org/show_bug.cgi?id=21041 (mismatched GlobalLock/HeapFree in wine?) http://code.google.com/p/chromium/issues/detail?id=30584 (app forgot to initialize a bitmap?) It'll be interesting to see what else this turns up over time.

1 0

Re: [try 2] [2/7] mapi32: Correct the Simple MAPI parameters
by Henri Verbeet 16 Dec '09

16 Dec '09

2009/12/16 Owen Rudge <orudge(a)codeweavers.com>: > +214 stdcall MAPIFindNext(ptr ptr str str long long str) The last parameter is an output parameter.

1 0

Re: [2/5] winemapi: Add Simple MAPI functions
by Henri Verbeet 16 Dec '09

16 Dec '09

2009/12/15 Owen Rudge <orudge(a)codeweavers.com>: > + 1 stdcall MAPIAddress(ptr ptr ptr long ptr long long ptr long ptr ptr) > + 6 stdcall MAPILogoff(long long long long) > +11 stdcall MAPISendMail(long long ptr long long) These don't look quite right to me. Somewhat related, LHANDLE is a ULONG in include/mapi.h, but a ULONG_PTR in my copy of the PSDK.

2 1

Re: msvcrtd: free mem after use (valgrind)
by Paul Vriens 16 Dec '09

16 Dec '09

On 12/16/2009 03:25 PM, André Hentschel wrote: > --- > dlls/msvcrtd/tests/debug.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/msvcrtd/tests/debug.c b/dlls/msvcrtd/tests/debug.c > index 71f6e4c..dc89230 100644 > --- a/dlls/msvcrtd/tests/debug.c > +++ b/dlls/msvcrtd/tests/debug.c > @@ -60,6 +60,8 @@ static void test_new(void) > > mem = pMSVCRTD_operator_new_dbg(42, _NORMAL_BLOCK, __FILE__, __LINE__); > ok(mem != NULL, "memory not allocated\n"); > + if(mem != NULL) > + HeapFree(GetProcessHeap(), 0, mem); > } Hi André, There is no need to check before calling HeapFree. -- Cheers, Paul.

2 1

Re: msvcrtd: free mem after use (valgrind)
by Nikolay Sivov 16 Dec '09

16 Dec '09

On 12/16/2009 17:25, André Hentschel wrote: > --- > dlls/msvcrtd/tests/debug.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/msvcrtd/tests/debug.c b/dlls/msvcrtd/tests/debug.c > index 71f6e4c..dc89230 100644 > --- a/dlls/msvcrtd/tests/debug.c > +++ b/dlls/msvcrtd/tests/debug.c > @@ -60,6 +60,8 @@ static void test_new(void) > > mem = pMSVCRTD_operator_new_dbg(42, _NORMAL_BLOCK, __FILE__, __LINE__); > ok(mem != NULL, "memory not allocated\n"); > + if(mem != NULL) > + HeapFree(GetProcessHeap(), 0, mem); > } > > /**********************************************************************/ > Pointer check is redundant in this case.

1 0

Re: [PATCH 2/3] mmdevapi: Add stubs for MMDevEnum, with tests
by Alexandre Julliard 16 Dec '09

16 Dec '09

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > +static ULONG WINAPI MMDevEnum_Release(IMMDeviceEnumerator *iface) > +{ > + MMDevEnumImpl *This = (MMDevEnumImpl*)iface; > + LONG ref = InterlockedDecrement(&This->ref); > + TRACE("Refcount now %i\n", ref); > + return ref; > +} Sounds like you want a static object here too... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/5] WineD3D: Prepare for dynamic vertex buffers
by Henri Verbeet 16 Dec '09

16 Dec '09

2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > + /* buffer_get_sysmem can remove the BO from dynamic buffers */ No, it can't? > @@ -540,8 +547,8 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateVertexBuffer(IWineD3DDevice *ifac > TRACE("Not creating a vbo because GL_ARB_vertex_buffer is not supported\n"); > } else if(Pool == WINED3DPOOL_SYSTEMMEM) { > TRACE("Not creating a vbo because the vertex buffer is in system memory\n"); > - } else if(Usage & WINED3DUSAGE_DYNAMIC) { > - TRACE("Not creating a vbo because the buffer has dynamic usage\n"); > + } else if(!gl_support_dynamic_buffer(gl_info) && (Usage & WINED3DUSAGE_DYNAMIC)) { > + TRACE("Not creating a vbo because the buffer has dynamic usage but GL doesn't support dynamic buffers\n"); > } else if(!(Usage & WINED3DUSAGE_OPTIMIZE) && conv) { > TRACE("Not creating a vbo because the fvf needs conversion, but VB optimization is disabled\n"); > } else { It seems to me that this and similar code in CreateIndexBuffer() should be in buffer_init() instead.

2 1

Edit control messages through Comctl32 v6 module
by Nikolay Sivov 16 Dec '09

16 Dec '09

Hi. Yesterday I looked at XP introduced messages for Edit controls (EM_SETCUEBANNER/EM_GETCUEBANNER). This definitely doesn't work without v6 module loaded. Does someone have any idea how this supposed to work? Any comments are welcome as usual. P.S. Yes, I know that comctl32 does subclass user32 control but only if theming is active (I mean Wine behavior), anyway this subclass procedure only cares about painting messages, control specific messages require control data manipulation, and this isn't a preferable of course.

4 18