December 2009 - Wine-devel - list.winehq.org

Re: [PATCH 10/10] urlmon: Added tests for CoInternetGetSecurityUrl
by Paul Vriens 16 Dec '09

16 Dec '09

On 12/15/2009 11:48 PM, Piotr Caban wrote: > --- > dlls/urlmon/tests/sec_mgr.c | 31 +++++++++++++++++++++++++++++++ > 1 files changed, 31 insertions(+), 0 deletions(-) > > Hi Piotr, Is there a way to avoid using lstrmcpW as that will always fail (or the !lstrcmpW case will always succeed) on Win9x/WinMe? It looks like the rest of this file use memcmp to compare strings. -- Cheers, Paul.

2 2

Re: [10/10] rpcrt4: Add tests for RPC calls with authentication.
by Paul Vriens 16 Dec '09

16 Dec '09

Hi Rob, I took the liberty of running these tests on winetestbot. It shows two errors for W2K and above: https://winetestbot.geldorp.nl/JobDetails.pl?Key=115 -- Cheers, Paul.

3 7

strangeness under Dec 14th Wine Git
by chris ahrendt 15 Dec '09

15 Dec '09

Just a little nit I noticed with yesterdays Git tree... When you give a window other than the wine window the focus... the wine window does not go into the background... so IF I have 2 or 3 windows open with a wine app running and click on say thunderbird... or firefox to look something up I have to move the wine window to the bottom of the screen. It looses focus (turns grey) but does not go to the background... Chris

1 0

[rfc] Provide separate operator vector new and delete in msvcrt; let valgrind check them
by Dan Kegel 15 Dec '09

15 Dec '09

First draft for discussion. Not, um, well tested yet. ANSI C++ mandates separate vector versions of new and delete that do the same thing as the non-vector versions, but which can be replaced by user apps (see http://www.csci.csusb.edu/dick/c++std/cd2/lib-support.html#lib.new.delete ) So far, so good; wine does that in msvcrt. However, once in a while, a programmer will call delete when he should have called delete[], and a bunch of destructors won't get called. To detect this programming error, let's split the vector new and delete functions off from their scalar twins, and add values for the heap function flags so we can inform valgrind what kind of blocks are being wrangled. This means picking two flag bits that Microsoft doesn't use; there seem to be enough to go around. Requires the corresponding patch to valgrind ttps://bugs.kde.org/show_bug.cgi?id=218741 Thanks to Steve Vandebogart for his help on this; he wrote a bunch of it.

2 1

Tests for GetLongPathName
by Paul Vriens 15 Dec '09

15 Dec '09

Hi Alexandre, Several file related functions have a maximum path size of 32767 when using a "\\?\" prefix. Testing these large paths only works on Windows due to Linux having a maximum path limit of 4096. Does it still make sense to add these tests or should I focus on <= 4096? I guess if we/Wine have a limit due to the OS we are running on we should probably act the same as that higher limit on Windows? -- Cheers, Paul.

2 1

Re: [PATCH 1/3] mmdevapi: Add class factory
by Alexandre Julliard 15 Dec '09

15 Dec '09

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > +static ULONG WINAPI MMCF_Release(LPCLASSFACTORY iface) > +{ > + IClassFactoryImpl *This = (IClassFactoryImpl *)iface; > + ULONG ref = InterlockedDecrement(&(This->ref)); > + TRACE("(%p) ref was %d\n", This, ref + 1); > + /* static class, won't be freed */ You don't need a refcount then. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdiplus: Fix a memory leak in the tests.
by Nikolay Sivov 15 Dec '09

15 Dec '09

On 12/15/2009 14:35, Huw Davies wrote: > Found by Valgrind. > --- > dlls/gdiplus/tests/customlinecap.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Hi, Huw. This leak will be fixed with corrected GdipCreateCustomLineCap(). Return code should never be Ok here. P.S. Same with previous patch for GdipCreateFontFamilyFromNam().

2 1

Re: [3/3] WineD3D: Don't enable render_to_fbo on single buffered swapchains
by Henri Verbeet 15 Dec '09

15 Dec '09

2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > > Am 15.12.2009 um 08:14 schrieb Henri Verbeet: > >> 2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: >>> + && present_parameters->BackBufferCount > 0 >> "BackBufferCount" is unsigned. > Not even -Wall -pedantic complains about this, but okay. This patch compares against unsigned constants. > My point was just that you might as well just write "present_parameters->BackBufferCount", since it's never going to be below zero.

1 0

Re: msi: Replace the string table hash with a sorted index.
by Hans Leidekker 15 Dec '09

15 Dec '09

On Tuesday 15 December 2009 09:51:20 Hans Leidekker wrote: > Addresses a performance bottleneck in the Visual Studio 2005 installer. > See http://bugs.winehq.org/show_bug.cgi?id=14168 > --- > dlls/msi/msipriv.h | 2 +- > dlls/msi/string.c | 147 ++++++++++++++++++++++++++++++++++++++-------------- > 2 files changed, 109 insertions(+), 40 deletions(-) Please disregard this patch, Henri pointed out some improvements that can be made. -Hans

1 0

winetricks directx testers needed
by Austin English 15 Dec '09

15 Dec '09

Howdy all, I e-mailed wine-users a few days ago, but had no volunteers. I know most of you here aren't the target audience for using winetricks directx9, but since neither Dan or I game much, we need a guinea pig ;-). Long story short, someone complained that 'winetricks directx9' crashes on OS X, but works if the windows version is set to xp instead of 2k. I've played around with it a bit, and it seems that using xp gives a different set of installed files. Which one works better for games, however, I don't know. So, test it please. If you get wine from SVN, there's a beta of it: http://winezeug.googlecode.com/svn/trunk/winetricks just use 'winetricks directx9-beta' for the XP version, and 'winetricks directx9' for windows 2k (on OS X, it forces directx9-beta). Please let me know which version works better for games that need it. Any problems, file a bug at winezeug (http://code.google.com/p/winezeug/issues/list) For faster service, shoot me an e-mail, since I don't get e-mail notifications of any new bugs there... -- -Austin

3 6