November 2010 - Wine-devel - list.winehq.org

TestBot IPv6 enabled
by Greg Geldorp 17 Nov '10

17 Nov '10

Hi, All TestBot VMs (with the exception of the Win9x ones) now have IPv6 connectivity. I was surprised that there was even a IPv6 stack available for NT4, it was produced by Microsoft Research. The VMs are (and always have been) behind a IPv4 NAT router. That same router now acts as a IPv6 router/firewall, with full outbound access but blocked inbound access. The website is also IPv6 capable, just waiting for the AAAA record to be added to the nameserver. Greg.

3 6

Re: 回复： how to use wcslen() in wine?
by Damjan Jovanovic 17 Nov '10

17 Nov '10

Add -DUNICODE to the wineg++ options. TCHAR is char without it. 2010/11/17 飞翔 <gengjia.ding(a)qq.com> > I try as you said in my program as below: > #include <windows.h> > #include <stdio.h> > #include <wchar.h> > > int main() > { > DWORD dwItems = 1; > TCHAR ptszIPAddress[32] = TEXT("125.216.242.251"); > dwItems = (DWORD)wcslen((const wchar_t*)ptszIPAddress) + 1; > printf("dwItems %d\n", dwItems); > return 0; > } > but the result of the variable dwItems is 9, while in Windows environment > is 16, why? > > > > > ------------------ 原始邮件 ------------------ > *发件人:* "Damjan Jovanovic"<damjan.jov(a)gmail.com>; > *发送时间:* 2010年11月16日(星期二) 凌晨2:14 > *收件人:* "飞翔"<gengjia.ding(a)qq.com>; > *抄送:* "wine-devel"<wine-devel(a)winehq.org>; > *主题:* Re: how to use wcslen() in wine? > > Try: > wineg++ -I /usr/include/wine/include/msvcrt file.cpp -o file -lmsvcrt > > 2010/11/15 飞翔 <gengjia.ding(a)qq.com> > > > > > > > > hello, I'm developing under Wine environment. > > I'm using Unicode and I want to be able to use standard library call > wcslen, but I don't know how to change my C library from the native glibc C > library to the msvcrt C library. > > As it is described in "Winelib_User's_Guide":"In these cases you should > use msvcrt to provide your C runtime calls. > > import msvcrt.dll > > to your applications .spec file." > > I'm using wineg++ to compile the .cpp & .h files, there is no .spec file, > how can I import the DLL? > > May you please help me? Thanks very much! > > > > > > ------------------ > > Where there is a will, there is a way! > > ------------------ > > 丁耿佳 > > Gavin-Ding > > Computer Science and Technology，South China University of Technology > > Email: gj.ding(a)mail.scut.edu.cn > > gengjia.ding(a)gmail.com > > gengjia.ding(a)qq.com > > Mailing Address: 339, Building C12, SCUT, GuangzhouHigher Education Mega > Center, Guangzhou, China > > Postcode:510006 > > > > > > > > > > >

1 0

Re: [1/2] comctl32/treeview: Use a code set by dispinfo holder to convert data encoding after TVN_GETDISPINFO
by Marvin 17 Nov '10

17 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7104 Your paranoid android. === WVISTAADM (32 bit treeview) === treeview.c:1349: Test failed: got 0xffffffff treeview.c:1355: Test failed: got 0xffffffff

2 1

Re: [2/3] oleaut32: Use strtoull() instead of multiplication during variant conversion
by Nikolay Sivov 17 Nov '10

17 Nov '10

On 11/17/2010 02:00, Adam Martinson wrote: > --- > dlls/msxml3/tests/domdoc.c | 4 ++-- > dlls/oleaut32/variant.c | 17 +++++++++-------- > 2 files changed, 11 insertions(+), 10 deletions(-) > If oleaut32 needs a fix like this, please add a test for it in oleaut32/tests, fixed msxml tests will be a side effect. > */ > BOOL bOverflow = FALSE, bNegative; > ULONG64 ul64 = 0; You don't need this initialization now. > + char tmp[1024], *end; Does this buffer size really make sense if you're getting ULONG64 from this string? > int i; > > /* Convert the integer part of the number into a UI8 */ > - for (i = 0; i< wholeNumberDigits; i++) > + for (i = 0; i< wholeNumberDigits; ++i) > + tmp[i] = rgbDig[i] + '0'; > + tmp[wholeNumberDigits] = 0; > + > + ul64 = strtoull(tmp,&end, 10); > + if (end !=&tmp[wholeNumberDigits]) > { > - if (ul64> (UI8_MAX / 10 - rgbDig[i])) > - { > - TRACE("Overflow multiplying digits\n"); > - bOverflow = TRUE; > - break; > - } > - ul64 = ul64 * 10 + rgbDig[i]; > + TRACE("Overflow reading digits\n"); > + bOverflow = TRUE; > } >

1 0

Re: comctl32/listview: Use a code set by dispinfo holder to convert data encoding after LVN_GETDISPINFO
by Marvin 17 Nov '10

17 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7103 Your paranoid android. === W7PRO (32 bit listview) === listview.c:4458: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4463: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === W7PROX64 (32 bit listview) === listview.c:4458: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4463: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

Re: [PATCH 5/5] shell32/tests: Added SHPropStg* tests (try2)
by Alexandre Julliard 16 Nov '10

16 Nov '10

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/shell32/tests/Makefile.in | 1 + > dlls/shell32/tests/misc.c | 437 > ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 438 insertions(+), 0 deletions(-) > create mode 100644 dlls/shell32/tests/misc.c It would be better to either put those in an existing file, or create a shellole.c file. misc.c is not a very informative name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ole32: Avoid console flood with an ERR message
by Alexandre Julliard 16 Nov '10

16 Nov '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -3657,7 +3657,14 @@ HRESULT WINAPI CoWaitForMultipleHandles(DWORD dwFlags, DWORD dwTimeout, > } > else > { > - ERR("Unexpected wait termination: %d, %d\n", res, GetLastError()); > + static DWORD old_res; > + static DWORD old_lasterror; > + if ((res != old_res) || (GetLastError() != old_lasterror)) > + { > + old_res = res; > + old_lasterror = GetLastError(); > + ERR("Unexpected wait termination: %d, %d\n", res, GetLastError()); > + } That's just hiding the problem. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] gdi32: Implement CreateScalableFontResource, based on a patch by Jeremy White.
by Alexandre Julliard 16 Nov '10

16 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + /* empty type info */ > + memset(&rc_type, 0, sizeof(rc_type)); > + if (!WriteFile(hfile, &rc_type, sizeof(rc_type), &dummy, NULL)) return FALSE; > + > + if (!WriteFile(hfile, "\7FONTDIR", 8, &dummy, NULL)) return FALSE; > + str_len = strlen(resident_name); > + if (!WriteFile(hfile, &str_len, 1, &dummy, NULL)) return FALSE; > + if (!WriteFile(hfile, resident_name, str_len, &dummy, NULL)) return FALSE; > + if (!WriteFile(hfile, filler, 5, &dummy, NULL)) return FALSE; > + > + str_len = strlen(non_resident_name); > + if (!WriteFile(hfile, &str_len, 1, &dummy, NULL)) return FALSE; > + if (!WriteFile(hfile, non_resident_name, str_len, &dummy, NULL)) return FALSE; > + /* terminator */ > + if (!WriteFile(hfile, filler, 1, &dummy, NULL)) return FALSE; > + > + /* empty ne_modtab and ne_imptab */ > + if (!WriteFile(hfile, filler, 2, &dummy, NULL)) return FALSE; > + > + if (!write_pad(hfile)) return FALSE; > + > + if (!WriteFile(hfile, fd, fd->dfSize, &dummy, NULL)) return FALSE; > + > + if (!write_pad(hfile)) return FALSE; > + > + if (!WriteFile(hfile, ttf_file_nameA, strlen(ttf_file_nameA), &dummy, NULL)) return FALSE; > + > + if (!write_pad(hfile)) return FALSE; That's ugly and inefficient. The data should be built into a memory buffer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] gdi32: Separate font loading from adding a font to global font list. (resend)
by Alexandre Julliard 16 Nov '10

16 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -365,7 +365,7 @@ static struct list system_links = LIST_INIT(system_links); > > static struct list font_subst_list = LIST_INIT(font_subst_list); > > -static struct list font_list = LIST_INIT(font_list); > +static struct list global_font_list = LIST_INIT(global_font_list); I don't see any reason to rename the variable, that makes the patch much larger than necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: Add new debuglevel 2 for showing broken behaviours as failed
by Alexandre Julliard 16 Nov '10

16 Nov '10

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -285,7 +285,7 @@ void winetest_set_location( const char* file, int line ) > > int broken( int condition ) > { > - return (strcmp(winetest_platform, "windows") == 0) && condition; > + return (strcmp(winetest_platform, "windows") == 0) && condition && winetest_debug < 2; > } You can already change the platform, there's no need for a new mechanism. -- Alexandre Julliard julliard(a)winehq.org

1 0