November 2010 - Wine-devel - list.winehq.org

Re: ntdll/tests: add tests for NtQueryVolumeInformationFile with FileFsVolumeInformation class
by Marvin 24 Nov '10

24 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7217 Your paranoid android. === W98SE (32 bit file) === No test summary line found

2 1

Re: [1/2] msvcrt: Fixes multi-byte detection problem with MSVCRT_isleadbyte() (try 2)
by Piotr Caban 24 Nov '10

24 Nov '10

_mbspbrk function needs to be fixed, not isleadbyte. Cheers, Piotr

2 1

Volunteer needed - a Lurker would be perfect!
by Jeremy White 24 Nov '10

24 Nov '10

Hi Folks, Throughout the years, Wine has been lucky to have a procession of great volunteers who work on areas outside the code. And right now, we find ourselves in need of a new Wine Weekly News editor. Zachary Goldberg, our current editor, has really not been able to find the time to keep up and would appreciate it if someone else was willing to volunteer. What we need is someone who is willing to read wine-devel, and perhaps scan wine-users, and put together a periodic high level description of activity within Wine. It probably wouldn't have to be weekly; monthly would be just fine. The only requirements are enough technical background that you can make some sense of the mailing list information, some modest skills with the written word, and the willingness to help. In exchange, you'll earn fame, fortune (well, okay, maybe a free beverage once a year), and the deep satisfaction of being a critical voice for the Wine project. If you're interested, email me privately. Cheers, Jeremy

1 0

Wineconf notes?
by Damjan Jovanovic 24 Nov '10

24 Nov '10

Hi Can those of us that didn't go to Wineconf this year please see some videos/slides/notes from those that did? Thank you Damjan Jovanovic

2 1

Re: msvcrt: Add missing dereference of the time pointer.
by Eryk Wieliczko 24 Nov '10

24 Nov '10

Yes, you're right. Thank you for spotting. Eryk 2010/11/24 Michael Stefaniuc <mstefani(a)redhat.de>: > --- > Eryk, > > I guess this is what you had in mind as checking the pointer for greater > 0 is redundant as it is already not-NULL. > > > > > dlls/msvcrt/time.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/msvcrt/time.c b/dlls/msvcrt/time.c > index 7ccdc7d..4150156 100644 > --- a/dlls/msvcrt/time.c > +++ b/dlls/msvcrt/time.c > @@ -913,7 +913,7 @@ int CDECL MSVCRT__ctime64_s(char *res, MSVCRT_size_t len, const MSVCRT___time64_ > return MSVCRT_EINVAL; > } > res[0] = '\0'; > - if( !MSVCRT_CHECK_PMT( time != NULL ) || !MSVCRT_CHECK_PMT( time > 0 ) ) > + if( !MSVCRT_CHECK_PMT( time != NULL ) || !MSVCRT_CHECK_PMT( *time > 0 ) ) > { > *MSVCRT__errno() = MSVCRT_EINVAL; > return MSVCRT_EINVAL; > @@ -946,7 +946,7 @@ int CDECL MSVCRT__ctime32_s(char *res, MSVCRT_size_t len, const MSVCRT___time32_ > return MSVCRT_EINVAL; > } > res[0] = '\0'; > - if( !MSVCRT_CHECK_PMT( time != NULL ) || !MSVCRT_CHECK_PMT( time > 0 ) ) > + if( !MSVCRT_CHECK_PMT( time != NULL ) || !MSVCRT_CHECK_PMT( *time > 0 ) ) > { > *MSVCRT__errno() = MSVCRT_EINVAL; > return MSVCRT_EINVAL; > -- > 1.7.3.2 >

1 0

COM implementation clean up
by Jacek Caban 24 Nov '10

24 Nov '10

Hi all, As many of you probably know, we currently have no standard way for implementing COM objects in Wine. We use different techniques all over the place. Some of them are better, other are worse or even ugly. Together with Alexandre, we've chosen the technique that we believe is the best known ATM. I've described it on the wiki page: http://wiki.winehq.org/COMGuideline There is a janitorial task to change all our existing code to follow the guideline. Michael is going to use his scripting magics to do the work. The plan is that all the new code should follow the guideline, so if you are touching COM stuff in Wine, please get familiar with it. Any comments are welcomed. Cheers, Jacek

3 2

Re: ntdll: return some sane values for the FileFsVolumeInformation class members in NtQueryVolumeInformationFile.
by Vitaliy Margolen 24 Nov '10

24 Nov '10

On 11/23/2010 01:05 PM, Louis Lenders wrote: > This patch makes previously tests pass and fixes > http://bugs.winehq.org/show_bug.cgi?id=21466. (A search through the registry > on windows showed that at least the VolumeLabel and SerialNumber are not > stored in the registry, so we just return some sane values) > + static const WCHAR volumelabelW[] = {'w','i','n','e','_','d','i','s','k',0}; > + > + info->VolumeSerialNumber = 0x15112000; You should take that info from the volume (as it's done now in GetVolumeInformation) instead of hard-coded invalid values. I'm guessing some of that kernel32 functionality will need to be moved to ntdll. Vitaliy.

1 0

Re: services: Allow one more combined service type
by Paul Vriens 23 Nov '10

23 Nov '10

Hi André, On 11/23/2010 08:45 PM, André Hentschel wrote: > I have a service with type 3, this patch allows him to run. > It runs perfectly and does not produce FIXMEs or ERRORs, so it's fine. > --- Do you have some more information? It's not possible (at least on XP) to create a service that has 'SERVICE_KERNEL_DRIVER | SERVICE_FILE_SYSTEM_DRIVER'. -- Cheers, Paul.

2 2

Re: crypt32/tests: Add tests for decoding enveloped messages.
by Paul Vriens 23 Nov '10

23 Nov '10

Hi Alexander, On 11/02/2010 01:56 PM, Alexander Morozov wrote: > + CryptAcquireContextA(&hCryptProv, NULL, MS_ENHANCED_PROV_A, PROV_RSA_FULL, > + CRYPT_VERIFYCONTEXT); Other calls use pCryptAcquireContextA but I guess that had to do with some platforms in the past that didn't export CryptAcquireContextA. > + SetLastError(0xdeadbeef); > + ret = CryptImportKey(hCryptProv, publicPrivateKeyPair, > + sizeof(publicPrivateKeyPair), 0, 0,&key); > + ok(ret, "CryptImportKey failed: %08x\n", GetLastError()); This one fails on some WinME/NT4 (80090010 aka NTE_PERM) and crashes on some Win98: http://test.winehq.org/data/tests/crypt32:msg.html Could you have a look? If you need me to test something on my boxes (pv-winme and pv-nt4srvr) let me know (not all testbot machines fail here). -- Cheers, Paul.

2 1

Trying to figure out the website redirects
by Scott Ritchie 23 Nov '10

23 Nov '10

Why does http://www.winehq.org/todo redirect to http://wiki.winehq.org/KnownIssues ? The only list of redirects I see in the source is in include/htaccess.sample, however it lists /todo as redirecting to http://wiki.winehq.org/TodoList (which itself isn't a redirect) Are there redirects on the server that aren't in the git source? -Scott Ritchie

1 0