February 2010 - Wine-devel - list.winehq.org

Re: Hans Leidekker : msi: Add summary information stream to the streams table.
by Nikolay Sivov 19 Feb '10

19 Feb '10

On 2/19/2010 18:21, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 1ff992314887d03abeb4098789701ff3bfd5d2d8 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=1ff992314887d03abeb409878… > > Author: Hans Leidekker<hans(a)codeweavers.com> > Date: Fri Feb 19 12:27:36 2010 +0100 > > msi: Add summary information stream to the streams table. > Hi, Hans. Bad news about this one I'm afraid. It breaks a Sun JRE install (jre-6u16-windows-i586-s to be exact). It fails with following output: --- err:msidb:TABLE_fetch_stream fetching stream L"Binary.RegUtilsMSI", error = 1627 err:msi:store_binary_to_temp Failed to get stream err:msi:ITERATE_Actions Execution halted, action L"IsMozillaInstalled" returned 13 err:msidb:TABLE_fetch_stream fetching stream L"Binary.NewBinary7", error = 1627 err:msi:msi_dialog_bitmap_control Failed to load bitmap L"NewBinary7" err:msidb:TABLE_fetch_stream fetching stream L"Binary.NewBinary11", error = 1627 err:msi:msi_dialog_bitmap_control Failed to load bitmap L"NewBinary11" --- and installer reports error that wizard was interrupted (no crash). Do you want a bug report for this or you got what a regression is about?

2 2

Re: msxml3: Accept IObjectSafety for query from IXMLDOMDocument, fix its implementation.
by Paul Vriens 19 Feb '10

19 Feb '10

On 02/19/2010 11:48 AM, Nikolay Sivov wrote: > Accept IObjectSafety for query from IXMLDOMDocument, fix its implementation > Hi Nikolay, This one introduces some test failures: http://test.winehq.org/data/tests/msxml3:domdoc.html Could you have a look? -- Cheers, Paul.

2 1

Re: [PATCH] shell32: Allow copy operation to overwrite an existing write protected file + tests
by Nikolay Sivov 19 Feb '10

19 Feb '10

On 2/19/2010 17:34, Christian Costa wrote: > --- > > dlls/shell32/shlfileop.c | 10 +++++++++- > dlls/shell32/tests/shlfileop.c | 20 ++++++++++++++++++++ > 2 files changed, 29 insertions(+), 1 deletions(-) > Correct me if I'm wrong, but isn't SetFileAttributes dependent on user security permissions? I mean will it work as expected if this call fails for that reason?

2 1

Re: [PATCH 3/3] kernel32/tests: Test for 'all processors' now valid (try 2).
by Charles Davis 19 Feb '10

19 Feb '10

Erich Hoover wrote: > Real Name: > Erich Hoover > Description: > Patch 2 added support for the "all processors" flag, so this is > no-longer a todo. This version is against the revised patch 1, please > note that patch 2 is unchanged. > ChangeLog: > kernel32/tests: Test for 'all processors' now valid. Patches 2 and 3 should be merged. If patch 2 is applied without patch 3, then we'll get "test succeeded inside todo block" failures. Chip

3 2

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer (try 2).
by Henri Verbeet 19 Feb '10

19 Feb '10

On 19 February 2010 05:22, Erich Hoover <ehoover(a)mines.edu> wrote: > Real Name: > Erich Hoover > Description: > The attached patch adds a test for > SetThreadAffinityMask(thread,-1), which succeeds on Windows Vista and > newer. This version uses broken() rather than specifically testing > versions. Note that this "all processors" flag is not documented, but > was discovered tracking down another issue. Please see the wine-devel > thread for more information: > http://www.winehq.org/pipermail/wine-devel/2010-February/081879.html > ChangeLog: > kernel32/tests: Add test for 'all processors' flag on Vista and newer. > Shouldn't this need tests for NtSetInformationThread() and NtQueryInformationThread() as well?

1 0

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.
by Andrew Nguyen 19 Feb '10

19 Feb '10

On Thu, Feb 18, 2010 at 8:51 PM, Erich Hoover <ehoover(a)mines.edu> wrote: > Real Name: > Erich Hoover > Description: > The attached patch adds a test for > SetThreadAffinityMask(thread,-1), which succeeds on Windows Vista and > newer. This "all processors" flag is not documented, but was > discovered tracking down another issue. Please see the wine-devel > thread for more information: > http://www.winehq.org/pipermail/wine-devel/2010-February/081879.html > ChangeLog: > kernel32/tests: Add test for 'all processors' flag on Vista and newer. > > > > The test shouldn't query the Windows version explicitly. Instead, the older return value on pre-Vista version should be denoted by the broken() macro.

3 5

Multi-processor difference between Windows versions
by Erich Hoover 18 Feb '10

18 Feb '10

In exploring a bug in a game we* ran across an interesting difference between how Windows versions handle a multiple-processor request. In essence, this supposedly invalid request will succeed on newer Windows versions **: SetThreadAffinityMask(curthread,(-1)); So, the question I have is whether Wine should support this behavior as a matter of course or if it should only support this request when the emulated version is set to Vista or greater. It seems to me like this should be supported as a matter of course, since anyone who uses this "feature" is unlikely to have properly tested it on multiple versions of Windows. However, I'm unfamiliar with the policy on these version-difference matters and figured I should ask before putting something together. Erich Hoover ehoover(a)mines.edu * http://bugs.winehq.org/show_bug.cgi?id=21165 ** https://winetestbot.geldorp.nl/JobDetails.pl?Key=747

2 1

Intercepting GDI calls
by Jui-Hao Chiang 18 Feb '10

18 Feb '10

Hi, all: I am currently starting a project which tries to run a window application on one (source) machine, and display on another (destination) machine. Of course, the VNC or X11 forwarding technique can achieve the same goal, but I am trying to reduce the bandwidth by "not" transferring the video frame buffer but transfer the GDI function calls instead. The way I can see is try to intercept all the calls inside gdi32.dll, and forward the calls and parameters to remote machine by using some RPC library, and then replay the GDI calls on the destination machine. However, I have two doubts: (1) It seems like the user32.dll is actually handling the window, menu, and cursor. Does the drawing of menu and cursor depends on user-level gdi32.dll? or other kernel-level dlls? (2) It seems that there is no corresponding win32k.sys implementation in wine, and the user-level GDI calls seems to be forwarded to winex11.drv, right? I wander is there any good way or a place inside the source to do this kind of interception? Appreciate any suggestions, Jui-Hao

8 11

Re: advapi32/tests: Avoid crashing if ReadEventLogA fails.
by Paul Vriens 18 Feb '10

18 Feb '10

Hi Alexandre, + if (ReadEventLogA(handle, EVENTLOG_SEQUENTIAL_READ | EVENTLOG_FORWARDS_READ, + 0, buf, sizeof(EVENTLOGRECORD), &read, &needed)) + { I don't think this is correct. The first call will always fail as the buffer is not big enough. This now introduces a test failure on Vista without a servicepack (what this piece of code was meant to check). I guess a 'better' fix would have been to set needed to 0 in our implementation until ReadEventLog is fully implemented. -- Cheers, Paul.

1 0

Is this a bug or feature incompleteness
by MD.IMAM HOSSAIN 18 Feb '10

18 Feb '10

The bug is from DirectX 8.1 SDK, C++ samples, Direct3D samples, SkinnedMesh. Please, see the attached file for clear idea. Tested with latest wine 1.1.38 Best regards, MD. IMAM HOSSAIN

2 1