February 2010 - Wine-devel - list.winehq.org

Re: [PATCH] include: Don't accidentally redefine a member in struct _IRP (LLVM/Clang).
by Charles Davis 23 Feb '10

23 Feb '10

Disregard this patch, it breaks ntoskrnl. New patch forthcoming. Chip

1 0

Summer of code idea: make tiny game demos to expose problems in Wine
by Dan Kegel 23 Feb '10

23 Feb '10

I've just added http://wiki.winehq.org/SummerOfCode#head-5cdc861e4369f94f0af19d09710d33d76b… Current text: "Big games are hard to debug. Small demo games show interesting problems in Wine (see e.g. http://bugs.winehq.org/buglist.cgi?quicksearch=3drad ) There are lots of tools (see http://wiki.winehq.org/GameEngines ) that make developing tiny games easy Let's try making the smallest possible demo games that show problems in Wine, and file bugs for what we find (along with the source for the games/demos)." Anyone want to help mentor?

5 6

Re: [2/5] WineD3D: Add an internal event query finish function
by Henri Verbeet 23 Feb '10

23 Feb '10

On 26 January 2010 11:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +HRESULT wined3d_event_query_finish(IWineD3DQuery* iface) { Please don't create function prototypes (or other code) by copy/paste. Also, why does this take a IWineD3DQuery pointer in the first place? You only really access wined3d_event_query fields. > + /* A glFinish does not reliably wait for draws in other contexts. The caller has > + * to find its own way to cope with the thread switch > + */ ... > + /* Since this is an internal call the caller should know that event Query support is faked */ > + FIXME("(%p): Event query not supported, calling glFinish\n", This); > + wglFinish(); > + return WINED3D_OK; > + } This is inconsistent. Also, note that event queries are pretty generic things, you could use them for something else than draws as well. > + if (!gl_info->supported[APPLE_FENCE] && !gl_info->supported[NV_FENCE] && gl_info->supported[ARB_SYNC]) This doesn't make sense. Of course if you just used wined3d_event_query instead of IWineD3DQuery you wouldn't even need this at all, you could just let context_alloc_event_query() fail. Just for reference, glFinish() behaviour is a bit more subtle than you make it sound. It flushes GL commands for the current context to the GPU, and then waits for the GPU to finish execution up to that point. It won't flush command buffers for other contexts, but anything that's already been submitted to the GPU before the glFinish() will have been executed when the glFinish() returns. I didn't look at the other patches much, but I think you want to look them over a bit before resending as well.

2 8

Re: include[1/2]: add a strcmpW-equivalent function usable in tests.
by Paul Vriens 23 Feb '10

23 Feb '10

On 02/20/2010 10:52 PM, Mikołaj Zalewski wrote: > As I've learned, lstrcmpW doesn't work under Windows 9x, thus it is > not a good choice to test functionality that existed in these version of > Windows. On the other hand, strcmpW is not available on standalone > builds on Windows. However, this function is so simple, that we can > duplicate the implementation. > hi Alexandre, Is the idea to now use this function instead of all those different ones currently present in the tests? -- Cheers, Paul.

2 2

Re: include[1/2]: add a strcmpW-equivalent function usable in tests.
by Paul Vriens 23 Feb '10

23 Feb '10

On 02/20/2010 10:52 PM, Mikołaj Zalewski wrote: > As I've learned, lstrcmpW doesn't work under Windows 9x, thus it is > not a good choice to test functionality that existed in these version of > Windows. On the other hand, strcmpW is not available on standalone > builds on Windows. However, this function is so simple, that we can > duplicate the implementation. > Hi Alexandre, Is the idea to use this function instead of all those different ones currently present in the tests (and where needed replace lstrcmpW)? -- Cheers, Paul.

1 0

Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams.
by Alexandre Julliard 23 Feb '10

23 Feb '10

Reece Dunn <msclrhd(a)googlemail.com> writes: > @@ -395,9 +395,11 @@ static HRESULT WINAPI HGLOBALStreamImpl_Seek( > * If the file pointer ends-up after the end of the stream, the next Write operation will > * make the file larger. This is how it is documented. > */ > - if (dlibMove.QuadPart < 0 && newPosition.QuadPart < -dlibMove.QuadPart) return STG_E_INVALIDFUNCTION; > + if (dlibMove.u.LowPart < 0 && newPosition.u.LowPart < -dlibMove.u.LowPart) > + return STG_E_INVALIDFUNCTION; This doesn't make sense, LowPart is unsigned. -- Alexandre Julliard julliard(a)winehq.org

1 0

ptrace regression in Linux 2.6.33-rcX breaking Wine
by Michael Stefaniuc 23 Feb '10

23 Feb '10

Hello guys, in case you have a Wine app that stopped working on Linux and you use 2.6.33-rcX kernels please give 2.6.32 a whirl. I finally sat down to track why the ntdll exception tests started to fail on my machines but not on other Fedora boxes. Turns out to be a regression in the Linux kernel: http://bugzilla.kernel.org/show_bug.cgi?id=15273 thanks bye michael

2 2

Another aspiring GSoC applicant..
by David Hedberg 23 Feb '10

23 Feb '10

Hi everyone! Maybe it's a bit early, but I thought I would announce my interest in participating as a student in this years GSoC. I'm currently busy studying for my degree in Computer Engineering here in Sweden, and I have realized that it would be really nice if I were able to spend a few months doing something useful for one of the in my opinion most interesting open source projects out there.. ;-) I'm not completely new to wine as I have been following the wine-devel mailing list for a few years now and have also managed to get past the Julliard Test with a handful of patches during this period, but I feel that I could certainly do more. GSoC would, obviously, be a great chance to both get a deeper understanding of the internals of wine and to learn more about the Win32 API among other things. I've been looking a bit at the suggestions for suitable projects on the wiki, and at the moment I'm glancing a bit in particular at implementing support for performance registry keys. I have taken a somewhat cursory look around on msdn and dug around a bit in the code to try to get some feel for what it would entail, but I thought I'd hear if maybe someone has been working on this lately, or if there's anything else in particular that should be taken into consideration (except what's already noted in bug 5322). I've also looked a bit at implementing support for IFileDialog, and the Explorer, but I have yet to dig too deep into either of them. Are there currently any known applications out there that uses IFileDialog explicitly? I've looked a bit, probably not enough, but I haven't been able to find anything except example code. Also, are there any applications that fail to run because explorer is missing functionality, or would the end-result of that suggested project function mainly as an end-user utility? Thanks, David

3 2

Re: [PATCH 4/5] d3dx9_36: Implement D3DXFindShaderComment (based on code from Luis Busquets)
by Henri Verbeet 23 Feb '10

23 Feb '10

I think tests would be appropriate.

2 5

Re: [PATCH] shlwapi/tests: skip SHCreateStreamOnFileA/W configurations not supported on Win98 SE.
by Paul Vriens 23 Feb '10

23 Feb '10

On 02/23/2010 01:28 AM, Reece Dunn wrote: > + if (ret == E_INVALIDARG) /* Win98 SE */ { > + skip("Not supported\n"); > + return; > + } Hi Reece, Could you turn that (and the other one) into a win_skip() ? -- Cheers, Paul.

2 1