February 2010 - Wine-devel - list.winehq.org

Status of Patchwatcher
by Seth Shelnutt 15 Feb '10

15 Feb '10

Hey guys, I am wondering what that status of patchwatcher is? I haven't seen anything on it since August where Scott Richie said he and Luke were working on reviving it. I see the code is still on Dan's google page. I am looking to do a GSoC project on appinstall and patchwatcher. I saw the ideals for converting UnitTestSuit and wpkg scripts to Appinstall. I definitely think this is a good idea and needed; however I was thinking that linking patchwatcher and appinstall testing would be even more beneficial. That is assuming patchwatcher is still alive. Before I make any formal announcement of my intent I'm just trying to see how things stand now. Thanks, Seth Shelnutt

1 0

Patch 1 for EM_FORMATRANGE
by James McKenzie 15 Feb '10

15 Feb '10

All: I am working on the final version of the EM_FORMATRANGE patches. Thanks to Dylan Smith who has provided much feedback and corrections to these patches. James McKenzie

1 0

Re: shlwapi: URL_ParseUrl should not fail if there is not :\\
by Nikolay Sivov 15 Feb '10

15 Feb '10

On 2/15/2010 22:07, Aric Stewart wrote: > > allows acceptance of urls such as about:blank > --- > dlls/shlwapi/url.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) Could you add a small test for that?

2 1

Re: [PATCH 4/4] msctf: Implement stubbed out TF_CreateLangBarMgr [Try 2]
by Aric Stewart 15 Feb '10

15 Feb '10

Hi, I am really happy that you are helping with the msctf stuff I started. Very cool! 2 quick things. 1) typedef struct tagACLMulti, don't call it tagACLMulti. I am sure this is from copying from threadmgr.c where it is a copy/paste thing from when I started that framework. It has always bugged me (though not enough to submit a patch just to change it), but it would be nice not to see it propagated even more. 2) you add pITfLangBarMgr to the ActivatedTextService, but dont do anything with it. Does the Activated TextService need to have a reference to the ITfLangBarMgr? My quick read though does not seem to reveal that. When should it get set and initialized and where would it be used? thanks! -aric

2 1

Re: Current status of XI2 mouse stuff now that Lucid Lynx includes XI2?
by Roderick Colenbrander 15 Feb '10

15 Feb '10

On Mon, Feb 15, 2010 at 3:40 PM, Warren Dumortier <nwarrenfl(a)gmail.com> wrote: > As a simple user i have a question. > Will WIne include the patch once it exists and is accepted or will the > Wine team only include it once all major distros use the new Xorg? > I'm really looking forward XInput2 in Wine, but maybe both could be in > the Wine source, but enabling XInput 2 by a compiler flag or registry > key? > The presence of an X extension can be discovered at run-time, so when XInput2 isn't around we would fall back to the old code. Roderick

1 0

Re: [PATCH] shell32: replace strcpy by memcpy due to slightly undefined struct handling
by Paul Chitescu 15 Feb '10

15 Feb '10

> - strcpy(pData->u.network.szNames, "Entire Network"); > + memcpy(pData->u.network.szNames, "Entire Network", sizeof("Entire Network")+1); Please use a const buffer as "Entire Network" is a string literal, not something with a clearly defined size (not even talking about length). const char entireNetwork[] = "Entire Network"; ... memcpy(pData->u.network.szNames, entireNetwork, sizeof(entireNetwork)); The final NUL is part of the char array. Regardless, we may still copy some garbage after the NUL depending if/how the compiler pads the buffer. Probably a better way would be to simply cast (char*)pData->u.network.szNames since the length is not checked anyway. Regards, Paul

2 1

Current status of XI2 mouse stuff now that Lucid Lynx includes XI2?
by Dan Kegel 15 Feb '10

15 Feb '10

I recall that Paul Hampson did a first cut at using XI2, linked to from the bottom of http://wiki.winehq.org/DInput, and http://wiki.winehq.org/Bug6971 says "the new XInput2 X11 extension (which is part of XOrg 7.5) provides relative mouse motion events. Once this extension is more common, we will be able to fix Wine properly." Well, here it is, and XI2 is said to be included in Ubuntu Lucid Lynx Alpha 2; so it's about to get a lot more common. Has anybody tried it out lately? What's Paul's status? Incidentally, I just noticed a page about how somebody made the transition to XI2 on another project, see http://www.clearchain.com/blog/posts/xinput-1-xinput-2-conversion-guide - Dan

4 4

Re: [jscript]add korean translation
by James McKenzie 15 Feb '10

15 Feb '10

Hwangsee: This needs to be resubmitted in UTF format, not HTML as Piotr pointed out. Very good work otherwise. Also, thank you for using the formal version rather than the informal. James McKenize Hwang YunSong(황윤성) wrote: > --- a/dlls/jscript/Makefile.in 2010-02-12 10:23:39.603312863 +0900 > +++ b/dlls/jscript/Makefile.in 2010-02-10 09:58:16.684464491 +0900 > @@ -13,6 +13,7 @@ > jscript_Nl.rc \ > jscript_Pt.rc \ > jscript_Ru.rc \ > + jscript_Ko.rc \ > rsrc.rc > > C_SRCS = \ > --- /dev/null 2010-02-13 09:55:10.082328150 +0900 > +++ b/dlls/jscript/jscript_Ko.rc 2010-02-13 22:29:04.960003941 +0900 > @@ -0,0 +1,51 @@ > +/* > + * Copyright 2009 Piotr Caban > + * Copyright 2010 YunSong Hwang > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > 02110-1301, USA > + */ > + > +#include "resource.h" > + > +/* UTF-8 */ > +#pragma code_page(65001) > + > +LANGUAGE LANG_KOREAN, SUBLANG_DEFAULT > + > +STRINGTABLE DISCARDABLE > +{ > + IDS_TO_PRIMITIVE "객페를 기본 형식으로 변환하는 중에 에러 발생" > + IDS_INVALID_CALL_ARG "올바르지 않은 프로시져 호출이나 인수" > + IDS_CREATE_OBJ_ERROR "자동화 서버가 객체를 만들 수 없습니다" > + IDS_NO_PROPERTY "객체는 이 속성이나 메소드를 지원하지 않습니다" > + IDS_ARG_NOT_OPT "인수는 옵션이 아닙니다" > + IDS_SYNTAX_ERROR "문법 에러" > + IDS_SEMICOLON "';' 가 필요합니다" > + IDS_LBRACKET "'(' 가 필요합니다" > + IDS_RBRACKET "')' 가 필요합니다" > + IDS_UNTERMINATED_STR "띁나지 않은 문자열 상수" > + IDS_NOT_FUNC "함수가 필요합니다" > + IDS_NOT_DATE "'[객체]' 는 날짜 객체가 아닙니다" > + IDS_NOT_NUM "숫자가 필요합니다" > + IDS_OBJECT_EXPECTED "객체가 필요합니다" > + IDS_ILLEGAL_ASSIGN "잘못된 할당" > + IDS_UNDEFINED "'|' 는 정의되지 않았습니다" > + IDS_NOT_BOOL "볼린 객제가 필요합니다" > + IDS_JSCRIPT_EXPECTED "JScript 객체가 필요합니다" > + IDS_REGEXP_SYNTAX_ERROR "정규 표현식에 문법에러가 있습니다" > + IDS_URI_INVALID_CHAR "URI 는 올바르지 않은 문자를 포함해서 인코딩되 > 었습니다" > + IDS_INVALID_LENGTH "배열 길이는 반드시 한정된 양의 정수이어야 합니다" > + IDS_ARRAY_EXPECTED "배열 객체가 필요합니다" > +} > > <http://www.dreamwiz.com/> http://www.dreamwiz.com/ > > <http://dreamwiz.gmarket.co.kr/redirect2.dwz?http://www.gmarket.co.kr/challe…> > <http://banner.auction.co.kr/bn_redirect.asp?ID=BN00008749&lpurl=http://corn…> > > ------------------------------------------------------------------------ > > >

1 0

Re: [ddraw/tests] Fix a test failure on VMware and VirtualBox on W2K and below
by Henri Verbeet 15 Feb '10

15 Feb '10

On 15 February 2010 13:50, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > Henri agrees that this looks like it's broken on these platforms and thus > marked as such. I've used an explicit color value for the broken() > statement. > > Changelog > Fix a test failure on VMware and VirtualBox on W2K and below > The broken() is ok, but the comment is misleading. The failure happens because the reference rasterizer is used, not due to something specific to VirtualBox or VMware display drivers.

2 1

Re: [jscript]add korean translation
by Paul Vriens 15 Feb '10

15 Feb '10

On 02/15/2010 01:20 AM, Hwang YunSong(황윤성) wrote: > --- a/dlls/jscript/Makefile.in 2010-02-12 10:23:39.603312863 +0900 > +++ b/dlls/jscript/Makefile.in 2010-02-10 09:58:16.684464491 +0900 > @@ -13,6 +13,7 @@ > jscript_Nl.rc \ > jscript_Pt.rc \ > jscript_Ru.rc \ > + jscript_Ko.rc \ > rsrc.rc Please keep this list sorted. It's usually not an issue (if done correctly) to inline your patch but please not in HTML format. -- Cheers, Paul.

1 0