February 2010 - Wine-devel - list.winehq.org

Re: [PATCH 4/5] ddraw: Add depth clamp tests.
by Paul Vriens 15 Feb '10

15 Feb '10

On 01/26/2010 06:31 PM, Henri Verbeet wrote: > + color = getPixelColor(device, 150, 150); > + todo_wine ok(color_match(color, 0x00ffffff, 1), "color 0x%08x.\n", color); Hi Henri, This particular test fails on some VMware and VirtualBox boxes. We've been through this before about whether broken() is appropriate or not. The attached patch adds an explicit broken color value instead of some color_match(). Not sure what's the best way though. We don't have many test runs on real Windows for these new tests so I can't be a 100% sure if it's just VMware/VirtualBox. Some real boxes have run the ddraw:visual tests but not these new ones as they bailed out because of other issues. Any thoughts on this one? -- Cheers, Paul.

2 1

recent winmm/midimap tests
by Saulius Krasuckas 14 Feb '10

14 Feb '10

Hi folks is it only me getting short midi-like sounds during non-interactive run of Winetest, or is this known new bug already? S.

2 1

Re: oldconfig.c: produce DEVICEMAP//SERIALCOMM entries
by Alexandre Julliard 14 Feb '10

14 Feb '10

A C Hurst <A.Hurst(a)sheffield.ac.uk> writes: > Fixes bug 11811 [http://bugs.winehq.org/show_bug.cgi?id=11811] and its duplicates. > This patch sent some time back (over a year) was ignored/lost in noise. > Could someone review please? It has already been explained that this belongs in mountmgr, and should be based on the actual devices as reported by HAL. It should also create the corresponding NT devices and symlinks. -- Alexandre Julliard julliard(a)winehq.org

3 2

Wine HQ Down?
by James McKenzie 14 Feb '10

14 Feb '10

Greetings: Cannot connect to www.winehq.org this morning. Scheduled downtime or did the site drop again? James McKenzie

1 0

Game engines and wine
by Dan Kegel 14 Feb '10

14 Feb '10

The use of game engines has increased quite a bit over the last couple years; there are now something like 250 that support Windows. (And maybe five to ten that are important commercially.) It's tempting to consider focusing some effort on supporting a few of them better in Wine, on the theory that then games built with those engines would stand a better chance of running on Wine. The two main commercial ones with freely downloadable SDKs that I know about are Unity3D ( http://appdb.winehq.org/objectManager.php?sClass=version&iId=19268 ) and Unreal ( Unreal's UDK requires .net 3.5, so it can't be installed at the moment ). Looks like Unity3D is close to working, according to the appdb. I'm afraid to guess how long it'll be before we can even install Unreal's UDK... I've written up a few notes and links on the subject at http://wiki.winehq.org/GameEngines - Dan

2 2

Re: cmd: Add test for %~dp0 expansion (bug 21382)
by Alexandre Julliard 13 Feb '10

13 Feb '10

Dan Kegel <dank(a)kegel.com> writes: > --- /dev/null > +++ b/programs/cmd/tests/test_dp0.cmd > @@ -0,0 +1,10 @@ > +(a)echo off > +echo Begin test for bug 21382 > +rem On old wine, ~dp0 was always current directory rather than "directory containing batch file" > +echo %~dp0 > +mkdir dummydir > +cd dummydir > +echo %~dp0 > +cd .. > +rmdir dummydir > +echo End test for bug 21382 > diff --git a/programs/cmd/tests/test_dp0.cmd.out b/programs/cmd/tests/test_dp0.cmd.out > new file mode 100644 > index 0000000..8c38153 > --- /dev/null > +++ b/programs/cmd/tests/test_dp0.cmd.out > @@ -0,0 +1,4 @@ > +Begin test for bug 21382 > +(a)pwd@\ > +(a)pwd@\ > +End test for bug 21382 Please don't create new files for every small test, this will become unmanageable very quickly. Unless there are reasons to split them, everything should go in a single .cmd file. Also don't use bug numbers, add some meaningful message instead. The code must be understandable without reference to bugzilla. -- Alexandre Julliard julliard(a)winehq.org

3 5

valgrind warnings in new d3d10/effect tests
by Dan Kegel 13 Feb '10

13 Feb '10

Hi Rico, please have a look at the two new warnings in http://kegel.com/wine/valgrind/logs/2010-02-12-20.25/diff-d3d10_effect.txt http://kegel.com/wine/valgrind/logs/2010-02-12-20.25/vg-d3d10_effect.txt Invalid free() / delete / delete[] at notify_free (heap.c:262) by RtlFreeHeap (heap.c:1746) by d3d10_effect_Release (effect.c:1954) by test_effect_local_shader (effect.c:3441) by func_effect (effect.c:3462) by run_test (test.h:535) by main (test.h:585) Address 0x7f000c4c is 60 bytes inside a block of size 768 alloc'd at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1700) by parse_fx10_body (effect.c:1576) by parse_fx10 (effect.c:1691) by fx10_chunk_handler (effect.c:1705) by parse_dxbc (effect.c:195) by d3d10_effect_parse (effect.c:1715) by D3D10CreateEffectFromMemory (d3d10_main.c:230) by create_effect (effect.c:55) by test_effect_local_shader (effect.c:2660) by func_effect (effect.c:3462) by run_test (test.h:535) by main (test.h:585) 80 bytes in 6 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1700) by copy_name (effect.c:214) by parse_fx10_anonymous_shader (effect.c:874) by parse_fx10_object (effect.c:995) by parse_fx10_pass (effect.c:1087) by parse_fx10_technique (effect.c:1148) by parse_fx10_body (effect.c:1620) by parse_fx10 (effect.c:1691) by fx10_chunk_handler (effect.c:1705) by parse_dxbc (effect.c:195) by d3d10_effect_parse (effect.c:1715) by D3D10CreateEffectFromMemory (d3d10_main.c:230) by create_effect (effect.c:55) by test_effect_local_shader (effect.c:2660) by func_effect (effect.c:3462) by run_test (test.h:535) by main (test.h:585) probably from commit f816210c214318b0beba5ed6b90c6cd32dd3fd96 Author: Rico Schüller <kgbricola(a)web.de> Date: Thu Feb 11 19:49:24 2010 +0100 d3d10/tests: Add effect shader test. - Dan

1 0

Re: msxml4: Added support for SAXXMLReader40
by Nikolay Sivov 13 Feb '10

13 Feb '10

On 2/13/2010 15:01, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml4: Added support for SAXXMLReader40 > > Best Regards > Alistair Leslie-Hughes Hi, Alistair. You missed a registration part for in msxml4.

1 0

Re: shell32[1/2]: implements shell link's GetCurFile (with tests, fixes bug #21297) [try3]
by Paul Vriens 13 Feb '10

13 Feb '10

On 02/13/2010 11:49 AM, Mikołaj Zalewski wrote: > +#define expect_eq_ws(expected, actual) \ > + do { \ > + LPCWSTR value = (actual); \ > + ok(lstrcmpW((expected), value) == 0, "Expected " #actual " to be %s (" #expected ") is %s\n", \ > + wine_dbgstr_w(expected), wine_dbgstr_w(value)); \ > + } while (0) Hi Mikołaj, lstrcmpW is not implemented on Win9x/WinMe and will always return 0. -- Cheers, Paul.

1 0

Re: Re[2]: [PATCH] shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile (resend)
by James Mckenzie 12 Feb '10

12 Feb '10

Ilya Basin <basinilya(a)gmail.com> wrote at Feb 12, 2010 4:39 AM about Re[2]: [PATCH] shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile (resend) > >Thanks for review. Not sending to wine-patches this time. New patch is >in the bottom. What's better, to attach a generated patch or to use it >as a message body? > Generated patch, if at all possible. That way we can use git apply to install. James McKenzie

1 0