February 2010 - Wine-devel - list.winehq.org

Re: Adding wikipedia links to appdb?
by David Gerard 11 Feb '10

11 Feb '10

[to list as well, *cough*] On 11 February 2010 11:35, Rosanne DiMesio <dimesio(a)earthlink.net> wrote: > On Wed, 10 Feb 2010 21:38:56 -0800 > Dan Kegel <dank(a)kegel.com> wrote: >> I often want to learn more about an app while >> I'm in the appdb, and particularly, I want to know >> whether it has a good reputation. Wikipedia >> can often tell me what I need to know. It >> might be handy to have a wikipedia url field >> in the appdb, and an option in Browse Apps >> that says "only show apps with wikipedia links". >> What do folks think about the idea? > I think the AppDB is for information about how well an app works in Wine, not the merits of the app itself. Having an entry in Wikipedia has more to do with Wikipedia's notions of "notability" than any actual merits of the app. A quite horrible app could have a Wikipedia entry if its horribleness is famous enough ;-) However, a Wikipedia link field may be a useful thing to have. - d.

1 0

Re: dsound/tests: DirectSound3DListener_QueryInterface should accept IKsPropertySet
by Joerg-Cyril.Hoehle＠t-systems.com 11 Feb '10

11 Feb '10

Hi, I don't know how others feel about this pattern: + ok(rc==DS_OK && temp_buffer!=NULL, ... + if(temp_buffer) IKsPropertySet_Release(temp_buffer); I'd rather code like this if (rc==DS_OK && temp_buffer) Release(). The reason is that the typical invariant is "Any output variable is correctly set if and only if the called function indicated success on return". And the corollar: If it failed, output variables may generally be filled with garbage. Similarly, access errno only after an I/O function returned failure. I do not dispute that it is good style for the callee to only set output variables when returning success. But that is a requirement hard to maintain in SW and often violated. E.g. there's a lot of code like: ... if (some) return ERROR; *outparam1= xyz; ... if (more) return ERROR; ... *outparam2= abc; ... return SUCCESS; See how p1 may contain garbage? Regards, Jörg Höhle

1 0

mountmgr removable media woes
by louis＠museresearch.com 10 Feb '10

10 Feb '10

Hi all, I'm troubleshooting some removable media mounting issues with WINE 1.1.7. It seems that when using an auto-mounting program such as gnome-volume-manager or thunar-volman that WINE's mountmgr misses a HAL notification. This happens when WINE is already running and a new disk is inserted. I am mostly testing it with a flash reader, but I saw that it happens with optical media too. What appears to be happening is this: HAL first sends out that a new device is available with a null mount point. The volume manager picks that up, mounts the partition, and then tells HAL. HAL then sends out a property_modified message with the new mount point. Mountmgr gets the first notification, tries to register a watch in time, but is usually too slow and misses the mount point changed notice. I tried moving the watch registration to the top of the new_device function (it is currently at the bottom), which caused only certain apps to work such as winefile, but not notepad (winefile did not seem to be doing anything special other than responding to a new device with a slow redraw). Gnome-volume-manager and thunar-volman both watch all HAL devices from the start. I notice that doing this in mountmgr causes it to work. Is there a reason I should not do this? Cheers, Louis

1 0

Re: Some new Spanish translations
by Nikolay Sivov 10 Feb '10

10 Feb '10

On 2/10/2010 20:28, José Manuel Ferrer Ortiz wrote: > Hello all. Here you are a few newly translated Spanish resource files, > for hhctrl, iccvid, localspl and mapi32 dlls. > > Regards, > José Manuel Hi, Jose. Use UTF-8 encoding with corresponding pragma directive. > +#include "localspl_private.h" > + > +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT > + > +STRINGTABLE DISCARDABLE > +{ > + IDS_LOCALPORT "Puerto local" > + IDS_LOCALMONITOR "Monitor local" > +} > You forgot to change ID here. Also split this to several patches, one per module.

1 0

Wine FIXME Report January 2010
by Michael Stefaniuc 10 Feb '10

10 Feb '10

Wine FIXME Report January 2010 ============================== The data for this report comprise the emails from January 2010 archives of the mailing lists wine-{bugs,devel,users} as well as the bugzilla attachments referenced by the wine-bugs emails. Although WARN messages were collected too they aren't handled in this report. File parsed: 6364 (emails: 5850, bugzilla attachments: 514) Files with FIXME/ERR/WARN: 436 Type | Total | Unique ------+---------+------- fixme | 1354429 | 8122 err | 24115 | 993 warn | 3491 | 404 The Most Popular Messages ------------------------- This are the most prevalent ERR and FIXME messages aka the number of files where they show up. FIXME: Files | Lines | Channel:Function Text ------+-------+---------------------- 59 | 119 | d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface 42 | 45 | system:SetProcessDPIAware stub! 36 | 46 | iphlpapi:GetAdaptersAddresses no support for IPv6 addresses 33 | 61 | mixer:ALSA_MixerInit No master control found on HDA ATI HDMI, disabling mixer 29 | 57 | urlmon:URLMoniker_BindToObject use running object table 22 | 41 | shdocvw:BindStatusCallback_OnProgress status code 11 19 | 21 | system:SystemParametersInfoW Unimplemented action: 59 (SPI_SETSTICKYKEYS) 18 | 21 | resource:GetGuiResources (0xffffffff,0): stub 18 | 37 | shdocvw:PropertyNotifySink_OnChanged unimplemented dispid 1005 17 | 71 | storage:StgCreateDocfile Storage share mode not implemented. ERR: Files | Lines | Channel:Function Text ------+-------+---------------------- 22 | 41 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element 18 | 25 | ole:CoGetClassObject class {9a5ea990-3034-4d6f-9128-01f3c61022bc} not registered 18 | 26 | ole:CoGetClassObject no class object {9a5ea990-3034-4d6f-9128-01f3c61022bc} could be created for context 0x1 15 | 1646 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 14 | 1645 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 12 | 44 | ole:CoGetClassObject class {6c736db1-bd94-11d0-8a23-00aa00b58e10} not registered 12 | 44 | ole:CoGetClassObject no class object {6c736db1-bd94-11d0-8a23-00aa00b58e10} could be created for context 0x1 12 | 114 | ole:apartment_getclassobject DllGetClassObject returned error 0x80040111 10 | 18 | rpc:I_RpcGetBuffer no binding 9 | 12 | ole:CoGetClassObject class {77f10cf0-3db5-4966-b520-b7c54fd35ed6} not registered Noisy Popular Messages ---------------------- The noisiest messages that show up at least in 1% of the collected reports. FIXME: Lines | Files | Channel:Function Text ------+-------+---------------------- 223 | 7 | mshtml:nsChannel_GetSecurityInfo default action not implemented 155 | 11 | ole:CoGetClassObject CLSCTX_REMOTE_SERVER not supported 144 | 12 | wininet:InternetLockRequestFile STUB 119 | 59 | d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface 110 | 9 | advapi:LsaClose (0xcafe) stub 99 | 8 | font:WineEngAddFontResourceEx Ignoring flags 10 92 | 5 | wininet:GetUrlCacheEntryInfoExW Undocumented flag(s): 100 75 | 7 | file:MoveFileWithProgressW MOVEFILE_WRITE_THROUGH unimplemented 71 | 17 | storage:StgCreateDocfile Storage share mode not implemented. 61 | 33 | mixer:ALSA_MixerInit No master control found on HDA ATI HDMI, disabling mixer ERR: Lines | Files | Channel:Function Text ------+-------+---------------------- 1646 | 15 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 1645 | 14 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 114 | 12 | ole:apartment_getclassobject DllGetClassObject returned error 0x80040111 113 | 6 | ole:ClientIdentity_QueryMultipleInterfaces IRemUnknown_RemQueryInterface failed with error 0x80004002 66 | 7 | ole:ITypeInfo_fnInvoke did not find member id -504, flags 0x2! 66 | 7 | ole:ITypeInfo_fnInvoke did not find member id -514, flags 0x2! 62 | 6 | shell:SHGetFileInfoW pidl is null! 44 | 12 | ole:CoGetClassObject class {6c736db1-bd94-11d0-8a23-00aa00b58e10} not registered 44 | 12 | ole:CoGetClassObject no class object {6c736db1-bd94-11d0-8a23-00aa00b58e10} could be created for context 0x1 41 | 22 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element Noisy Popular Functions ----------------------- The noisiest functions that show up at least in 1% of the collected reports. FIXME: Lines | Files | Channel:Function ------+-------+----------------- 434041 | 716 | ole:NdrCorrelationInitialize 434009 | 716 | ole:NdrCorrelationFree 7620 | 6 | d3d:context_check_fbo_status 2716 | 100 | d3d_surface:IWineD3DVolumeImpl_LockBox 2052 | 8 | d3d_surface:IWineD3DBaseSurfaceImpl_Blt 1531 | 156 | d3d:IWineD3DOcclusionQueryImpl_GetData 738 | 78 | d3d_surface:IWineD3DSurfaceImpl_LoadLocation 653 | 497 | shdocvw:ClOleCommandTarget_Exec 466 | 84 | dsound:IDirectSoundBufferImpl_AcquireResources 418 | 197 | mshtml:nsChannel_GetSecurityInfo ERR: Lines | Files | Channel:Function ------+-------+----------------- 16107 | 37 | ole:ITypeInfo_fnInvoke 3291 | 29 | ddraw:PixelFormat_WineD3DtoDD 872 | 201 | ole:CoGetClassObject 180 | 27 | x11settings:X11DRV_ChangeDisplaySettingsEx 174 | 26 | ole:create_server 121 | 16 | ole:apartment_getclassobject 113 | 6 | ole:ClientIdentity_QueryMultipleInterfaces 113 | 6 | ole:marshal_object 69 | 63 | eventlog:ReportEventW 62 | 6 | shell:SHGetFileInfoW The Top Ten Single Charts ------------------------- This are the messages with the most occurrences in a single file. FIXME: Lines | Files | Channel:Function Text ------+-------+---------------------- 433829 | 4 | rpc:NdrStubCall2 new correlation description not implemented 61256 | 1 | ole:NdrCorrelationFree (0x33df38): stub 61224 | 1 | ole:NdrCorrelationInitialize (0x33df38, 0x33db38, 1024, 0x0): stub 60612 | 1 | ole:NdrCorrelationInitialize (0x33d414, 0x33d014, 1024, 0x0): stub 60611 | 1 | ole:NdrCorrelationFree (0x33d414): stub 50370 | 1 | ole:NdrCorrelationInitialize (0x33d694, 0x33d294, 1024, 0x0): stub 50364 | 1 | ole:NdrCorrelationFree (0x33d694): stub 29000 | 1 | ole:NdrCorrelationInitialize (0x33d764, 0x33d364, 1024, 0x0): stub 28994 | 1 | ole:NdrCorrelationFree (0x33d764): stub 17768 | 1 | ole:NdrCorrelationInitialize (0x33d6ec, 0x33d2ec, 1024, 0x0): stub ERR: Lines | Files | Channel:Function Text ------+-------+---------------------- 13032 | 1 | ole:ITypeInfo_fnInvoke did not find member id 512, flags 0x4! 1728 | 1 | ole:ITypeInfo_fnInvoke failed to convert param 0 to VT_I4 from VT_BSTR 864 | 1 | ole:ITypeInfo_fnInvoke failed to convert param 0 to VT_BOOL from VT_BSTR 837 | 15 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 837 | 14 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 756 | 1 | d3d_surface:IWineD3DBaseSurfaceImpl_CreateDIBSection CreateDIBSection failed! 331 | 1 | d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R32G32B32A32_FLOAT 331 | 1 | d3d:getColorBits Unsupported format: WINED3DFMT_R32G32B32A32_FLOAT 288 | 1 | ole:ITypeInfo_fnInvoke did not find member id 854, flags 0x4! 198 | 3 | d3d:state_undefined Undefined state. Further Info: ------------- The sqlite3 database and the SQL commands to output the above info can be downloaded from http://people.redhat.com/mstefani/winefixme/reports/201001/ bye michael

4 9

Re: wined3d: Add surface conversion function from WINED3DFMT_YUY2 to WINED3DFMT_B8G8R8X8_UNORM
by Stefan Dösinger 10 Feb '10

10 Feb '10

Am 09.02.2010 um 18:11 schrieb Sandijs Ribaks: > This is a patch for http://bugs.winehq.org/show_bug.cgi?id=21629 . It seems ok in concept, just a few points: > +static void convert_yuy2_x8r8g8b8(const BYTE *src, BYTE *dst, > + DWORD pitch_in, DWORD pitch_out, unsigned int w, unsigned int h) > ... > + const BYTE *src_line = (const BYTE *)(src + y * pitch_in); The cast here is redundant > + if (!(x & 1)) { /* for every even pixel, read new U and V */ The placement of the { is inconsistent with the rest of the patch. > + dst_line[x] = 0xff000000 > + | cliptobyte((c2 + r2) >> 8) << 16 /* red */ > + | cliptobyte((c2 + g2) >> 8) << 8 /* green */ > + | cliptobyte((c2 + b2) >> 8); /* blue */ I recommend to add a comment explaining that (x >> 8) << 8 is not redundant but in used to mask out lower bits. Just to make sure I understand this correctly: > + r2 = 409 * e + 128; > + g2 = - 100 * d - 208 * e + 128; > + b2 = 516 * d + 128; The +128 here is for proper rounding in the right shift step afterwards?

1 0

Understanding 64bit implications and wine64
by Joerg-Cyril.Hoehle＠t-systems.com 10 Feb '10

10 Feb '10

Hi, I've trouble understanding some of the 64bit issues. Lacking a 64bit machine, I'm left asking questions ;-) My understanding is that wine64 is the effort to make Wine work on 64bit UNIX systems, i.e. pointer size = 64bit, isn't it? DWORD_PTR is 64 bit wide on a wine64 system, 32 bit otherwise, correct? A priori, this has nothing to do with MS-Windows' LARGE_ADDRESS_SPACE_AWARE(sp?) API, which I believe allows 32bit apps to nevertheless make use of more than 1,5/2/4GBof RAM, isn't it? The wine64 challenge seems to let 32bit MS-windows apps work even though the UNIX side has to manage pointer addresses >2^32, i.e. above the lower 4GB address range. Is there some address translation involved or only mmap'ing? What must the Wine developer know to write correct code for wine64? For instance, I fail to understand Erich Pouech's recent commit 5cab72bc95ec2d864e19952fff2df99610ba7537 winmm: For MCI parsing, use 64bit compatible variables. If you look closely at the definitions of MCI_xyz_PARMS in MMSYSTEM.H, you'll notice that (at least on 32bit systems), despite the different types (DWORD, LPSTR, UINT) these structures are originally an array of 32bit values. This regular structure is essential, because the MCI command parser has very limited means to know about different sizes. All it knows is MCI_INTEGER, MCI_STRING, MCI_CONSTANT. An app that sends an MCI_xyz command sends a pointer to such an array, decorated as MCI_xyz_PARMSA/W for nicer access. Alternatively, when using mciSendString, the MCI parser builds this array of DWORD elements, then calls the MCI command. In recent Wine, this has become an array of DWORD_PTR instead. wine-tests may work because Wine is cnosistent with itself, but How can this possibly work without breaking binary compatibility? Thanks for your help, Jörg Höhle

8 7

Re: msxml4: Prefer to use the native version
by Nikolay Sivov 09 Feb '10

09 Feb '10

On 2/9/2010 11:50, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml4: Prefer to use the native version > > Best Regards > Alistair Leslie-Hughes Why do you need this?

2 3

Re: ws2_32: warn the user if broadcasts are failing because of a missing route to 255.255.255.255
by Austin English 09 Feb '10

09 Feb '10

On Mon, Feb 8, 2010 at 2:07 PM, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Changelog: > * ws2_32: warn the user if broadcasts are failing because of a missing > route to 255.255.255.255 diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 9a65cb0..ac55e50 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -1430,7 +1431,13 @@ static int WS2_send( int fd, struct ws2_async *wsa ) hdr.msg_flags = 0; #endif - return sendmsg(fd, &hdr, wsa->flags); + ret = sendmsg(fd, &hdr, wsa->flags); + if (ret < 0 && errno == ENETUNREACH && wsa->addr && wsa->addr->sa_family == AF_INET && + ((struct WS_sockaddr_in*)wsa->addr)->sin_addr.WS_s_addr == 0xFFFFFFFF) + { + FIXME("broadcast failed, you need to add a route to 255.255.255.255\n"); That doesn't look like a WARN() to me. Anyway, it seems an ERR() would be more appropriate. -- -Austin

2 1

Re: cmd: Added cmd.exe tests. [try2]
by Alexandre Julliard 09 Feb '10

09 Feb '10

Jacek Caban <jacek(a)codeweavers.com> writes: > In previous version CRs were lost in their way to wine-patches. Also > this version has a few improvements made together with Dan that should > help writing tests, mostly no need to care about CRs (they are > skipped) and better failure messages. It doesn't work here: ../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p cmd.exe_test.exe.so batch.c && touch batch.ok batch.c:162: Test failed: too long output make: *** [batch.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1