February 2010 - Wine-devel - list.winehq.org

Re: [PATCH] shlwapi: Improve error handling in UrlGetPart
by Alexandre Julliard 08 Feb '10

08 Feb '10

Andrew Eikum <aeikum(a)codeweavers.com> writes: > --- > dlls/shlwapi/tests/url.c | 25 ++++++++++++++++++--- > dlls/shlwapi/url.c | 52 > +++++++++++++++++++++++++++++++++++---------- > 2 files changed, 61 insertions(+), 16 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so misc.c && touch misc.ok misc.c:348: Test failed: [1] domain failed: 00000000 make: *** [misc.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] user32: make wineserver calls to get and set window droptargets [try 2]
by Alexandre Julliard 08 Feb '10

08 Feb '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * user32: make wineserver calls to get and set window droptargets > > Get and set the window drop targets from user32.dll, and not ole32.dll > like in try 1. That's not much better, you are still having ole32 do server calls, only hidden behind a Wine-specific export. You should be able to do this with only standard user32 APIs, or you need to make a very convincing case that it's impossible without private exports. -- Alexandre Julliard julliard(a)winehq.org

2 2

Status of USB patches?
by Scott Ritchie 08 Feb '10

08 Feb '10

I wanted to experiment with these, but I'm not sure of their current state. Do they still apply cleanly? Are they on track for eventual inclusion? I'm willing to help provide community testing by putting them in a special package repository. Thanks, Scott Ritchie

3 4

Getting start with IXMLHTTPRequest
by Nikolay Sivov 08 Feb '10

08 Feb '10

Hi. Recently I tried to start with this interface. It looks trivial enough but since it's first time i'm using winhttp, there could be some problems, especially cause IXMLHTTPRequest supports asynchronous requests. Could someone with winhttp knowledge review this patch before it goes to far from reality? P.S. any comments are welcome actually.

3 9

Re: winhlp32: Improve Tab view [try 3]
by Nikolay Sivov 08 Feb '10

08 Feb '10

On 2/8/2010 16:59, Vladimir Pankratov wrote: > Hello all. > > changes since try 2: > removed files without IDD_INDEX dialog > + WCHAR wszText[255]; > Isn't it possible to use some defined name here? MAX_PATH probably.

1 0

Re: [PATCH 2/5] qedit: Add pins, IMemInputPin implementation and grabbing to SampleGrabber (try 4)
by Nikolay Sivov 08 Feb '10

08 Feb '10

On 2/5/2010 17:54, Paul Chitescu wrote: > Changelog: > qedit: Add pins, IMemInputPin implementation and grabbing to SampleGrabber > > This time I checked it applies. Sorry. > --- +/* Sample Grabber pin implementation */ +typedef struct _SG_Pin { + IPin pin; This should be const IPinVtbl. + PIN_DIRECTION dir; + WCHAR const *name; + struct _SG_Impl *sg; + IPin *pair; If it's a list why not SG_Pin* here? +} SG_Pin; --- Also I don't see why such helpers are needed: --- static ULONG SampleGrabber_addref(SG_Impl *This) --- Why not use common Ixxxx_AddRef() on grabber anywhere you need it?

2 1

Re: winhlp32: Improve Index tab
by Michael Stefaniuc 08 Feb '10

08 Feb '10

Hello Vladimir, Vladimir Pankratov wrote: > Improved Index tab view please do not add the IDD_INDEX dialog to the languages that don't have it as the fallback to English happens automatically. That way it is easier to detect that something needs to be translated. Only the languages that already have the IDD_INDEX dialog need to be modified to prevent display errors. thanks bye michael

1 0

Re: [PATCH] user32/tests: make the MDI client take up the whole client area
by Dmitry Timoshkov 08 Feb '10

08 Feb '10

Reece Dunn <msclrhd(a)googlemail.com> wrote: > The MDI tests in user32/tests/msg.c were using an MDI client of zero > size (0,0 - 0,0). This means that the tests are not realistic for > real-world applications that use MDI, as their frame windows size the > client window to fit the frame's client area. It would be better IMO to create MDI client with the correct size at the first place instead of resizing it later. That would prevent any confusion, and perhaps even more problems once somebody adds tests before the MoveWindow() call. -- Dmitry.

2 1

Re: iphlpapi: _res is per-thread in glibc with pthreads
by John Klehm 08 Feb '10

08 Feb '10

On Mon, Feb 8, 2010 at 12:01 AM, Dan Kegel <dank(a)kegel.com> wrote: > With test. Without the fix, the test case crashes on my machine. > Fixes crash in bug http://bugs.winehq.org/show_bug.cgi?id=21624 > > Same fix probably needed in dnsapi, or maybe iphlpapi should > use dnsapi rather than unix dns api. > > Thanks to AF for the analysis. > testWin98OnlyFunctions(); testWinNT4Functions(); - testWin98Functions(); + thread = CreateThread(NULL, 0, testWin98Functions, NULL, 0, &threadId); + testWin98Functions(NULL); + WaitForSingleObject( thread, INFINITE ); Is that extra non threaded testWin98Functions(NULL) supposed to be in there? Regards, --John Klehm

1 0

idea: display drivers
by C.W. Betts 08 Feb '10

08 Feb '10

An idea that popped into my head when I was thinking about a Quartz (OS X) driver that perhaps there could be separate drivers for Quartz (OS X) and X11. Such drivers would include OpenGL and DirectX "Drivers".

9 16