February 2010 - Wine-devel - list.winehq.org

Re: [PATCH] msxml3/tests: Fix the domdoc IObjectSafety tests for msxml3 SP8+. [try 2]
by Paul Vriens 28 Feb '10

28 Feb '10

On 02/26/2010 11:07 PM, Reece Dunn wrote: > + todo_wine > + ok(broken(supported == (INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA)) || > + supported == (INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA | INTERFACE_USES_SECURITY_MANAGER) /* msxml3 SP8+ */, > + "Expected (INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA) " > + "or (INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA | INTERFACE_USES_SECURITY_MANAGER), " Hi Reece, We usually don't add the broken() possibility as one of the expected outcomes in the ok-message. -- Cheers, Paul.

2 1

Re: richedit: Make zooming affect all pictures.
by James McKenzie 28 Feb '10

28 Feb '10

Dylan Smith wrote: > Before pictures that had an ole object size were not zoomed. Native > riched20 applies the zoom ratio to these images, so this patch adds this > consistency. > --- > dlls/riched20/richole.c | 65 ++++++++++++++++++++++------------------------ > 1 files changed, 31 insertions(+), 34 deletions(-) > > ------------------------------------------------------------------------ > > This patch does not apply either. 0002-richedit-Make-zooming-affect-all-pictures.patch:9: trailing whitespace. if (c->editor->nZoomNumerator != 0) 0002-richedit-Make-zooming-affect-all-pictures.patch:10: trailing whitespace. { 0002-richedit-Make-zooming-affect-all-pictures.patch:11: trailing whitespace. pSize->cx = MulDiv(pSize->cx, c->editor->nZoomNumerator, c->editor->nZoomDenominator); 0002-richedit-Make-zooming-affect-all-pictures.patch:12: trailing whitespace. pSize->cy = MulDiv(pSize->cy, c->editor->nZoomNumerator, c->editor->nZoomDenominator); 0002-richedit-Make-zooming-affect-all-pictures.patch:13: trailing whitespace. } error: patch failed: dlls/riched20/richole.c:1729 error: dlls/riched20/richole.c: patch does not apply James McKenzie

1 0

Re: [Cygwin] Add dll name extraction from WINE_SONAME
by John Klehm 28 Feb '10

28 Feb '10

On Sat, Feb 27, 2010 at 1:50 PM, Alex <cerebro.alexiel(a)gmail.com> wrote: > I know I sent a patch some hours ago but in fact it didn't work. > I trusted myself because running ./configure script on cygwin on VirtualBox takes ~30 minutes. > > Whatever, this new patch is a bit simpler (.exe instead of $ac_exeext) and works perfectly. > > I'm waiting for comments. > You need to give your real name in addition to the patch. --John Klehm

1 0

Re: [PATCH] msxml3/tests: Fix the domdoc IObjectSafety tests for msxml3 SP8+.
by Nikolay Sivov 26 Feb '10

26 Feb '10

On 2/26/2010 23:20, Reece Dunn wrote: > Hi, > > As the following table shows, the msxml3 behaviour for IObjectSafety > changed from SP7 (8.70.*) to SP8 (8.80.*): > > fail? Windows MSXML MSXML Service Pack > ========================================================== > NO Win2003 SP1 8.70.1104.0 3.0 SP7 > YES Win2003 SP2 8.80.1185.0 3.0 Post SP8 > NO WinXP SP2 8.50.2162.0 3.0 SP5 > YES WinXP SP3 8.100.1048.0 3.0 SP10 > YES WinXP + IE8 8.100.1048.0 3.0 SP10 > > This patch fixes the tests on these failing platforms. > Please change our implementation too to SP8 behavior, and mark other one broken(). > - Reece >

2 1

Re: [PATCH 1/5] wined3d: refactoring and add Mesa AMD/ATI driver support
by James Mckenzie 26 Feb '10

26 Feb '10

Paul-Andre Panon <ppanon(a)shaw.ca> wrote: >Sent: Feb 25, 2010 10:37 PM Is there any difference between the two sets of files? If so, you should mark the second set as [Try 2] If this was just a resend then it should be marked [resend] Thank you. James McKenzie

1 0

Re: advapi32/tests: Test for last error after RegQueryValueEx
by Alexandre Julliard 26 Feb '10

26 Feb '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -626,15 +627,22 @@ static void test_query_value_ex(void) > trace("test_query_value_ex: type set to: 0x%08x\n", type); > ok(size == 0, "size should have been set to 0 instead of %d\n", size); > } > + todo_wine ok(GetLastError() == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", GetLastError()); > > size = sizeof(buffer); > + /* this last error check could be removed after setting it properly is fixed, > + it's to prevent regressions from current state */ > + SetLastError(ERROR_SUCCESS); > ret = RegQueryValueExA(HKEY_CLASSES_ROOT, "Nonexistent Value", NULL, &type, buffer, &size); > ok(ret == ERROR_FILE_NOT_FOUND, "expected ERROR_FILE_NOT_FOUND, got %d\n", ret); > ok(size == sizeof(buffer), "size shouldn't have been changed to %d\n", size); > + ok(GetLastError() == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", GetLastError()); This is confusing. You should set it to 0xdeadbeef before each call for the check to be meaningful. -- Alexandre Julliard julliard(a)winehq.org

2 5

Re: msi: Remove empty directories as part of the RemoveFiles action.
by Paul Vriens 26 Feb '10

26 Feb '10

On 02/26/2010 01:38 PM, Hans Leidekker wrote: > + '`','C','e','a','t','e','F','o','l','d','e','r','`',0}; Doesn't that one miss an 'r' ? -- Cheers, Paul.

1 0

Re: [PATCH] msxml3\tests: Fix the domdoc IObjectSafety tests for IE7+.
by Paul Vriens 26 Feb '10

26 Feb '10

On 02/26/2010 10:19 AM, Reece Dunn wrote: > Hi, > > This fixes the test failures in msxml3:domdoc when IE7 or later is installed. > > - Reece > Hi Reece, It's definitely not IE7+ only. All W2K3 boxes for the latest winetest: http://test.winehq.org/data/062628ad8020e09063fcdf6302e86f17321e2ea8/index_… have IE6 installed and only some fail. The change seems to be as of XP-SP3+, W2K3-SP2+ and Vista/W2K8/Win7. An interesting thing is to find out why, although that would not be part of this patch. Nikolay and I have been discussing this the last week and we both didn't figure out the implementation logic (yet). -- Cheers, Paul.

2 3

Re: [PATCH] Implement IPersistStream
by Nikolay Sivov 26 Feb '10

26 Feb '10

On 2/26/2010 13:35, denver stalk wrote: > > --- > > dlls/msxml3/domdoc.c | 193 > ++++++++++++++++++++++++++++++++++++++++++- > > dlls/msxml3/msxml_private.h | 2 + > > dlls/msxml3/xmldoc.c | 9 +- > > 3 files changed, 199 insertions(+), 5 deletions(-) > It's http://source.winehq.org/git/wine.git/?a=commit;h=7ec06c84 . Patch spam?

1 0

Re: [PATCH 4/5] wined3d: refactoring and add Mesa AMD/ATI driver support
by Henri Verbeet 26 Feb '10

26 Feb '10

On 26 February 2010 06:39, Paul-Andre Panon <ppanon(a)shaw.ca> wrote: > > +enum wined3d_pci_device (select_card_nvidia_binary)(const struct wined3d_gl_info *gl_info, const char *gl_renderer, > + unsigned int *vidmem ) > +{ > /* Both the GeforceFX, 6xxx and 7xxx series support D3D9. The last two types have more I'm not sure why you have the braces around the function name, but they should be superfluous. I guess you kept the indentation like that to reduce the size of the diff, but I think it's better to just change it. > + continue; You have some stray tabs here. > + /* Default to generic Nvidia hardware based on the supported OpenGL extensions. The choice > + * for Nvidia was because the hardware and drivers they make are of good quality. This makes > + * them a good generic choice. */ You'll probably want to print a FIXME or WARN if we get here, since it means the card wasn't recognized. Overall the patches look pretty reasonable, the issues I mentioned are all minor. You should use more descriptive subjects for your patches though, these end up in the commit log, and "wined3d: refactoring and add Mesa AMD/ATI driver support" doesn't say much about what the individual patches are supposed to do.

1 0