February 2010 - Wine-devel - list.winehq.org

Re: gdiplus: Implement GdipImageRotateFlip.
by Vincent Povirk 24 Feb '10

24 Feb '10

Sorry, this is wrong. It'll clobber the bitmap's palette if it originally has one. On Wed, Feb 24, 2010 at 5:10 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > >

1 0

dns-sd dll implementation -- Needs work
by C.W. Betts 24 Feb '10

24 Feb '10

What do you guys think? it's a wrapper for multicast DNS, aka Bonjour®. I know there's probably a patches mailing list, but I put this here for feedback.

5 6

grr. america's army 3 downloader requires .net 3.5...
by Dan Kegel 24 Feb '10

24 Feb '10

http://www.americasarmy.com/downloads/ lists two ways to download: 1) steam, which works, after some tweaking. 2) "deploy client" (see http://www.aadeploy.com ), which uses .net 3.5. Bleah.

1 0

Re: shell32[2/2]: implements shell link's GetCurFile (with tests, fixes bug #21297) [try4]
by Juan Lang 24 Feb '10

24 Feb '10

Hi Mikolaj, this one was rejected due to formatting, I imagine because of C++ comments in the tests: + // Setting the same value will not set IsDirty... Would you mind fixing and resending? Thanks, --Juan

2 1

Regression? in first-run of Dragon NaturallySpeaking
by Susan Cragin 24 Feb '10

24 Feb '10

I haven't been installing Dragon NaturallySpeaking every day for over a week, but I did try it today, and noticed that a bug has apparently crept in. Here's what happens: Installation runs fine. Then I try running the program for the first time. The microphone level test is fine, and the test for microphone accuracy. But then the window that brings up the training dialogue freezes. I imagine it's probably been noticed, but wanted to make sure before I investigated and filed a bug or did a regression test. Susan

2 1

Bad usage of ok() macro in tests
by Yann Droneaud 24 Feb '10

24 Feb '10

Hi, While trying to manage to fix warning about unused values, I've found a problem about some usages of ok() macro. ok() macros is defined in include/wine/test.h as: #define ok_(file, line) (winetest_set_location(file, line), 0) ? 0 : winetest_ok #define ok ok_(__FILE__, __LINE__) One good example: ok( val != NULL, "Invalid value\n"); is expanded as (winetest_set_location(file, line), 0) ? 0 : winetest_ok(val != NULL, "Invalid value\n"); One bad example: if (!ok( val != NULL, "Invalid value\n")) is expanded as if (!(winetest_set_location(file, line), 0) ? 0 : winetest_ok(val != NULL, "Invalid value\n")) And is then evaluated as 1) if ( !(0) ? 0 : winetest_ok(val != NULL, "Invalid value\n")) 2) if ( 1 ? 0 : winetest_ok(val != NULL, "Invalid value\n")) ^ ouch ! 3) if (0) So this is pretty useless. Hopefully, this is only of limited use in wine test suite: find . -type d -name tests | xargs grep -r '[=\!][[:space:](]*ok[[:space:]]*(' returns only four cases: ./dlls/user32/tests/scroll.c: if ( !ok( hMainWnd != NULL, "Failed to create parent window. Tests aborted.\n" ) ) ./dlls/kernel32/tests/file.c: !ok( UnlockFile( handle, 100, 0, 10, 0 ), "UnlockFile 100,10 failed\n" ); ./dlls/comctl32/tests/treeview.c: if ( !ok(hMainWnd != NULL, "Failed to create parent window. Tests aborted.\n") ) ./dlls/shell32/tests/autocomplete.c: if(!ok(hMainWnd != NULL, "Failed to create parent window. Tests aborted.\n")) There's only 3 case with a real problem. The fourth is something very strange: the !ok() in ./dlls/kernel32/tests/file.c seems to be a typo, or someone wanted to disable the test. Regards. -- Yann Droneaud

2 2

Re: [2/2] wordpad: Number of preview pages to show when unzoomed is persistent.
by James Mckenzie 24 Feb '10

24 Feb '10

>Either one or two pages may be shown in print preview when zoomed out. >This value is stored in the registry in native wordpad, and preserved >while opening and closing the print preview. Zooming in will only show one >page, but the pages shown value must be saved because it will return to the >preview pages shown value after unzooming completely. If two pages should >be shown when there is only one page of text, then a second blank page is >shown. Dylan: The Windows version of Wordpad also stores the last font values (name/point sized) used in the Registry as well. Is this needed/desired with the Wine version? Thank you. James McKenzie

2 1

Re: user32: Use whole window rectangle for UpdateLayeredWindow
by Alexandre Julliard 24 Feb '10

24 Feb '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -3398,14 +3398,14 @@ BOOL WINAPI UpdateLayeredWindowIndirect( HWND hwnd, const UPDATELAYEREDWINDOWINF > > if (info->hdcSrc) > { > - HDC hdc = GetDCEx( hwnd, 0, DCX_CACHE ); > + HDC hdc = GetWindowDC( hwnd ); > > if (hdc) > { > int x = 0, y = 0; > RECT rect; > > - GetClientRect( hwnd, &rect ); > + GetWindowRect( hwnd, &rect ); > if (info->pptSrc) > { > x = info->pptSrc->x; > @@ -3415,8 +3415,8 @@ BOOL WINAPI UpdateLayeredWindowIndirect( HWND hwnd, const UPDATELAYEREDWINDOWINF > if (!info->prcDirty || (info->prcDirty && IntersectRect(&rect, &rect, info->prcDirty))) > { > TRACE( "copying window %p pos %d,%d\n", hwnd, x, y ); > - BitBlt( hdc, rect.left, rect.top, rect.right, rect.bottom, > - info->hdcSrc, rect.left + x, rect.top + y, SRCCOPY ); > + BitBlt( hdc, 0, 0, rect.right - rect.left, rect.bottom - rect.top, > + info->hdcSrc, x, y, SRCCOPY ); Shouldn't you map prcDirty to window coordinates before intersecting? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ntdll/tests: Add more tests for registry symlinks.
by Paul Vriens 24 Feb '10

24 Feb '10

Hi Alexandre, This one made my Vista (Ultimate SP2) box starting to crash (the box itself not just the test). Another Vista Ultimate SP2 system doesn't show this issue. Both boxes are VMware guests btw though on different hosts. The attached patch shows the culprit but I'm not sure if the preceding NtOpenKey block should be skipped as well. We can just "if (0)" this whole block but we will never be sure how many systems were affected. Does the fact that one of my boxes crashes warrant the skipping of this particular test? -- Cheers, Paul.

2 1

Using assert() in wine dll code
by Paul Chitescu 24 Feb '10

24 Feb '10

Hi! Recently I've run into excessive use of assertions in some code after a regression was caused by one of my commits. A parameter that came from the application was "validated" this way. The code in question is in quartz.dll but there are asserts in many other places, a short grep in the dlls directory found 1387 of them... I suggest we carefully evaluate asserts from wine dll code. Only locally computed conditions should trigger an assertion failure (in case we have coding errors). Parameters received from function calls should either return an error (and possibly a WARN or ERR message) or segfault if Windows does the same (so a handler would potentially catch the proper exception). Would this qualify as a task or tasklet? Paul Chitescu

1 0