February 2010 - Wine-devel - list.winehq.org

Re: user32: DeleteDC() should allow to delete a DC returned by GetDC(). Take 2.
by Alexandre Julliard 24 Feb '10

24 Feb '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > The test passes under XP SP3. > --- > dlls/gdi32/dc.c | 2 +- > dlls/gdi32/tests/dc.c | 107 +++++++++++++++++++++++++++++++++++++++++++++++- > dlls/user32/painting.c | 2 +- > 3 files changed, 108 insertions(+), 3 deletions(-) You still need to test window DCEs (CS_OWNDC). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Windows allows to delete a busy DC, add a test case.
by Alexandre Julliard 24 Feb '10

24 Feb '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > The test passes under XP SP3. > > --- > dlls/gdi32/tests/dc.c | 43 ++++++++++++++++++++++++++++++++++++++++++- > dlls/user32/painting.c | 17 ++++------------- > 2 files changed, 46 insertions(+), 14 deletions(-) You'd want to verify this with class and windows DCs too before removing the check. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams. [try 2]
by Alexandre Julliard 24 Feb '10

24 Feb '10

Reece Dunn <msclrhd(a)googlemail.com> writes: > NOTE: A check for integer overflow would be `position.low + move.low < > position.low`, but there are no current tests to say if integer > overflow is handled (and how it is handled) here in the tests. > Therefore, the simplest implementation is just to remove the previous > check. It may be the simplest, but the right way is to add such a test and figure out the appropriate behavior. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: tests: WINETEST_STRICT=1 disables broken().
by Alexandre Julliard 24 Feb '10

24 Feb '10

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > It would be valuable if, from time to time, WTB on test.winehq > would run the XP/7/Vista tests with WINETEST_STRICT to assess how > close Wine really is to native behaviour. > > I'm not 100% satisfied with WINETEST_STRICT. Beside > WINETEST_INTERACTIVE, I'm wondering whether it is time to > turn WINETEST_DEBUG into a bit field. Then Greg, our > WTB hero, would not need to update the web GUI every > time a new env variable is proposed. Then everybody could > easily submit WTB jobs in either strict or normal mode. You can do the same thing by changing WINETEST_PLATFORM, no need for a separate variable. -- Alexandre Julliard julliard(a)winehq.org

1 0

PeekMsg/MsgWaitForMultipleObjects question
by Joerg-Cyril.Hoehle＠t-systems.com 24 Feb '10

24 Feb '10

Hi, hopefully somebody familiar with messaging can immediately spot what's wrong with the code below. The winmm/midi tests currently in git, using PeekMsg, show that the messages (from CALLBACK_WINDOW) are almost always immediately available. Yet the code below, based on MsgWaitFor... times out multiple times during each test run. Why? This seems to affect only the messages 3c9/3ca (MOM_DONE and MOM_CALLBACK). "Bad wait 102 0": 0x102 is WAIT_TIMEOUT. That should never happen. diff --git a/dlls/winmm/tests/midi.c b/dlls/winmm/tests/midi.c index 15e02e2..a23fa19 100644 --- a/dlls/winmm/tests/midi.c +++ b/dlls/winmm/tests/midi.c @@ -67,8 +67,27 @@ static void test_notification(HWND hwnd, const char* command, UINT m1, DWORD_PTR if (hwnd) { /* msg.wParam is hmidiout, msg.lParam is the mhdr (or 0) */ BOOL seen; +#if 0 do { seen = PeekMessageA(&msg, hwnd, 0, 0, PM_REMOVE); } while(seen && spurious_message(&msg)); +#else + seen=0; + if (m1 && !seen) { + /* We observe intermittent delayed notification. Perhaps + * the OS preempts the player thread after setting MHDR_DONE + * or clearing INQUEUE, before calling DriverCallback. */ + DWORD x; + trace("Waiting for delayed message %x from %s\n", m1, command); + SetLastError(0xDEADBEEF); +#if 0 + x=MsgWaitForMultipleObjects(0, NULL, FALSE, 9999, QS_POSTMESSAGE); +#else + x=MsgWaitForMultipleObjects(0, NULL, FALSE, /*INFINITE*/9999, QS_ALLINPUT); +#endif + ok(x==WAIT_OBJECT_0,"Bad wait %x %d\n",x, GetLastError()); + seen = PeekMessageA(&msg, hwnd, 0, 0, PM_REMOVE); + } +#endif if (seen) { trace("Message %x, wParam=%lx, lParam=%lx from %s\n", msg.message, msg.wParam, msg.lParam, command); Thanks for your help, Jörg Höhle

2 2

Re: msvcrt: Implement _mbctombb.
by Maarten Lankhorst 24 Feb '10

24 Feb '10

Hi David, David Hedberg wrote: > On Wed, Feb 24, 2010 at 7:12 AM, Maarten Lankhorst > <m.b.lankhorst(a)gmail.com> wrote: > >> Hi David, >> > > Hi Maarten, > > >> David Hedberg wrote: >> >>> +/* Maps multibyte cp932 punctuation marks to single byte equivalents */ >>> +static unsigned int mbctombb_932_punct[] = { >>> + >>> 0x20,0xa4,0xa1,0x2c,0x2e,0xa5,0x3a,0x3b,0x3f,0x21,0xde,0xdf,0x00,0x00,0x00,0x5e, >>> + >>> 0x7e,0x5f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xb0,0x00,0x00,0x2f,0x00, >>> + >>> 0x00,0x00,0x7c,0x00,0x00,0x60,0x27,0x00,0x22,0x28,0x29,0x00,0x00,0x5b,0x5d,0x7b, >>> + >>> 0x7d,0x00,0x00,0x00,0x00,0xa2,0xa3,0x00,0x00,0x00,0x00,0x2b,0x2d,0x00,0x00,0x00, >>> + >>> 0x00,0x3d,0x00,0x3c,0x3e,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x5c, >>> + 0x24,0x00,0x00,0x25,0x23,0x26,0x2a,0x40}; >>> + >>> +/* Maps multibyte cp932 hiragana/katakana to single-byte equivalents */ >>> +static unsigned int mbctombb_932_kana[] = { >>> + >>> 0xa7,0xb1,0xa8,0xb2,0xa9,0xb3,0xaa,0xb4,0xab,0xb5,0xb6,0xb6,0xb7,0xb7,0xb8,0xb8, >>> + >>> 0xb9,0xb9,0xba,0xba,0xbb,0xbb,0xbc,0xbc,0xbd,0xbd,0xbe,0xbe,0xbf,0xbf,0xc0,0xc0, >>> + >>> 0xc1,0xc1,0xaf,0xc2,0xc2,0xc3,0xc3,0xc4,0xc4,0xc5,0xc6,0xc7,0xc8,0xc9,0xca,0xca, >>> + >>> 0xca,0xcb,0xcb,0xcb,0xcc,0xcc,0xcc,0xcd,0xcd,0xcd,0xce,0xce,0xce,0xcf,0xd0,0xd1, >>> + >>> 0xd2,0xd3,0xac,0xd4,0xad,0xd5,0xae,0xd6,0xd7,0xd8,0xd9,0xda,0xdb,0xdc,0xdc,0xb2, >>> + 0xb4,0xa6,0xdd,0xb3,0xb6,0xb9}; >>> >>> >> You're hardcoding this for a single code page? Are you sure you cannot use a >> more generic function instead of hardcoding a table? >> >> > > I haven't found anything that might handle it. The function in > question maps the characters in a somewhat "irregular fashion", and > only makes sense for code page 932. There's a static function > "han2zen" in dlls/mlang/mlang.c that appears to be the "inverse" (to > the extent this function is reversible), that one too is implemented > with a couple of tables. > Well, it seems msdn says the function used to be called zentohan, so if the function only makes sense for cp 932 then adding the table is harmless, I was afraid that more locales would need that function, in which case a more generic solution would have been preferred. Cheers, Maarten. PS: Use 'reply all' so wine-devel gets cc'd.

3 2

Re: msvcrt: Implement _mbctombb.
by Maarten Lankhorst 24 Feb '10

24 Feb '10

Hi David, David Hedberg wrote: > +/* Maps multibyte cp932 punctuation marks to single byte equivalents */ > +static unsigned int mbctombb_932_punct[] = { > + 0x20,0xa4,0xa1,0x2c,0x2e,0xa5,0x3a,0x3b,0x3f,0x21,0xde,0xdf,0x00,0x00,0x00,0x5e, > + 0x7e,0x5f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xb0,0x00,0x00,0x2f,0x00, > + 0x00,0x00,0x7c,0x00,0x00,0x60,0x27,0x00,0x22,0x28,0x29,0x00,0x00,0x5b,0x5d,0x7b, > + 0x7d,0x00,0x00,0x00,0x00,0xa2,0xa3,0x00,0x00,0x00,0x00,0x2b,0x2d,0x00,0x00,0x00, > + 0x00,0x3d,0x00,0x3c,0x3e,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x5c, > + 0x24,0x00,0x00,0x25,0x23,0x26,0x2a,0x40}; > + > +/* Maps multibyte cp932 hiragana/katakana to single-byte equivalents */ > +static unsigned int mbctombb_932_kana[] = { > + 0xa7,0xb1,0xa8,0xb2,0xa9,0xb3,0xaa,0xb4,0xab,0xb5,0xb6,0xb6,0xb7,0xb7,0xb8,0xb8, > + 0xb9,0xb9,0xba,0xba,0xbb,0xbb,0xbc,0xbc,0xbd,0xbd,0xbe,0xbe,0xbf,0xbf,0xc0,0xc0, > + 0xc1,0xc1,0xaf,0xc2,0xc2,0xc3,0xc3,0xc4,0xc4,0xc5,0xc6,0xc7,0xc8,0xc9,0xca,0xca, > + 0xca,0xcb,0xcb,0xcb,0xcc,0xcc,0xcc,0xcd,0xcd,0xcd,0xce,0xce,0xce,0xcf,0xd0,0xd1, > + 0xd2,0xd3,0xac,0xd4,0xad,0xd5,0xae,0xd6,0xd7,0xd8,0xd9,0xda,0xdb,0xdc,0xdc,0xb2, > + 0xb4,0xa6,0xdd,0xb3,0xb6,0xb9}; > You're hardcoding this for a single code page? Are you sure you cannot use a more generic function instead of hardcoding a table? Cheers, Maarten.

1 0

Re: "make distclean" failing?
by Dan Kegel 24 Feb '10

24 Feb '10

James McKenzie <jjmckenzie51(a)earthlink.net> wrote: > Dan Kegel wrote: >> "make distclean" failed for me today... > > I usually use just plain make clean. Is this before/after today's commits? After. And I saw a similar error today in the valgrind continuous build, which only does clean and testclean.

2 1

"make distclean" failing?
by Dan Kegel 23 Feb '10

23 Feb '10

"make distclean" failed for me today... after cleaning lots of stuff, it started trying to *build* something: ... make[1]: Leaving directory `/home/dank/wine-git/tools' config.status: creating tools/widl/Makefile make[1]: Entering directory `/home/dank/wine-git/tools/widl' ../../tools/makedep -C. -S../.. -T../.. client.c expr.c hash.c header.c proxy.c server.c typegen.c typelib.c typetree.c utils.c widl.c write_msft.c parser.y parser.l make[1]: ../../tools/makedep: Command not found make[1]: *** [depend] Error 127 make[1]: Leaving directory `/home/dank/wine-git/tools/widl' make: *** [tools/widl/Makefile] Error 2 Alexandre changed the build system today a bit, I wonder if that did it.

1 0

Re: [PATCH 9/9] oleaut32/tests: Added more typelib creation tests
by Paul Vriens 23 Feb '10

23 Feb '10

On 02/22/2010 11:16 PM, Piotr Caban wrote: > + > + hres = ITypeInfo_GetRefTypeInfo(interface1, 16,&ti); > + ok(hres == E_FAIL, "got %08x\n", hres); > + Hi Piotr, This one crashes on NT4 with just SP6a and W2K with just SP4 (tested Win98 just now and it crashes as well). Should we just "if (0)" this one? (Winetestbot would have shown btw). -- Cheers, Paul.

2 1