May 2010 - Wine-devel - list.winehq.org

Re: [PATCH 1/3] wined3d: fix texture conversion flag bug
by Henri Verbeet 14 May '10

14 May '10

The patch looks like it makes sense at first sight (though the double conversion check is less than ideal), but you really want something more descriptive for the Changelog.

1 0

Re: winedump: Print the network share name in .lnk files.
by Eric Pouech 14 May '10

14 May '10

> > @@ -245,6 +254,18 @@ static int dump_location(void) > } > printf("\n"); > > + /* dump information about the network volume the link points to */ > + printf("Network volume ofs = %08x ", loc->dwNetworkVolTableOfs); > + if (loc->dwNetworkVolTableOfs && > (loc->dwNetworkVolTableOfs<loc->dwTotalSize)) > me wonders if if (loc->dwNetworkVolTableOfs && (loc->dwNetworkVolTableOfs + sizeof(NETWORK_VOLUME_INFO)<loc->dwTotalSize)) wouldn't be better (same also would apply for test in old code above for dwVolTableOfs -- -- Eric Pouech

1 0

Re: Sudden increase of Valgrind errors
by Dan Kegel 14 May '10

14 May '10

Two things: I moved to karmic (and now more modules are enabled, since it comes with new-enough libraries), and I updated valgrind. I haven't had time to dig in to the differences. The suppressions file also needs updating for karmic. On Feb 28, 2010 5:43 AM, "Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: Hi Dan, As of Feb-25 there is a sudden increase in Valgrind errors reported at http://kegel.com/wine/valgrind/logs. The errors are in loads of modules which make me believe something generic has changed (there are also errors in modules that haven't been touched in a while). Any idea? -- Cheers, Paul.

2 2

Re: shdocvw: Added IDataObject stub implementation.
by Alexandre Julliard 14 May '10

14 May '10

Ilya Shpigor <shpigor(a)etersoft.ru> writes: > --- > dlls/shdocvw/Makefile.in | 1 + > dlls/shdocvw/dataobject.c | 127 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/shdocvw/shdocvw.h | 3 + > dlls/shdocvw/webbrowser.c | 4 ++ > 4 files changed, 135 insertions(+), 0 deletions(-) > create mode 100644 dlls/shdocvw/dataobject.c Please don't create a new file for every interface. There are enough existing files where this can go. Same for IOleLink. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] user32: Convert data in WM_DDE_EXECUTE to ansi when expected.
by testbot＠testbot.winehq.org 13 May '10

13 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2059 Your paranoid android. === W98SE (32 bit dde) === dde.c:586: Test failed: Expected TestDDEServer(, got TestDDEServer:(04dc) dde.c:588: Test failed: Got size 20 for TestDDEServer:(04dc) dde.c:659: Test failed: Expected 1, got 0 dde.c:692: Test failed: Expected 12, got 28 dde.c:700: Test failed: Expected 1, got 0 dde.c:922: Test failed: Expected FALSE, got 1 dde.c:939: Test failed: Expected item atom, got 00000000 dde.c:942: Test failed: Expected poke, got dde.c:943: Test failed: Expected 4, got 0 dde.c:692: Test failed: Expected 12, got 28 dde.c:934: Test failed: Expected 0, got 0000c1ae dde.c:935: Test failed: Expected empty string, got 4 dde.c:731: Test failed: Expected '[Command(Var)]', got (null) dde.c:732: Test failed: Expected 15, got 12 dde.c:939: Test failed: Expected item atom, got 00000000 dde.c:750: Test failed: DdeGetData should have returned 17 not 0 dde.c:756: Test failed: Expected '[Command-2(Var)]' got t dde.c:757: Test failed: Expected 17, got 0 dde.c:886: Test failed: Execpted execute hglobal, got 00000000 dde.c:892: Test failed: Expected '[Command(Var)]', got (null) dde.c:737: Test failed: Expected '[BadCommand(Var)]', got [Command(Var)] dde.c:738: Test failed: Expected 18, got 32 dde.c:895: Test failed: Expected TRUE, got 0 dde.c:896: Test failed: Expected '[Command-2(Var)]', got [Command(Var)] dde.c:714: Test failed: Expected 9 or 11, got 12 dde.c:901: Test failed: Expected '[BadCommand(Var)]', got [Command-2(Var)] dde.c:714: Test failed: Expected 9 or 11, got 13 dde.c:857: Test failed: Expected 2, 3, 4, 6, 7, 8, 9, 10 or 11, got 12 dde.c:918: Test failed: Expected TRUE, got 0 dde.c:939: Test failed: Expected item atom, got 008307f4 dde.c:812: Test failed: client failed with 15 error(s) dde.c:2040: Test failed: Expected 0xcafebabe, got 00000884 dde.c:2041: Test failed: Expected 0xdeadbeef, got 00000083

1 0

Re: [1/3] user32: Convert data in WM_DDE_EXECUTE to unicode when expected.
by testbot＠testbot.winehq.org 13 May '10

13 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2058 Your paranoid android. === W98SE (32 bit dde) === dde.c:586: Test failed: Expected TestDDEServer(, got TestDDEServer:(04dc) dde.c:588: Test failed: Got size 20 for TestDDEServer:(04dc) dde.c:659: Test failed: Expected 1, got 0 dde.c:692: Test failed: Expected 12, got 28 dde.c:700: Test failed: Expected 1, got 0 dde.c:922: Test failed: Expected FALSE, got 1 dde.c:939: Test failed: Expected item atom, got 00000000 dde.c:942: Test failed: Expected poke, got dde.c:943: Test failed: Expected 4, got 0 dde.c:692: Test failed: Expected 12, got 28 dde.c:934: Test failed: Expected 0, got 0000c1ae dde.c:935: Test failed: Expected empty string, got 4 dde.c:731: Test failed: Expected '[Command(Var)]', got (null) dde.c:732: Test failed: Expected 15, got 12 dde.c:939: Test failed: Expected item atom, got 00000000 dde.c:750: Test failed: DdeGetData should have returned 17 not 0 dde.c:756: Test failed: Expected '[Command-2(Var)]' got t dde.c:757: Test failed: Expected 17, got 0 dde.c:886: Test failed: Execpted execute hglobal, got 00000000 dde.c:892: Test failed: Expected '[Command(Var)]', got (null) dde.c:737: Test failed: Expected '[BadCommand(Var)]', got [Command(Var)] dde.c:738: Test failed: Expected 18, got 32 dde.c:895: Test failed: Expected TRUE, got 0 dde.c:896: Test failed: Expected '[Command-2(Var)]', got [Command(Var)] dde.c:714: Test failed: Expected 9 or 11, got 12 dde.c:901: Test failed: Expected '[BadCommand(Var)]', got [Command-2(Var)] dde.c:714: Test failed: Expected 9 or 11, got 13 dde.c:857: Test failed: Expected 2, 3, 4, 6, 7, 8, 9, 10 or 11, got 12 dde.c:918: Test failed: Expected TRUE, got 0 dde.c:939: Test failed: Expected item atom, got 008307f4 dde.c:812: Test failed: client failed with 15 error(s) dde.c:2040: Test failed: Expected 0xcafebabe, got 00000884 dde.c:2041: Test failed: Expected 0xdeadbeef, got 00000083

1 0

Re: wineps.drv: Remove variables scale_xx, scale_xy, scale_yx, and scale_yy and two dozen lines of dead code from append_complex_glyph.
by Nikolay Sivov 13 May '10

13 May '10

On 5/8/2010 01:36, Gerald Pfeifer wrote: > This one felt a bit like peeling an onion, but indeed while we have been > setting those three variables, we're never using them. And also ptr is > not used beyond this point, so we can remove a bunch of dead code. > I don't think it's dead. Variable ptr is used in a cycle.

2 1

Re: gdi32/tests: Remove variable oldPen which is not really used from test_widenpath.
by Vitaliy Margolen 13 May '10

13 May '10

On 05/07/2010 01:06 PM, Gerald Pfeifer wrote: > - oldPen = SelectObject(hdc, greenPen); > + SelectObject(hdc, greenPen); If it's not used it's a bug. Everything should be reset to original state to prevent influence on following tests. There are number of such places in Wine's test suite that makes it impossible to isolate the problem. Vitaliy

2 1

Re: comctl32/tests: Remove variable res which is not really used from test_monthcal_size.
by Nikolay Sivov 13 May '10

13 May '10

On 5/6/2010 02:11, Gerald Pfeifer wrote: > Also in other places don't we check the result of SendMessage, and that's > not really what we want to test here, either, from what I can tell. > > > - res = SendMessage(hwnd, MCM_GETMINREQRECT, 0, (LPARAM)&r1); > + SendMessage(hwnd, MCM_GETMINREQRECT, 0, (LPARAM)&r1); > > Actually it won't hurt to test for it here.

2 1

Re: [Fwd: Re: winemp3.acm: Fixes the Mac-specific code]
by Aric Stewart 13 May '10

13 May '10

Hi, I will admit that my understanding of both ACM drivers as well as the os x audio libraries are not perfect and mostly come from work on this code itself. So i will fully admit it is most likely full of areas needing improvement. Kristofer Henriksson wrote: > Aric, > > I may have been operating under some faulty assumptions. I thought > that all mp3 files would "begin at the beginning" and also keep track > of how much of the source data the convert function said that it used. > I am very careful to set the value of *nsrc to agree with how much > source data was successfully used and assume that the calling function > with resend the data that is not used. If this is done, it ensures a > valid frame at the start of each invocation. Yes, a proper application should do just that. It should be tracking the value in nsrc and resend unused data at the beginning of the next buffer. You get a lot of the expected source stream format from MPEG3_StreamOpen. With that i wonder if the presence of an ID3 tag becomes optional. My familiarity with mp3 format makes me unsure if a packet header would also be required. > > As far as using AudioFileStream, I tried for a bit to get it to work > before I wrote my own custom mp3 parser. I'm running Snow Leopard > (10.6.3) and never got the background music to work in Oblivion. One > of the problems is that Mp3AudioConverterComplexInputDataProc needs to > return an error if it will have more data in the future, rather than > returning zero. However, even changing this, AudioFileStream seemed to > be skipping a lot of mp3 frames. > The lack of an error in that return is probably an oversight on my part. All the mp3 clips in the game i was working with where sent in one piece so there was only one pass through the loop that consumed all of the data. I am unsure why skipping mp3 frames would occure. My guess is that I am feeding the data in incorrectly and on those boundries between feeds frames are being ignored/corrupted or the like. > If you tell me what are more appropriate assumptions I should be > making in my parser, I can fix it to work the way it should. I suppose > I am also assuming that it will usually receive at least one full > packet, and if this is unjustified I can fix this as well. If I should > expect calling functions to ignore the value of *nsrc, then I can just > implement an internal single-packet buffer, and this should take care > of the problem. > I think the assumptions we need to investigate is the one about there being a packet header at the beginning. Maybe for non variable bit rate mp3s we just get the data given to us when the stream is opened. In fact, going on a hunch i just got your code to work great with my game! What i did was this: I added PACMDRVSTREAMINSTANCE adsi to Mp3GetPacketLength and then when you would return -1 if you could not determin the header I instead returned (192000 * 144) / adsi->pwfxDst->nSamplesPerSec. I picked that because it shows up in other areas of the code where we need to get a length. This is exciting also because there where a few mp3s that whre returning 'Fmt?' errors from the stream code and would not play. But with your patch and this change those clips played as well. Does that give you something to work with? You clearly understand mp3 format better than I. -aric

2 2