May 2010 - Wine-devel - list.winehq.org

Re: advpack: Remove two variables which are not really used and two extraneous invocations of get_parameter from RegisterOCX. (RESEND)
by Alexandre Julliard 10 May '10

10 May '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > This passes testing fine for me and there are no further invocations of > get_parameter in this function (which operates on a copy), so this also > looks like an optimization? They should be used, as the comment above indicates. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: How to change text on winehq.org ?
by marco 10 May '10

10 May '10

Thank you all for your reply, I'm not familiar with this process , but I will try to find out how this works. Do I have to install git en download the complete source of the website, or can I only download the download.template change that and submit that somewhere ? Marco On 06-05-10 17:57, James Mckenzie wrote: >> Hi WineDevs, >> >> If make the packages for mandriva on sourceforge. And the text on the >> download page on the website (winehq,org) for mandriva is getting old. >> Who can I write a mail to change the text ? I already tried web-admin ad >> winehq.org some weeks ago but no reaction so far. >> >> > The source code for winehq is available. You then make the changes you feel are necessary to the source code, create a difference file and submit this to wine-patches. > > Are you familiar with this process? > > James McKenzie > > >

3 2

Re: shdocvw: implement IWebBrowser2::get_LocationName
by Jacek Caban 10 May '10

10 May '10

Hi Andrey, On 5/9/10 9:30 PM, Andrey Turkin wrote: > --- > dlls/shdocvw/tests/webbrowser.c | 27 ++++++++++++++++++++++++--- > dlls/shdocvw/webbrowser.c | 24 ++++++++++++++++++++++-- > 2 files changed, 46 insertions(+), 5 deletions(-) + if (This->doc_host.document&& SUCCEEDED(IUnknown_QueryInterface( + This->doc_host.document,&IID_IHTMLDocument2, (void**)&doc))) { + hres = IHTMLDocument2_get_title(doc, LocationName); + IHTMLDocument2_Release(doc); There is no reason to make this MSHTML-specific by using IHTMLDocument2 here. Jacek

2 1

CVS repository problem
by Paul Chitescu 10 May '10

10 May '10

Hi! Something is - again - wrong with CVS. Although I fetched a wine with git I tried to verify some patches I had in the CVS tree. cvs -z3 -q up -APd cvs update: failed to create lock directory for `/home/wine/wine/dlls/acledit' (/home/wine/wine/dlls/acledit/#cvs.lock): Permission denied cvs update: failed to obtain dir lock in repository `/home/wine/wine/dlls/acledit' cvs [update aborted]: read lock failed - giving up Maybe a chown -R would help? Paul Chitescu

2 2

Re: gdi32/tests: Add a test to check for ERROR_NOACCESS when passing an invalid buffer to GetObject
by Jerome Leclanche 10 May '10

10 May '10

On Sun, May 9, 2010 at 11:55 PM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > Testcase for bug 18864. > > J. Leclanche > This patch reveals a crash in GetObject in wine which I'm unsure how to fix. Someone proposed using IsBadWritePtr(), but from what I understand, this is not a recommended solution. Any idea?

2 3

Re: comctl32: Remove unused parameter bEnable from LISTVIEW_Enable.
by Vitaliy Margolen 10 May '10

10 May '10

On 05/09/2010 07:06 AM, Gerald Pfeifer wrote: > --- > case WM_ENABLE: > - return LISTVIEW_Enable(infoPtr, (BOOL)wParam); > + return LISTVIEW_Enable(infoPtr); This indicates a bug. The parameter should really be used by LISTVIEW_Enable(). Vitaliy.

1 0

Re: Added check for PROCESS_VM_WRITE, without which, some programs go into an infinite loop Henry Blum <henry.blum@gmail.com>
by Andrey Turkin 10 May '10

10 May '10

08.05.2010 9:10, Henry Blum wrote: > --- > dlls/kernel32/process.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index 9a1f2f5..6dcad8f 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -2657,7 +2657,7 @@ HANDLE WINAPI OpenProcess( DWORD access, BOOL > inherit, DWORD id ) > if (GetVersion() & 0x80000000) access = PROCESS_ALL_ACCESS; > status = NtOpenProcess(&handle, access, &attr, &cid); > - if (status != STATUS_SUCCESS) > + if (status != STATUS_SUCCESS || (access & PROCESS_VM_WRITE)) > { > SetLastError( RtlNtStatusToDosError(status) ); > return NULL; Wouldn't this pretend operation failed for every request with PROCESS_VM_WRITE, even if NtOpenProcess succeeded, and leak a handle? Which bug should it fix?

3 2

Re: urlmon/tests: Added a new test file for testing the IUri interface
by testbot＠testbot.winehq.org 10 May '10

10 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1987 Your paranoid android. === W98SE (32 bit uri) === Failure running script in VM: Exceeded timeout limit of 315 sec === W2KPROSP4 (32 bit uri) === Timeout === W2K3R2SESP2 (32 bit uri) === Timeout

1 0

Re: user32/tests: Remove variable atom which is not really used from test_Expose.
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1983 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006C0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060138 fg 00010040 in hook HCBT_SETFOCUS win.c:2666: Test failed: GetActiveWindow() = 00000000 win.c:2666: Test failed: GetFocus() = 00000000 win.c:2692: Test failed: GetActiveWindow() = 00000000 win.c:2692: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070136 fg 00010040 in hook HCBT_SETFOCUS win.c:2751: Test failed: GetActiveWindow() = 00000000 win.c:2751: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0003015A fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00300136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00310136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000301A0 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000701A0 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000801A0 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00190138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00020142 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0003015A fg 00010040 in hook HCBT_SETFOCUS

2 1

Re: user32/tests: Remove SetShellWindowEx from test_shell_window.
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1974 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006C0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060138 fg 00010040 in hook HCBT_SETFOCUS win.c:2664: Test failed: GetActiveWindow() = 00000000 win.c:2664: Test failed: GetFocus() = 00000000 win.c:2690: Test failed: GetActiveWindow() = 00000000 win.c:2690: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006F0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00080138 fg 00010040 in hook HCBT_SETFOCUS win.c:2749: Test failed: GetActiveWindow() = 00000000 win.c:2749: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000B012C fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00310138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00320138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000A0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000B0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00810178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00020142 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000B012C fg 00010040 in hook HCBT_SETFOCUS

2 1