August 2011 - Wine-devel - list.winehq.org

Re: wine-devel Digest, Vol 73, Issue 58
by Michael Ost 22 Aug '11

22 Aug '11

Louis, I wonder if the patch referred to here is relevant for the device detection we need for the ilok...? I'm kinda shooting in the dark, without much background, but the message jumped out at me. - mo On 08/22/2011 08:06 AM, wine-devel-request(a)winehq.org wrote: > Message: 3 > Date: Mon, 22 Aug 2011 14:34:59 +0200 (CEST) > From: Francois Gouget<fgouget(a)free.fr> > Subject: Re: [PATCH] mountmgr: Support the dbus service udisks for > dynamic devices :-) [try 5] > To: wine-devel(a)winehq.org > Cc: Detlef Riekenberg<wine.dev(a)web.de>, wine-patches(a)winehq.org > Message-ID:<alpine.DEB.2.02.1108221431200.19831(a)amboise.dolphin> > Content-Type: text/plain; charset="iso-8859-15" > > On Tue, 16 Aug 2011, Detlef Riekenberg wrote: > [...] >> Recent distributions depend on udisks, so the libhal development package >> should be uninstalled or disabled when building Wine (--without-hal). > > I don't understand this recommendation to build with '--without-hal'. > > It should be possible to build a Wine binary that will run on both old > HAL-based Linux distributions and the new usdisks-based ones. Such a > binary would need to be built with both HAL and udisks support. Are you > saying your patch makes that is impossible?

1 1

Re: mmdevapi: After GetBuffer, refuse Reset, but Start/Stop is ok.
by Andrew Eikum 22 Aug '11

22 Aug '11

On Mon, Aug 22, 2011 at 10:56:29AM +0200, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > My tests also show that a GetBuffer/ReleaseBuffer pair is left > undisturbed by Stop/Start in between. Fortunately, this > has no effect on the current code (but it shows that Stop must > not change This->held_frames or the write_pos). > Could you add tests to render.c showing this? Andrew

2 1

Re: ntdll: While requesting TokenGroups calculate required user buffer size in server (try2)
by Alexandre Julliard 22 Aug '11

22 Aug '11

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > + SERVER_START_REQ( get_token_groups ) > { > - need_more_memory = FALSE; > + TOKEN_GROUPS *groups = tokeninfo; > + void *buffer; > > - SERVER_START_REQ( get_token_groups ) > - { > - TOKEN_GROUPS *groups = tokeninfo; > + /* reply buffer is always shorter than output one */ > + buffer = tokeninfolength ? RtlAllocateHeap(GetProcessHeap(), 0, tokeninfolength) : NULL; Please avoid complex operation like heap allocations inside a server request block. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: tools/wine.inf: Add registry key HKLM, %CurrentVersionNT%, "ProductName"
by Alexandre Julliard 22 Aug '11

22 Aug '11

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > Hi, this fixes http://bugs.winehq.org/show_bug.cgi?id=28065 This would need to be updated when the version is changed in winecfg. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Hebrew: update
by Francois Gouget 22 Aug '11

22 Aug '11

> #: crypt32.rc:182 > msgid "KeyID=" > -msgstr "" > +msgstr "KeyID=" I think you should really translate 'KeyID' In French it was translated to 'ID de clé'. So assuming there is a Hebrew word for 'key' then this would not remain as is. > -"\t/i {package|productcode} [property]\n" > -"\t/package {package|productcode} [property]\n" > +"\t/i {package|product_code} [property]\n" > +"\t/package {package|product_code} [property]\n" Ideally you should translate the user-replaceable strings like 'package' and 'productcode'. But option names such as '/package' should remain as is of course. > msgid "DirectX Diagnostic Tool" > -msgstr "" > +msgstr "DirectX Diagnostic Tool" This is sort of a product name os it's always a bit dicey. Still, wouldn't it be better if 'Diagnostic Tool' was translated? At non-English speakers would understand what the purpose of the tool it. > "/Unix Use a Unix filename and start the file like windows explorer.\n" > "/ProgIDOpen Open a document using the following progID.\n" > "/L Show end-user license.\n" > +"/? Display this help and exit.\n" > "\n" > "start.exe version 0.2 Copyright (C) 2003, Dan Kegel\n" > "Start comes with ABSOLUTELY NO WARRANTY; for details run with /L option.\n" Nothing is translated here. This whole msgstr should be removed. > msgid "RENAME <filename> renames a file.\n" > -msgstr "RENAME <filename> renames a file\n" > +msgstr "RENAME <filename> renames a file.\n" [...] > msgid "VER displays the version of cmd you are running.\n" > -msgstr "VER displays the version of cmd you are running\n" > +msgstr "VER displays the version of cmd you are running.\n" [...] > msgstr "" > +"ENDLOCAL ends localization of environment changes in a batch file\n" > +"which were introduced by a preceding SETLOCAL.\n" [...] > -msgstr "%s : File Not Found\n" > +msgstr "%s: File Not Found\n" [...a lot more...] These are not translated and do not have their place in a PO file. They will prevent future translators working on this file from knowing what has been translated. These totally prevent the patch from going in as is. Please fix it and resubmit. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 1

Re: [1/3] wined3d: Constant load optimisations
by Henri Verbeet 22 Aug '11

22 Aug '11

On 20 August 2011 18:46, Norbert Lataille <nlataill(a)gmail.com> wrote: > Performance gains (for parts 1/2/3) on WoW: > http://norbert.lataille.free.fr/constants.html > Results for 3dmark06, X3: http://norbert.lataille.free.fr/perf.html > (line: Constants). > Do you have those in a reasonable format as well?

3 5

Re: [PATCH] mountmgr: Support the dbus service udisks for dynamic devices :-) [try 5]
by Francois Gouget 22 Aug '11

22 Aug '11

On Tue, 16 Aug 2011, Detlef Riekenberg wrote: [...] > Recent distributions depend on udisks, so the libhal development package > should be uninstalled or disabled when building Wine (--without-hal). I don't understand this recommendation to build with '--without-hal'. It should be possible to build a Wine binary that will run on both old HAL-based Linux distributions and the new usdisks-based ones. Such a binary would need to be built with both HAL and udisks support. Are you saying your patch makes that is impossible? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Vote Electronique: Les gens qui votent ne décident rien. Ceux qui comptent les votes décident de tout.

1 0

Re: [3/3]usp10/test: test ScriptXtoX on an RTL set with differring cChars and cGlyphs
by Marvin 22 Aug '11

22 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13546 Your paranoid android. === W2KPROSP4 (32 bit usp10) === usp10.c:1931: Test failed: ScriptCPtoX trailing: iCP=8 should return piX=0 not 0

1 0

Re: server: correctly map mutex acces rights
by Marvin 22 Aug '11

22 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13534 Your paranoid android. === W7PROX64 (64 bit sync) === sync.c:160: Test failed: WaitForSingleObject succeeded sync.c:177: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5

1 0

Re: [PATCH 9/9] wscript: add textstream.c; implement Host_get_StdOut
by Octavian Voicu 22 Aug '11

22 Aug '11

On Mon, Aug 22, 2011 at 1:54 PM, Michał Ziętek wrote: > +static HRESULT WINAPI TextStream_QueryInterface(ITextStream *iface, REFIID riid, void **ppv) > +{ > + WINE_TRACE("(%s %p)\n", wine_dbgstr_guid(riid), ppv); > + > + if(IsEqualGUID(&IID_IUnknown, riid) > + || IsEqualGUID(&IID_IDispatch, riid) > + || IsEqualGUID(&IID_IArguments2, riid)) { Hello, There's a copy-paste typo here. Cheers, Octavian

1 0