August 2011 - Wine-devel - list.winehq.org

Re: [6/6] cmd/tests: Add tests for mixed echo modes
by Marvin 26 Aug '11

26 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13762 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x66 position 0 in line 141 (got 'foo ', wanted 'foo7(a)space@@or_broken(a)foo@space@') batch.c:301: Test failed: unexpected char 0x66 position 0 in line 142 (got 'foo ', wanted 'foo9(a)space@@or_broken(a)foo@space@')

1 0

Re: [5/6] cmd/tests: Add tests for redirections within IF statements
by Marvin 26 Aug '11

26 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13761 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x66 position 0 in line 126 (got 'foo ', wanted 'foo7(a)space@@or_broken(a)foo@space@') batch.c:301: Test failed: unexpected char 0x66 position 0 in line 127 (got 'foo ', wanted 'foo9(a)space@@or_broken(a)foo@space@')

1 0

Re: [3/6] cmd: Fix redirection handle parsing
by Marvin 26 Aug '11

26 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13760 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x66 position 0 in line 126 (got 'foo ', wanted 'foo7(a)space@@or_broken(a)foo@space@') batch.c:301: Test failed: unexpected char 0x66 position 0 in line 127 (got 'foo ', wanted 'foo9(a)space@@or_broken(a)foo@space@')

1 0

Testing edge cases and undocumented behavior
by Scott Ritchie 26 Aug '11

26 Aug '11

There was a bit of a philosophical discussion on #winehackers about the merits of creating tests for functions that might be testing undefined or unimportant behavior. Windows behaves one way, we behave another, the tests measure this delta, but it's unknown if this will actually improve a real world application. There's always regression potential with any code change, however on balance adding more (fixed) tests should on average reduce that risk. Are the tests themselves evidence that a change is needed? More broadly, should we resist any change without a particular (real-world) application in hand that needs it? Or should we err on the side of testable behavior, because somewhere out there a Windows developer may have written an app the same way the test author did? Thanks, Scott Ritchie

3 4

Testing edge cases and undocumented behavior
by Joerg-Cyril.Hoehle＠t-systems.com 26 Aug '11

26 Aug '11

Vincent Povirk wrote: >A test that passes on Windows and fails on Wine is not sufficient to >motivate a change to Wine. I wished Wine had "wine_dont" beside "todo_wine". Exact same behaviour, it justs reads differently. 2 examples: mmdevapi has a bug where after Initialize(SHARED, unsupported_format) is returned with an error, Initialize(SHARED, supported_format) fails with ALREADY_INITIALIZED, yet the device is unusable. I've written tests to detect this, because I want to know if MS fixes that in w8, but I don't advise Wine to mimic that behavior now. if (mode == SHARED && ...) wine_dont ok(hr == E_ALREADY_INITIALIZED, "Initialize #2 returned %08u\n", hr); else ok(hr == S_OK, "Initialize #2 returned %08u\n", hr); Should MS fix the apparent bug, remove the 3 topmost lines. The MIDI player MCISEQ.DLL was obviously rewritten for NT: my tests reveal numerous differences in the details. Most visible: the MCI_RESUME command was dropped. In w9x, an app could implement: if (window_msg == lost_focus) mciSendCommand("Pause all"); if (window_msg == got_focus) mciSendCommand("Resume all"); and it would continue playing A/V where it left off. Since NT/XP, it'll loose music after its window is activated again. Wine's MCI supports the Resume command, presumably because it was written in 1999. I've put some todo_wine in the MCI tests that should read wine_dont instead of todo_wine because I don't want somebody to come by and "fix" the deviation from XP by dropping the Resume command. Regards, Jörg Höhle

2 1

Re: [PATCH 2/2] winealsa: Loudly recommend Pulse users to upgrade to handle_underrun.
by Alexandre Julliard 26 Aug '11

26 Aug '11

Joerg-Cyril.Hoehle(a)t-systems.com writes: > @@ -525,6 +525,9 @@ HRESULT WINAPI AUDDRV_GetAudioEndpoint(const char *key, IMMDevice *dev, > if(handle_underrun && ((lconf = make_handle_underrun_config(key)))){ > err = snd_pcm_open_lconf(&This->pcm_handle, key, stream, SND_PCM_NONBLOCK, lconf); > TRACE("Opening PCM device \"%s\" with handle_underrun: %d\n", key, err); > + if(err < 0) > + ERR("PulseAudio \"%s\" %d without handle_underrun. Audio may hang." > + " Please upgrade to alsa_plugins > 1.0.24\n", key, err); It seems to me this should only apply to the EINVAL case. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/7] dinput: Added ConfigureDevices dialog
by Alexandre Julliard 26 Aug '11

26 Aug '11

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > +STRINGTABLE > +BEGIN > + IDS_NOACTION "-" > + IDS_ACTIONCOLUMN "Action" > + IDS_OBJECTCOLUMN "Object" > +END A string like "-" probably doesn't need to be in resources. Also these strings should be added in the patch that uses them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32: add ICDBurn interface stub
by Alexandre Julliard 26 Aug '11

26 Aug '11

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/shell32/Makefile.in | 1 + > dlls/shell32/cdburn.c | 180 > ++++++++++++++++++++++++++++++++++++++ > dlls/shell32/shell32_classes.idl | 6 ++ > dlls/shell32/shell32_main.h | 1 + > dlls/shell32/shellole.c | 1 + > include/shobjidl.idl | 28 ++++++ > 6 files changed, 217 insertions(+), 0 deletions(-) > create mode 100644 dlls/shell32/cdburn.c Could you please try to put this in some existing file? We have already way too many files in shell32. -- Alexandre Julliard julliard(a)winehq.org

1 0

Tasks request
by Nowres Rafid 26 Aug '11

26 Aug '11

Hello, I want to help the wine project, any one can tell me what tasks I can start with.Thanks Nowres rafid

4 4

Re: [PATCH] msiexec: implement a sane server stub (i.e. not while(TRUE); )
by Hans Leidekker 26 Aug '11

26 Aug '11

2 2