August 2011 - Wine-devel - list.winehq.org

Re: Assorted spelling fixes.
by Marvin 24 Aug '11

24 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13664 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [2/3] msi/tests: Skip a test if the process is limited.
by Austin English 24 Aug '11

24 Aug '11

On Wed, Aug 24, 2011 at 03:22, Hans Leidekker <hans(a)codeweavers.com> wrote: > --- > dlls/msi/tests/action.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/dlls/msi/tests/action.c b/dlls/msi/tests/action.c > index aac601f..90832af 100644 > --- a/dlls/msi/tests/action.c > +++ b/dlls/msi/tests/action.c > @@ -4721,6 +4721,12 @@ static void test_create_remove_folder(void) > { > UINT r; > > + if (is_process_limited()) > + { > + skip("process is limited\n"); > + return; > + } > + > CreateDirectoryA("msitest", NULL); > CreateDirectoryA("msitest\\first", NULL); > CreateDirectoryA("msitest\\second", NULL); > -- > 1.7.4.1 Shouldn't that be a win_skip()? Wine always runs as administrator, and if the process is running as a limited user, something may be broken? Unless you're preparing for when wine supports non-admin mode.. :) -- -Austin

4 6

Re: [PATCH 1/8] msi: use an array instead of a hashtable for WHEREVIEW
by Alexandre Julliard 24 Aug '11

24 Aug '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > +static UINT add_row(MSIWHEREVIEW *wv, UINT val) > { > - MSIHASHENTRY *new = msi_alloc(sizeof(MSIHASHENTRY)); > - MSIHASHENTRY *prev; > + MSIROWENTRY *new; > + > + if (wv->reorder_size <= wv->row_count) > + { > + MSIROWENTRY **new_reorder; > + UINT newsize = wv->reorder_size * 2; > + > + new_reorder = msi_alloc_zero(sizeof(MSIROWENTRY *) * newsize); > + > + if (!new_reorder) > + return ERROR_OUTOFMEMORY; > + > + memcpy(new_reorder, wv->reorder, wv->row_count * sizeof(MSIROWENTRY *)); > + msi_free(wv->reorder); Any reason for not doing a realloc instead? -- Alexandre Julliard julliard(a)winehq.org

1 0

mmdevapi: Do not mix frames and bytes.
by Joerg-Cyril.Hoehle＠t-systems.com 24 Aug '11

24 Aug '11

Hi, what happened to that patch? Perhaps there is too much understatement in the subject line. If you look at the code, not the patch, you'll see that alsa_wrap_buffer is called twice, once with bytes, once with frames. That is obviously wrong, so my patch puts frames everywhere. Regards, Jörg Höhle

2 1

Re: [2/8] cmd: Fix FOR tab handling
by Alexandre Julliard 24 Aug '11

24 Aug '11

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -902,8 +902,10 @@ void WCMD_for (WCHAR *p, CMD_LIST **cmdList) { > WIN32_FIND_DATAW fd; > HANDLE hff; > int i; > - const WCHAR inW[] = {'i', 'n', ' ', '\0'}; > - const WCHAR doW[] = {'d', 'o', ' ', '\0'}; > + const WCHAR inW[] = {'i', 'n', ' ', '\0'}; > + const WCHAR inTabW[] = {'i', 'n', '\t', '\0'}; > + const WCHAR doW[] = {'d', 'o', ' ', '\0'}; > + const WCHAR doTabW[] = {'d', 'o', '\t', '\0'}; You don't want to duplicate every string this way. This needs some sort of helper function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ntdll: provide a timestamp debug channel, which prints a millisecond resolution timestamp in front of debug output, very useful to debug deadlocks
by Dmitry Timoshkov 24 Aug '11

24 Aug '11

Bernhard Loos <bernhardloos(a)googlemail.com> wrote: > ret = wine_dbg_printf( "%7u:", (unsigned int) (now.QuadPart - server_start_time) / 10000 ); Probably you want to use wine_dbgstr_longlong() here. -- Dmitry.

1 0

Re: ntdll: provide a timestamp debug channel, which prints a millisecond resolution timestamp in front of debug output, very useful to debug deadlocks
by Alexandre Julliard 24 Aug '11

24 Aug '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -164,8 +165,16 @@ static int NTDLL_dbg_vlog( enum __wine_debug_class cls, struct __wine_debug_chan > /* only print header if we are at the beginning of the line */ > if (info->out_pos == info->output || info->out_pos[-1] == '\n') > { > + if (TRACE_ON(timestamp)) > + { > + LARGE_INTEGER now; > + extern timeout_t server_start_time; > + > + NtQuerySystemTime( &now ); > + ret = wine_dbg_printf( "% 7lld:", (now.QuadPart - server_start_time) / 10000 ); Don't use %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Add a buch of CreateScalableFontResource() tests. Resend.
by Alexandre Julliard 24 Aug '11

24 Aug '11

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > + > +/* @makedep: wine_test.ttf */ > +wine_test.ttf RCDATA wine_test.ttf How was this file created? -- Alexandre Julliard julliard(a)winehq.org

3 10

Re: [4/4] urlmon: Added basic MapUrlToZoneEx2 implementation
by Jacek Caban 24 Aug '11

24 Aug '11

Hi Thomas, On 08/24/11 01:58, Thomas Mullaly wrote: > +static HRESULT map_uri_to_zone(IUri *uri, DWORD *zone) > +{ > + HRESULT hres; > + BOOL has_scheme = FALSE; > + > + *zone = URLZONE_INVALID; > + > + hres = IUri_HasProperty(uri, Uri_PROPERTY_SCHEME_NAME,&has_scheme); > + if(hres != S_OK) > + return hres; > + > + if(has_scheme) { > + BSTR display_uri; > + > + hres = IUri_GetDisplayUri(uri,&display_uri); > + if(FAILED(hres)) > + return hres; > + > + hres = map_url_to_zone(display_uri, zone, NULL); I think map_url_to_zone should be integrated to map_uri_to_zone and operate on IUri instead of URL string (ideally we should get rid of map_url_to_zone once transition to IUri-based API will be done), not the other way around. Jacek

1 0

Re: winhttp: Support setting WinHttpRequestOption_EnableRedirects.
by Jacek Caban 24 Aug '11

24 Aug '11

Hi Hans, On 08/24/11 10:23, Hans Leidekker wrote: > + EnterCriticalSection(&request->cs ); > + switch (option) > + { > + case WinHttpRequestOption_EnableRedirects: > + { > + if (V_BOOL(&value ) == VARIANT_TRUE) You shouldn't compare bools like that, it should be if(V_BOOL(&value)). > + request->disable_feature&= !WINHTTP_DISABLE_REDIRECTS; Here is a typo, it should be ~WINHTTP_DISABLE_REDIRECTS. Jacek

1 0