August 2011 - Wine-devel - list.winehq.org

avifil32: Remove the stream format string from the resources?
by Francois Gouget 25 Aug '11

25 Aug '11

In the wvifil32 resources we have this string: IDS_AVISTREAMFORMAT "%s %s #%d" I see no way in which this can be meaningfully translated and many ways in which translators can mess it up. It was introduced in this commit: commit 4c04e1fd8773fd7b8884a8c5fead4609869bf4ab Author: Michael Günnewig <MichaelGuennewig(a)gmx.de> Date: Fri Oct 18 00:24:41 2002 +0000 - Add wavefile handler. - Add implementation for IGetFrame. - Implemented loading and writing of AVIs. - Add some more stubs for some API functions. - Add resources to avifil32.dll. - Implemented AVISaveOptionsFree. - Declared IID_* as extern in avifil32.spec (avoids linker problem). Any reason not to convert it to a simple string constant? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

1 0

winefile: Remove the title format from the resources?
by Francois Gouget 25 Aug '11

25 Aug '11

In the resources, and hence in the PO files we have this string: IDS_TITLEFMT "%s - %s" I see no way in which this can be meaningfully translated and many ways in which translators can mess it up. Yet it was moved there by this commit: commit 1573382dd6baa48bb825c26faef96abe4541b024 Author: Martin Fuchs <martin-fuchs(a)gmx.net> Date: Thu Oct 21 19:51:31 2004 +0000 - use ID_SELECT_FONT in german menu - move string constants into string resources Any reason not to move it back to a simple string constant? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Dieu dit: "M-x Lumière". Et la lumière fut.

1 0

winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol.
by Joerg-Cyril.Hoehle＠t-systems.com 25 Aug '11

25 Aug '11

Hi, what happened to this patch? There are already 2 bug reports about crashes in ReleaseBuffer that may be cured by this, even though the underlying problem is #28093 (GetCurrentPadding would not return "buffer full" on native, so the SW would not attempt to Release 0 bytes which causes winecoreaudio to barf). >- This->getbuf_last = TRUE; >+ This->getbuf_last = 1; I've nothing to change here for the time being. IIRC I have a fix for Capture ordering in my Mac queue, but that is waiting for more tests on capture mode. (FWIW, I prefer reminders than resend patches still visible in the source/patches/ list.) Regards, Jörg Höhle

1 0

Re: [PATCH 3/6] server: sharing 0 is not allowed for named pipes
by Nikolay Sivov 25 Aug '11

25 Aug '11

On 8/25/2011 08:49, Bernhard Loos wrote: > --- > dlls/ntdll/tests/pipe.c | 2 +- > server/named_pipe.c | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletions(-) > @@ -964,6 +964,12 @@ DECL_HANDLER(create_named_pipe) > struct unicode_str name; > struct directory *root = NULL; > > + if (!req->sharing || (req->sharing& ~(FILE_SHARE_READ | FILE_SHARE_WRITE))) > + { > + set_error( STATUS_INVALID_PARAMETER ); > + return; > + } > + What's a point of doing that at server side?

1 0

Re: [1/7] cmd: Fix FOR tab handling (try 3)
by Octavian Voicu 25 Aug '11

25 Aug '11

2011/8/25 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > + const WCHAR inW[] = {'i','n'}; > + const WCHAR doW[] = {'d','o'}; ... Hello, After these patches get in, it might be a good idea to make all these strings static. Even if they are const, the compiler still needs to generate code to initialize the arrays on the stack each time the function is called, element by element -- larger code size and slower. Octavian

2 1

Re: [PATCH 3/6] server: sharing 0 is not allowed for named pipes
by Marvin 25 Aug '11

25 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13692 Your paranoid android. === WXPPROSP3 (32 bit pipe) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\ntdll_test.exe, error 32

1 0

gsoc mentor summit
by Stefan Dösinger 24 Aug '11

24 Aug '11

Hi, The gsoc mentor summit organizing is getting started. Do any fellow mentors want to travel there? http://gsoc-wiki.osuosl.org/index.php/2011 Stefan PS: I vaguely remember that we once had a separate mailing list for gsoc stuff like that, but I can't find it, only Dan Kegel's old wine-gsoc-2007 list.

4 6

Re: winemenubuilder: appbundle patch 20110618
by Per Johansson 24 Aug '11

24 Aug '11

Hello again, 17 aug 2011 kl. 00:06 skrev Steven Edwards: > I've finally gotten back around to hacking the *.app bundle support in > winemenubuilder and come close to having something that mostly works. I'm attaching my current work, since I'm not sure when I'll work on it next (might be tomorrow, might be never). > - The first icon/bundle always seems to get the wrong icon, and uses > the default wine icon. I need to take some time to understand the code > a bit better and see why this is. I don't seem to have this problem. I commented out identifier from Info.plist, since I think it's a bad idea to have a non-unique one. Perhaps that was it? I also commented out the signature and PkgInfo files, since they're not really needed. Xcode on Lion does not create them anymore AFAICT. > - Bundles are created in $HOME/Applications/wine and icon's are > generated using the icns code. Support for building bundles for > shortcuts on $HOME/Desktop has not been hacked on yet. I've added bundles for desktop and also for URLs. I decided to create subdirectories in ~/Applications/Wine since a Readme icon will not tell which readme it'll open without living in the correct folder. Also, if you add the folder to the Dock and set view type to list, it kind of works as a Start menu. > I welcome your feedback. There's a few things left to be done. The pass by globals into platform_write_icon is kind of getting in the way, those values should be merged into the main execution path. I also think the xdg specific functions should also be extracted to a separate file for clarity (but perhaps that's a separate task). The two files are diff vs. the patch from Steven and diff vs current HEAD. My individual commits can be seen at https://github.com/morth/wine/commits/master (should create a separate branch I guess). Regards, -- Per Johansson

2 1

Age of Empires online
by Laurens van Oorschot 24 Aug '11

24 Aug '11

Hello, I am trying to get Age of Empires online to work under wine, unfortunately I'm having a problem getting the Windows Market Place to work. Any suggestions? Kind Regards Laurens van Oorschot

1 0

Re: po: Update French translation
by Francois Gouget 24 Aug '11

24 Aug '11

On Wed, 24 Aug 2011, Frédéric Delanoy wrote: [...] > #: notepad.rc:81 > -#, fuzzy > msgid "" > "You did not enter any text.\n" > "Please type something and try again." This one is wrong because you forgot to add the trailing dot to the translation. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux, WinNT, MS-DOS - also known as the Good, the Bad and the Ugly.

2 1