November 2012 - Wine-devel - list.winehq.org

Re: msi: Fix some leaks (coverity)
by Hans Leidekker 08 Nov '12

08 Nov '12

On Thu, 2012-11-08 at 01:32 +0100, Frédéric Delanoy wrote: > diff --git a/dlls/msi/action.c b/dlls/msi/action.c > index f9ab550..8a6c952 100644 > --- a/dlls/msi/action.c > +++ b/dlls/msi/action.c > @@ -5809,7 +5809,16 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param) > { > int len = strlenW(file->TargetPath) + strlenW(args) + 2; > if (!(image_path = msi_alloc(len * sizeof(WCHAR)))) > + { > + msi_free(name); > + msi_free(disp); > + msi_free(load_order); > + msi_free(serv_name); > + msi_free(pass); > + msi_free(depends); > + msi_free(args); > return ERROR_OUTOFMEMORY; > + } This function already has a 'done' label where memory is freed. Why not make the return value a variable and jump to the label instead of repeating these statements? > strcpyW(image_path, file->TargetPath); > strcatW(image_path, szSpace); > @@ -6070,6 +6079,7 @@ static BOOL stop_service_dependents(SC_HANDLE scm, SC_HANDLE service) > goto error; > } > > + msi_free(dependencies); > return TRUE; Same here. > > error: > diff --git a/dlls/msi/files.c b/dlls/msi/files.c > index 11913ef..98d7513 100644 > --- a/dlls/msi/files.c > +++ b/dlls/msi/files.c > @@ -336,6 +336,7 @@ UINT ACTION_InstallFiles(MSIPACKAGE *package) > if (rc != ERROR_SUCCESS) > { > ERR("Unable to load media info for %s (%u)\n", debugstr_w(file->File), rc); > + msi_free(mi); > return ERROR_FUNCTION_FAILED; > } > if (!file->Component->Enabled) continue; > @@ -513,6 +514,7 @@ UINT ACTION_PatchFiles( MSIPACKAGE *package ) > if (rc != ERROR_SUCCESS) > { > ERR("Unable to load media info for %s (%u)\n", debugstr_w(file->File), rc); > + msi_free(mi); > return ERROR_FUNCTION_FAILED; > } > comp->Action = msi_get_component_action( package, comp ); And here.

1 0

Re: [PATCH 2/2] mstask/tests: Add tests for SetTargetComputer [try 2]
by Marvin 07 Nov '12

07 Nov '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22825 Your paranoid android. === WNT4WSSP6 (32 bit task_scheduler) === task_scheduler.c:46: Test failed: CTaskScheduler CoCreateInstance failed: 80040154 task_scheduler.c:91: Test failed: CTaskScheduler CoCreateInstance failed: 80040154 task_scheduler.c:115: Test failed: CTaskScheduler CoCreateInstance failed: 80040154 task_scheduler.c:156: Test failed: CTaskScheduler CoCreateInstance failed: 80040154

1 0

Re: [PATCH 1/5] ddraw: Avoid LPDIRECTDRAW.
by Marvin 07 Nov '12

07 Nov '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22823 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: ntdll: Fixed some heap allocation stalls
by Matteo Bruni 07 Nov '12

07 Nov '12

2012/11/2 Steaphan Greene <steaphan(a)gmail.com>: > Running a game in wine showed it performing terribly. I traced this to the > fact that it allocates and deallocates tiny memory chunks over and over (I > suspect it's in C++ and passing things by value everywhere). This led to > huge stalls because the heap bins weren't fine-grained enough (these > differed in size in steps of 8 bytes, but the bins differed by 16+, so it > spent a lot of time searching each bin for a bigger block). I added more > fine-grained sizes to the smaller end of this, and now it runs faster in > wine than it does natively. :) > > This was run on Debian squeeze, amd64. > > Note, this is my first submission to wine in nearly 15 years. So, of > course, everything has changed with how this works now. Hope I have this > all right. > > --- > dlls/ntdll/heap.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/dlls/ntdll/heap.c b/dlls/ntdll/heap.c > index a9044714..eb7406b 100644 > --- a/dlls/ntdll/heap.c > +++ b/dlls/ntdll/heap.c > @@ -116,7 +116,9 @@ C_ASSERT( sizeof(ARENA_LARGE) % LARGE_ALIGNMENT == 0 ); > /* Max size of the blocks on the free lists */ > static const SIZE_T HEAP_freeListSizes[] = > { > - 0x10, 0x20, 0x30, 0x40, 0x60, 0x80, 0x100, 0x200, 0x400, 0x1000, ~0UL > + 0x10, 0x18, 0x20, 0x28, 0x30, 0x38, 0x40, 0x48, 0x50, 0x58, 0x60, 0x68, > + 0x70, 0x78, 0x80, 0x88, 0x90, 0x98, 0xA0, 0xA8, 0xB0, 0xB8, 0xC0, 0xC8, > + 0xD0, 0xD8, 0xE0, 0E88, 0xF0, 0xF8, 0x100, 0x200, 0x400, 0x1000, ~0UL > }; > #define HEAP_NB_FREE_LISTS (sizeof(HEAP_freeListSizes)/sizeof(HEAP_freeListSizes[0])) That 0E88 looks quite wrong ;) Apart from that, although I'm not an expert for this code, this patch looks reasonable to me. Maybe we don't want so many free lists, but I don't see big downsides for that (e.g. the linear search can be replaced by a binary search, if need be). Maybe adding a smaller list at the start (e.g. 0x8) makes sense too?

3 4

Re: [PATCH 1/2] winmm/tests: Add more mmioSeek tests.
by Dmitry Timoshkov 07 Nov '12

07 Nov '12

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > +static void test_mmioSeek(void) > +{ > + HMMIO hmmio; > + MMIOINFO mmio; > + LONG end, pos, size = sizeof(RIFF_buf), offset = 16; > + char test_file[MAX_PATH]; > + MMRESULT res; > + > + { > + /* test memory file */ Please avoid creating nested blocks this way, it's confusing and doesn't add readability of any kind. -- Dmitry.

1 0

Fwd: Bug#566351: libgcrypt11: should not change user id as a side effect
by Dan Kegel 07 Nov '12

07 Nov '12

After gstreamer, gcrypt is also dropping support for alternative thread libraries. Good thing secur32/schannel_gnutls.c doesn't use it. (Right?) - Dan ---------- Forwarded message ---------- From: Werner Koch <wk(a)gnupg.org> Date: Wed, Nov 7, 2012 at 1:31 AM Subject: Re: Bug#566351: libgcrypt11: should not change user id as a side effect To: Andreas Metzler <ametzler(a)downhill.at.eu.org> Cc: gcrypt-devel(a)gnupg.org, 566351(a)bugs.debian.org On Sat, 3 Nov 2012 18:29, ametzler(a)downhill.at.eu.org said: > comment sums it up: > <https://bugs.launchpad.net/debian/+source/sudo/+bug/423252/comments/72> Well, it is the usual problem with inter-library dependencies. We will never be able to get this right. The DSO is just not designed to work with completely independent libraries. I don't like to say, but in this regard Windows DLLs are a better solution. Although we can't solve all the problems we will be able to solve the thread initialization problem. Libgcrypt 1.6 will ignore the thread callbacks and assume pthread. Semaphores are then used for locking and provide a way to do thread-safe initialization. The hopefully minor drawback is that one needs to link against librt. > + case GCRYCTL_SET_THREAD_CBS: > + err = ath_install (va_arg (arg_ptr, void *), any_init_done); > +- if (! err) > +- global_init (); Okay, if that works, fine. It might break other things; I don't know. There are enough selftests to hopefully detect such a break (in particular in FIPS mode). Salam-Shalom, Werner -- Die Gedanken sind frei. Ausnahmen regelt ein Bundesgesetz. _______________________________________________ Gcrypt-devel mailing list Gcrypt-devel(a)gnupg.org http://lists.gnupg.org/mailman/listinfo/gcrypt-devel

2 1

Re: gdiplus: Avoid GdipCloneMatrix calls for the the graphics transformation matrix.
by Vincent Povirk 07 Nov '12

07 Nov '12

I won't comment on whether using GpMatrix as a value type within gdiplus generally is a good idea, but semantically this looks correct to me.

1 0

Re: [PATCH 1/2] oleaut32/tests: Add test for ITypeInfo2_fnGetContainingTypeLib
by Marvin 07 Nov '12

07 Nov '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22807 Your paranoid android. === WNT4WSSP6 (32 bit typelib2) === typelib2: unhandled exception c0000005 at 65360E09 === WXPPROSP3 (32 bit typelib2) === typelib2: unhandled exception c0000005 at 7713844F === W2K3R2SESP2 (32 bit typelib2) === typelib2: unhandled exception c0000005 at 77D1BA1C

1 0

[PATCH 2/2] oleaut32: If pointers (ppTLib or pIndex in ITypeInfo2_fnGetContainingTypeLib) are null, we simply ignore it.
by Tatyana Fokina 07 Nov '12

07 Nov '12

1 0

Re: shell32: initialize fAnyOperationsAborted in SHFileOperation (try 2)
by Marvin 06 Nov '12

06 Nov '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22786 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:2244: Test failed: SHGetNewLinkInfoA succeeded

1 0