November 2012 - Wine-devel - list.winehq.org

Re: shell32: initialize fAnyOperationsAborted in SHFileOperation
by Marvin 06 Nov '12

06 Nov '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22785 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:2244: Test failed: SHGetNewLinkInfoA succeeded

1 0

Re: iphlapi: Fix some leaks (coverity)
by Alexandre Julliard 06 Nov '12

06 Nov '12

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -1520,8 +1521,8 @@ DWORD WINAPI GetIpAddrTable(PMIB_IPADDRTABLE pIpAddrTable, PULONG pdwSize, BOOL > sizeof(MIB_IPADDRROW), IpAddrTableSorter); > ret = NO_ERROR; > } > - HeapFree(GetProcessHeap(), 0, table); > } > + HeapFree(GetProcessHeap(), 0, table); > } That's not the correct fix. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/2] gdiplus: Add support for extra transformation in GdipMeasureDriverString and GdipDrawDriverString. Take 2.
by Vincent Povirk 06 Nov '12

06 Nov '12

Series looks good to me, thanks.

1 0

Re: msi: Fix some leaks (coverity)
by Alexandre Julliard 06 Nov '12

06 Nov '12

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -151,15 +151,23 @@ static UINT propvar_changetype(PROPVARIANT *changed, PROPVARIANT *property, VART > { > HRESULT hr; > HMODULE propsys = LoadLibraryA("propsys.dll"); > + > + if (!propsys) > + { > + ERR("Failed to load propsys.dll: %u\n", GetLastError()); > + return ERROR_DLL_NOT_FOUND; > + } > pPropVariantChangeType = (void *)GetProcAddress(propsys, "PropVariantChangeType"); > > if (!pPropVariantChangeType) > { > ERR("PropVariantChangeType function missing!\n"); > + FreeLibrary(propsys); > return ERROR_FUNCTION_FAILED; > } > > hr = pPropVariantChangeType(changed, property, 0, vt); > + FreeLibrary(propsys); You don't want to load/unload the library on every call. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] d3d9/tests: Add test for IDirect3DDevice9_Reset with BackBufferWidth/Height = 0.
by Sam Edwards 06 Nov '12

06 Nov '12

On Nov 6, 2012, at 3:45, Henri Verbeet <hverbeet(a)gmail.com> wrote: > Yeah, we'll want a similar test for d3d8. Okay, I'll write that as soon as the d3d9 test is accepted. > You're probably looking for AdjustWindowRect() and SetWindowPos(). Thank you, I didn't know about AdjustWindowRect(), but why SetWindowPos()? Is this preferred over MoveWindow() for any reason? > Testing the viewport dimensions is useful, but it probably wouldn't > hurt to check the swapchain's presentation parameters and the > backbuffer's surface desc as well. Good catch, I forgot to copy the relevant code for that. Thanks, Sam

1 0

Re: widl: Ignore -app_mode option
by Alexandre Julliard 06 Nov '12

06 Nov '12

Jacek Caban <jacek(a)codeweavers.com> writes: > It also changes getopt_long to getopt_long_only, making argument parsing > less strict. Please also update the man page and the usage message. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] dmloader: Display new ref in AddRef and Release.
by Alistair Leslie-Hughes 06 Nov '12

06 Nov '12

Hi, On 6/11/2012 7:05 PM, Christian Costa wrote: > static HRESULT WINAPI IDirectMusicLoaderImpl_IDirectMusicLoader_GetObject(LPDIRECTMUSICLOADER8 iface, LPDMUS_OBJECTDESC pDesc, REFIID riid, LPVOID* ppv) > @@ -880,7 +884,7 @@ HRESULT WINAPI DMUSIC_CreateDirectMusicLoaderImpl (LPCGUID lpcGUID, LPVOID *ppob > return E_OUTOFMEMORY; > } > obj->IDirectMusicLoader8_iface.lpVtbl = &DirectMusicLoader_Loader_Vtbl; > - obj->dwRef = 0; /* will be inited with QueryInterface */ > + obj->ref = 0; /* Will be inited with QueryInterface */ Shouldn't obj->ref start at 1 or else it will never be freed. Best Regards Alistair Leslie-Hughes

3 2

Re: [PATCH] d3d9/tests: Add test for IDirect3DDevice9_Reset with BackBufferWidth/Height = 0.
by Henri Verbeet 06 Nov '12

06 Nov '12

On 6 November 2012 05:01, Sam Edwards <cfsworks(a)gmail.com> wrote: > Perhaps a similar test is necessary in other Direct3D versions, but I > haven't yet looked into it. > Yeah, we'll want a similar test for d3d8. > + /* For resizing the window, we need to know the nonclient area size */ > + ok(GetWindowRect(hwnd, &winsize), "GetWindowRect failed\n"); > + nonclient_width = winsize.right-winsize.left; > + nonclient_height = winsize.bottom-winsize.top; > + ok(GetClientRect(hwnd, &winsize), "GetClientRect failed\n"); > + nonclient_width -= winsize.right; > + nonclient_height -= winsize.bottom; ... > + ok(MoveWindow(hwnd, 0, 0, 200+nonclient_width, 150+nonclient_height, FALSE), > + "MoveWindow failed\n"); You're probably looking for AdjustWindowRect() and SetWindowPos(). > + hr = IDirect3DDevice9_GetViewport(device1, &vp); > + ok(hr == D3D_OK, "IDirect3DDevice9_GetViewport failed with %08x\n", hr); > + if(SUCCEEDED(hr)) > + { > + ok(vp.X == 0, "D3DVIEWPORT->X = %d\n", vp.X); > + ok(vp.Y == 0, "D3DVIEWPORT->Y = %d\n", vp.Y); > + todo_wine ok(vp.Width == 200, "D3DVIEWPORT->Width = %d\n", vp.Width); > + todo_wine ok(vp.Height == 150, "D3DVIEWPORT->Height = %d\n", vp.Height); > + ok(vp.MinZ == 0, "D3DVIEWPORT->MinZ = %f\n", vp.MinZ); > + ok(vp.MaxZ == 1, "D3DVIEWPORT->MaxZ = %f\n", vp.MaxZ); > + } Testing the viewport dimensions is useful, but it probably wouldn't hurt to check the swapchain's presentation parameters and the backbuffer's surface desc as well.

1 0

Re: [1/3] gdiplus: Add a test to check transformation order in GdipMeasureDriverString.
by Vincent Povirk 06 Nov '12

06 Nov '12

Thanks for writing tests. It turns out I was a bit confused when I asked for them. For some reason, I was was under the impression that GdipMeasureDriverString would return a measurement in device coordinates, when it should have been obvious to me that it returns world coordinates. Looking back at the existing tests confirms that, since the measurements are the same with a NULL matrix regardless of world transform. That means the test I wanted doesn't answer the question I wanted answered. I'm sorry I created extra work for you with my mistake. The approach of rotating and scaling still works, but it requires drawing text and visually inspecting the output. I've written and attached a test program that does that (with a matrix that rotates by 90 degrees and a world transform with a much greater scale on the Y axis than the X axis). It shows that things work as I expected. The text is stretched vertically AFTER the rotation is applied, and it's easy to see the difference between native's behavior and your patch. It also appears that the origin point (and presumably the later points as well) should not have the matrix applied to it. It looks to me like your patch does not transform the points in the GDI32 codepath, and thus gets the origin point correct in the testcase. It does transform them in the SOFTWARE codepath, and if I force that codepath to be taken, the text draws outside the bounds of the window. So the matrix shouldn't be passed to transform_and_round_points, and it's not necessary to add a matrix argument to that function.

2 1

Re: [PATCH 2/4] msvcrt: Improved _atoflt_l precision
by Alexandre Julliard 06 Nov '12

06 Nov '12

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcrt/string.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M msvcr90.dll -T ../../.. -p msvcr90_test.exe.so msvcr90.c && touch msvcr90.ok msvcr90.c:895: Test failed: got ret 0, expected ret 4, for 1e-39 make: *** [msvcr90.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1