November 2012 - Wine-devel - list.winehq.org

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header.
by Dmitry Timoshkov 06 Nov '12

06 Nov '12

Qian Hong <fracting(a)gmail.com> wrote: > This patch solve the wine side of Bug 32136. Why is this needed? wine.inf.in doesn't contain non ASCII strings. -- Dmitry.

2 3

Re: [PATCH] kernel32: Save and restore LastError in OutputDebugStringA
by Dmitry Timoshkov 06 Nov '12

06 Nov '12

Andrew Eikum <aeikum(a)codeweavers.com> wrote: > +static void test_OutputDebugString(void) > +{ > + if(!pOutputDebugStringA){ > + win_skip("OutputDebugStringA missing\n"); > + return; > + } Is there a reson to load OutputDebugStringA dynamically? -- Dmitry.

1 0

Re: [PATCH 2/2] mstask/tests: Add tests for GetTargetComputer [resend]
by Marvin 05 Nov '12

05 Nov '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22777 Your paranoid android. === WNT4WSSP6 (32 bit task_scheduler) === task_scheduler.c:44: Test failed: CTaskScheduler CoCreateInstance failed: 80040154 task_scheduler.c:89: Test failed: CTaskScheduler CoCreateInstance failed: 80040154 task_scheduler.c:113: Test failed: CTaskScheduler CoCreateInstance failed: 80040154

1 0

Re: [PATCH] kernel32: Save and restore LastError in OutputDebugStringA
by Marvin 05 Nov '12

05 Nov '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22772 Your paranoid android. === WNT4WSSP6 (32 bit debugger) === debugger.c:679: Test failed: OutputDebugString modified LastError: 0x2 === W2KPROSP4 (32 bit debugger) === debugger.c:679: Test failed: OutputDebugString modified LastError: 0x2 === WXPPROSP3 (32 bit debugger) === debugger.c:679: Test failed: OutputDebugString modified LastError: 0x2

1 0

Netflix (was: [PATCH 1/7] advapi: Implement SetSecurityInfo on top of NtSetSecurityObject.)
by Stefan Dösinger 05 Nov '12

05 Nov '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2012-11-04 06:46, schrieb Erich E. Hoover: > Once this patch series has been applied then Netflix (using > Silverlight 4.x) will successfully load and play movies and TV > shows, Out of curiosity, how does the video playback part of Netflix perform? I imagine that it is using DirectDraw overlays or Direct3D9 YUV surfaces, which are somewhat supported, but have many rough edges. Is playback performant enough for full HD videos? How does the CPU usage compare to Windows? Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJQl9YQAAoJEN0/YqbEcdMwlF4P/3s2AiUWuc9XBLKeWqEfPdwq SLt0Hmx9MVHbiWt9SojsLZDGc79OImA18Ay8k98T3igH30KHLm7lUbCcYrczrVsQ cFrJ0Lrz5clYWrJR6bw0UckQEYXYdgb+EZte4laq9Y7HoIsg+gw9Z+tF86qDarZ+ +DNAOejD5ybiUBEBZ0JvBr/pSmsj9OXFLFJ1CxxZituUMnyk/mK7Uet+1Pid/XqA lIkid9NQa7Wi/+EB3XD82mUtTopgyzWGeT36GszFnybWQCBjQ0jjAj4Qip5RQZ61 CgBREvjCs/qqPA15BinHcpCWZytC7HjROwHEpmm4I3UssSDBXwCkqQ0Q4mPIwRct rOsvWdZmoYHT/aI7JbJo4y9oWBackGeJrtiaXOigoXE1z/v+dtu/ha9yhOj4rUsd wEVyffTsqsEID4XJLkchrHB0uWe/YQrnNTLKkjVEWvaogl1lqJr79wiq7Z46iH0D U63XQQnqMgw1RXnvd8YjqWgUFvOnkveXrHxKPeYQkNxN88hvXLdPjah/tWBZpt8q 9IDURMZ/kNdJNF7E5ziwu0ulGZ9dsvQ8YtbIh6oWP+7zXax3m8N7Gl7dkKl+ltOS 1UgJgTuXkEnv25FDPFucWN2/hlrw9AT3msghl3n4ItuX5NouhlU7MvZR2P+9P/TC bTK3AwL1hmZZxLgCgWWd =QJTC -----END PGP SIGNATURE-----

2 1

Re: [PATCH 3/7] advapi: Implement GetNamedSecurityInfoW on top of GetSecurityInfo (try 3).
by Charles Davis 05 Nov '12

05 Nov '12

On Nov 4, 2012, at 1:30 AM, Erich E. Hoover wrote: > This patch implements GetNamedSecurityInfoW on top of the more > fundamental GetSecurityInfo function, permitting the return of more > accurate ownership information for files. PlayReady uses this > information to determine if its files have the appropriate > permissions, without the correct permissions it will attempt to recopy > the individualization file (and fail). Additionally, this patch adds > tests for retrieving the ACL information set on files. > > This version fixes some problems in the tests on older Windows > versions, sorry I didn't catch that earlier. It now also fixes a > mistake I made between testing try 2 and pushing it out :/ > + hfile = CreateFileW( name, access, FILE_SHARE_READ|FILE_SHARE_WRITE|FILE_SHARE_DELETE, > + NULL, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, 0 ); Only works on files right now, huh? You might then want to check to make sure the caller says it's a file by comparing the 'type' against SE_FILE_OBJECT, and return ERROR_CALL_NOT_IMPLEMENTED if they didn't. After all, part of the point of that parameter is to tell you which function you need to call to open the object in the first place :). (Same for patch 2.) Chip

2 3

Re: [PATCH] kernel32: Better stubs for SetVolumeMountPoint.
by Alexandre Julliard 05 Nov '12

05 Nov '12

Johannes Obermayr <johannesobermayr(a)gmx.de> writes: > + /* Abort if already mounted */ > + if (GetVolumeNameForVolumeMountPointW(path, (LPWSTR)volume, MAX_PATH)) > + { You can't do that. > +/************************************************************************ > + * SetVolumeMountPointA (KERNEL32.@) > + */ > +BOOL WINAPI SetVolumeMountPointA(LPCSTR path, LPCSTR volume) > +{ > + FIXME("(%s, %s), stub!\n", debugstr_a(path), debugstr_a(volume)); > + > + return FALSE; > +} Please implement this by calling the W function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] jscript: Added more enumerable attribute tests
by Marvin 05 Nov '12

05 Nov '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22760 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [2/2] opengl32: Implement the wglUseFontOutlines WGL_FONT_LINES format (resend)
by Alexandre Julliard 05 Nov '12

05 Nov '12

Sam Edwards <cfsworks(a)gmail.com> writes: > Also review carefully: I use if(format) instead of if(format == > WGL_FONT_POLYGONS) because WGL_FONT_POLYGONS isn't defined anywhere in > Wine. You should add the define in the appropriate header and make use of it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/5] mstask/tests: Avoid test failures on NT4
by Alexandre Julliard 05 Nov '12

05 Nov '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > This is not visible with winetest (mstask.dll: n/a), but > testbot results for mstask test patches would be marked as failed. That's a testbot bug. -- Alexandre Julliard julliard(a)winehq.org

1 0