April 2013 - Wine-devel - list.winehq.org

Re: [PATCH 8/8] wined3d: Skip non-textureable formats in check_fbo_compat().
by Henri Verbeet 10 Apr '13

10 Apr '13

On 10 April 2013 01:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > --- > dlls/wined3d/utils.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index da8fc7b..5010676 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -1038,6 +1038,9 @@ static void check_fbo_compat(const struct wined3d_gl_info *gl_info, struct wined > GLenum status; > GLuint tex; > > + if (!(format->flags & WINED3DFMT_FLAG_TEXTURE)) > + return; > + I'm not sure about this one, what exactly should this achieve? In either case, this probably belongs in init_format_fbo_compat_info(), together with the other similar checks.

2 3

[PATCH v5 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky 10 Apr '13

10 Apr '13

Main changes fom v4: 1) deny_lock_file uses FS_DOES_SHARELOCK flag from fs_flags to determine whether to use VFS locks or not. 2) Make nfs code return -EBUSY for share conflicts (was -EACCESS). Main changes from v3 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), The patchset avoid data races problem on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a deny lock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This let us not mix one share reservation approach with another. The #1 patch adds flags to fcntl and implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -EBUSY in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -EBUSY untill this open is closed. Now this flag is processed by CIFS filesystems only. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND ----- Pavel Shilovsky (7): fcntl: Introduce new O_DENY* open flags CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support CIFS: Use NT_CREATE_ANDX command for forcemand mounts NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts fs/cifs/cifsacl.c | 8 +-- fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 ++++++- fs/cifs/cifsproto.h | 8 +-- fs/cifs/cifssmb.c | 50 ++++++++++--------- fs/cifs/dir.c | 16 +++--- fs/cifs/file.c | 20 +++++--- fs/cifs/inode.c | 16 +++--- fs/cifs/link.c | 25 +++------- fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 +++--- fs/cifs/smb2file.c | 10 ++-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2ops.c | 10 ++-- fs/cifs/smb2pdu.c | 6 +-- fs/cifs/smb2proto.h | 14 +++--- fs/fcntl.c | 5 +- fs/locks.c | 105 ++++++++++++++++++++++++++++++++++++--- fs/namei.c | 45 +++++++++++++++-- fs/nfs/internal.h | 3 +- fs/nfs/nfs4proc.c | 4 +- fs/nfs/nfs4super.c | 9 ++-- fs/nfs/nfs4xdr.c | 21 ++++++-- fs/nfs/super.c | 7 ++- fs/nfsd/nfs4state.c | 46 ++++++++++++++++- fs/proc_namespace.c | 1 + include/linux/fs.h | 8 +++ include/uapi/asm-generic/fcntl.h | 11 ++++ include/uapi/linux/fs.h | 1 + 29 files changed, 364 insertions(+), 130 deletions(-) -- 1.8.1.5

4 14

Re: [PATCH 1/2] wined3d: Handle texture types via ps/vs_compile_args
by Henri Verbeet 10 Apr '13

10 Apr '13

On 10 April 2013 13:39, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This patch only changes the way the texture types are fed into the > shader generation code. Generating the proper shader code (hardcoded > values instead of relying on the dummy textures) is a task I've left for > Matteo, who worked on this problem before. > > This patch originates from my work-in-progress command stream work. It > is one of the few that I think makes sense on its own. > --- Why do you need the sampler type for anything other than SM1 pixel shaders? Also, while in principle I'm all for not accessing wined3d_state from the shader backend, I don't think there should be anything in the command stream patches that would prevent that.

4 4

Re: [PATCH 1/8] wined3d: Remove useless glClearxxx calls.
by Henri Verbeet 10 Apr '13

10 Apr '13

On 10 April 2013 01:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > - /* Clear the screen */ > - gl_info->gl_ops.gl.p_glClearColor(1.0f, 0.0f, 0.0f, 0.0f); > - checkGLcall("glClearColor"); > - gl_info->gl_ops.gl.p_glClearIndex(0); > - gl_info->gl_ops.gl.p_glClearDepth(1); > - gl_info->gl_ops.gl.p_glClearStencil(0xffff); > - > - checkGLcall("glClear"); > And actually potentially harmful, if the new context is created after an existing one already did drawing on the same drawable. (Although that's fairly unlikely, especially with "AlwaysOffscreen" enabled.)

2 1

Re: tools: add ProductId to the Windows NT Current Version block
by Alexandre Julliard 10 Apr '13

10 Apr '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -3019,6 +3019,7 @@ HKLM,%CurrentVersionNT%,"CSDVersion",2,"Service Pack 3" > HKLM,%CurrentVersionNT%,"CurrentBuildNumber",2,"2600" > HKLM,%CurrentVersionNT%,"CurrentType",2,"Uniprocessor Free" > HKLM,%CurrentVersionNT%,"ProductName",2,"Microsoft Windows XP" > +HKLM,%CurrentVersionNT%,"ProductId",,"12345-oem-0000001-54321" I'm not sure it's a good idea to hardcode this. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: kernel32: Add a test for threads state when a process is being terminated. Take 2.
by Alexandre Julliard 10 Apr '13

10 Apr '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This test demonstrates the problem reported in the bug 33331. > > This version of the patch moves the ExitProcess test into a child process. It still won't report failures properly though. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [3/13] wineconsole and kernel32: set GetLargestConsoleWindowSize based on screen resolution
by Nikolay Sivov 10 Apr '13

10 Apr '13

On Mon, Apr 8, 2013 at 3:53 PM, Hugh McMaster < hugh.mcmaster(a)masterindexing.com> wrote: > This file recreates most, if not all, of the source found in > dlls/advapi32/registry.c in dlls/kernel32. It provides registry > functionality. > > Tested on Linux Mint 14 and Mac OS X 10.8 (Mountain Lion). > > --- > dlls/kernel32/advapi32_registry.c | 2928 > +++++++++++++++++++++++++++++++++++++ > 1 file changed, 2928 insertions(+) > create mode 100644 dlls/kernel32/advapi32_registry.c > > > Why do you need this? (not to mention that you can't just duplicate it like that)

3 8

Google Summer of code
by Liu Tuo 09 Apr '13

09 Apr '13

Hi, I am Liu Tuo from National University of Singapore, a second year student in computer science. I am interested in joining this year's google summer of code in wine project. Have a nice day, Liu Tuo

1 0

Google summer of code
by Tabibel Sami 09 Apr '13

09 Apr '13

Hi, I am sami, i am student at limoges university in france am doing a master degree: Cryptology and information security and am interesting to work on wine project this summer I like C programming. Regards

1 0

[AppDB] -more spam-
by Joerg Schiermeier 09 Apr '13

09 Apr '13

Hi list, again a spammer used the AppDB for his nasty activities: 1.) > Comment for 'Adobe Photoshop CS3 (10.0)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=6584#Comment-8… 2.) > Comment for 'ElsterFormular 12.0 (2010 + 2011)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=22570#Comment-… No. #2 is maintained by me, so I deleted the comment just some minutes ago. Is it possible, to mail to all maintainers to inform them about the actual mail food and to have an eye on their applications? If so please do it. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1