April 2013 - Wine-devel - list.winehq.org

Re: [PATCH 1/1] d3d8: Don't assert on invalid IDirect3DBaseTexture8 interfaces.
by Stefan Dösinger 15 Apr '13

15 Apr '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-04-14 16:53, schrieb Rico Schüller: > + if (iface->lpVtbl != (const IDirect3DBaseTexture8Vtbl > *)&Direct3DTexture8_Vtbl + && iface->lpVtbl != (const > IDirect3DBaseTexture8Vtbl *)&Direct3DCubeTexture8_Vtbl + > && iface->lpVtbl != (const IDirect3DBaseTexture8Vtbl > *)&Direct3DVolumeTexture8_Vtbl) + { + WARN("%p is not a > valid IDirect3DBaseTexture8 interface.\n", iface); + return > NULL; + } A test would be a good idea. Are you sure that the assert is the actual problem, and not some memory corruption that changes the vtable poiner? What does e.g. GetTexture do after a bogous SetTexture call? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRa7lTAAoJEN0/YqbEcdMwNjEP/RLeLk3+009+Cp2n5sWOUprn Z5ED8iL3RXRjsCJNU5Fi2JIkCcVRmdkkn2RTBN9Q9KEkUL0qjg6B7Admy5sWtMIk LDtYpjS6BeDIJm8e0D0HwGItv2ekxW37ggg9fsArcXUO/lKf2GrJmUiyAjQfzmT9 IDlewcLSzUiAdbzZ4WUZzkqIa9lQgDpZBAvOgvgqhY2suf+YpJi6oTMfgwzpiSyB L2mlXx4cb0/hYaPAdWZUbc9uHvsCQ5ZwE4EhIxWpMlZM8FENMN3Gc0vrpzWAXoBo XRifoh3n0VKaYyZ+Wi+zGRaFX40P4ouBUKuFcBdjEPq6Fhz46GEGY8KFf1MVZKwM 7pzkhv6yc8/GTr2q5wthhmnZxDLHIZNyVEoMU0AFB1M0V/k0sJQfXpCCA/6vql+g dgUtyPggMSefwT0lc/7S/UwQdvuRYyIcdVd47alDJyRfU5NOMx091IiqkKXm9nby nqGAfdO3GDQoOIXJpWD5E1UMPHt6AGXGsfypkuVTtTljvOx+U7S9ngBeFkjuor8+ VFwStSFGboPxAjfKqzubdFcPcp4t8E5/qqkXR+Nc2UBJV5XeC3Pg5GOZxBsDZvbz zU4btX6kgC1Si1vIkf+D8CyZgaoPSwiVgGfVkTaqYSqnO39JZ0SpjYlv7e4yuhfa jkXNYd+XevrLq435YYir =TVml -----END PGP SIGNATURE-----

2 3

GSoC '13 - Hello!
by Eric Zheng 15 Apr '13

15 Apr '13

Hello everyone, My name is Eric Zheng, I'm a junior in Computer Engineering at the University of Illinois Urbana-Champaign. I just wanted to introduce myself and state my interest in the "Xinput / Xbox 360 controller compatibility" project. I hope to be able to jump on IRC later in the week to speak with you all. Best, Eric Zheng

2 1

Re: zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung 15 Apr '13

15 Apr '13

--- On Sun, 14/4/13, Vincent Povirk <madewokherd(a)gmail.com> wrote: > Well, here's a simple thing you can > check: Does your zlib dll link to > _lseek or _lseeki64? The first one uses a 32-bit offset. > Wine's > implementation (http://source.winehq.org/source/dlls/msvcrt/file.c#L1090) > expands that to 64-bit and later truncates the file offset > to 32-bit. > For a file larger than 2 GB, that could account for the > large negative > value you're seeing. > > And since this would only matter in cases where zlib uses > lseek (the > first time through I guess it wouldn't, as it has to read > the whole > everything up to the offset you give at least once) and is > at least 2 > GB into the file, that might also explain why it doesn't > fail > initially. > > But without really digging into the zlib code, all I can do > it speculate. > > I should probably also check coapp's build of zlib > sometime. It is not a dll - as you suggested and I already wrote, due to past experience of other's packaging of slightly outdated, it is being built against a private *source* copy of the latest zlib. Also the bogus offset is not large negative but large (larger than 2^32) positive. Here is an example of the debug output under wine: --------------- set_filepos failed at 34307 returning 134127533721091 Re-opening to re-try Retry successful set_filepos failed at 96919 returning 146686018157207 Re-opening to re-try Retry successful set_filepos failed at 128254 returning 12103217968382 Re-opening to re-try Retry successful ... --------------- This is generated by this code snipplet which is called inside a loop, all wrapped in the c++ class: --------------- off_t offset = gzseek(gzvcf_in, filepos, SEEK_SET); if (offset != filepos) { //implicitly converted to off_t by template streamoff() LOG.printLOG("set_filepos failed at " + LOG.streampos2str(filepos) + " returning " + LOG.off_t2str(offset) + "\n"); LOG.printLOG("Re-opening to re-try\n"); close(); open(); off_t offset1 = gzseek(gzvcf_in, filepos, SEEK_SET); if (offset1 == filepos) LOG.printLOG("Retry successful\n"); else LOG.error("Retry failed\n"); // this also aborts } ------------------- This code runs silently on linux i.e. the "if (offset != filepos)" condition is not triggered.

2 2

request.h: size of unnamed array is negative
by Hugh McMaster 14 Apr '13

14 Apr '13

I've been adding a new handler to Wine's server. Unfortunately, I've run into a problem with C_ASSERT that I can't seem to resolve. In server/request.h, I've added the following code: C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_request, spi_workarea) == 16 ); C_ASSERT( sizeof(struct get_desktop_workarea_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_reply, screen_x) == 4 ); C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_reply, screen_y) == 4 ); C_ASSERT( sizeof(struct get_desktop_workarea_reply) == 8 ); But the compiler ends with output errors, as in the following: In file included from request.c:69:0: request.h:1527:1: error: size of unnamed array is negative request.h:1528:1: error: size of unnamed array is negative request.h:1529:1: error: size of unnamed array is negative request.h:1530:1: error: size of unnamed array is negative request.h:1531:1: error: size of unnamed array is negative Each error represents the C_ASSERT code listed above. I'm probably missing something obvious here. Can someone please offer any advice on resolving these errors? Thank you.

3 8

Re: zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung 14 Apr '13

14 Apr '13

------------------------------ On Sun, Apr 14, 2013 22:34 BST Vincent Povirk wrote: >> considering how old zlib is and the vast number of windows application which uses zlib > >Given how many people duplicate the effort to package zlib, the fact >that they're rarely updated, and the sort of problems gnulib exists to >work around, it would not surprise me if your particular zlib binary >is broken somehow. got nobody else to blame - because of exactly the issue you outlined encountered in the past, i am building the application with a private copy of the source of zlib 1.2.7.

2 1

zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung 14 Apr '13

14 Apr '13

I am porting an application which uses zlib's gzseek quite extensively to do pseudo- random access of the content of large gz'ed files, in the same manner of some's use of posix's lseek. On small test data, it works correctly on wine. (identical result as linux). On production data - a large 9GB file - it gives gabbage. I thought it is 32-bit file access problem, until I check the return value of gzseek explicitly. It is supposed to return the same value as input on success, -1 on error. On wine, it does neither, *occasionally*! I found that a first gzseek works correctly, then a 2nd fails. It does not fails with a -1, but fails with a large bogus value. Currently I am working around this strange behavior by closing the file and re-opening until it gets a correct offset. The large bogus value increases gradually and wrap around about 8-10 such repeated set of gzseek calls. Anybody has any suggestion why gzseek would behave badly *intermittently* in wine? I assume it works correctly in windows - hardly to think that it doesn't work, considering how old zlib is and the vast number of windows application which uses zlib. On a separate note, the application seems extraordinary slow in wine (again I haven't tried in windows..) - even when it works correctly without the work-around, it is hundreds of times slower in wine than in linux.

2 1

Re: [PATCH 1/4] wined3d: 1x1 texures have a power of two size
by Henri Verbeet 14 Apr '13

14 Apr '13

On 13 April 2013 16:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -965,8 +965,6 @@ static HRESULT texture_init(struct wined3d_texture *texture, UINT width, UINT he > && !(format->id == WINED3DFMT_P8_UINT && gl_info->supported[EXT_PALETTED_TEXTURE] > && wined3d_settings.rendertargetlock_mode == RTL_READTEX)) > { > - if (width != 1 || height != 1) > - texture->flags &= ~WINED3D_TEXTURE_POW2_MAT_IDENT; > > texture->pow2_matrix[0] = (float)width; > texture->pow2_matrix[5] = (float)height; I think we'll want the empty line here gone as well, but otherwise the series looks ok.

1 0

Google Summer of Code
by Liu Tuo 13 Apr '13

13 Apr '13

Hi, How much knowledge should I have before applying for the wine project of implementing missing D3DX9 apis? Currently I have learnt opengl; I am familiar with the opengl and glut functions and the concepts behind these functions. Thanks for your help, Liu Tuo

1 0

Re: gdiplus: fix a clipping problem
by Vincent Povirk 12 Apr '13

12 Apr '13

This looks wrong. scaled_rect is an internally calculated value, not something supplied by the user, and comparing it to 0.5 doesn't make sense, especially since by this point the width was altered to add padding.

1 0

GSoC 2013 proposal: Implement XPath from scratch
by John Chadwick 12 Apr '13

12 Apr '13

Hello, I am a student of computer science interested in entering Wine development via GSoC 2013. Upon looking at the various suggested proposals, the project of reimplementing XPath without libxml2 looked particularly interesting. I am familiar with the C language, W3C DOM and XPath, and I believe this is something I could do. I have a few questions I'd be interested in seeing answered: * One of the 'important things to keep in mind' is that "changes should be incremental, with a fallback to libxml2 until new processor is fully functional." Does this mean at compile time, or at runtime, when the evaluator recognizes unimplemented features in an expression, or something else entirely? * Is only MSXML 3.0 supported? It appears to be the only version implemented in the Wine source tree. * What should I aim at doing first? Because what I'd be working on is a library, I would probably need some application to test features with (test cases aside.) Should I be using an existing program, or writing a new one? Thanks, John Chadwick

3 2