January 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR1788: twain_32: Handle realloc failure in twain_add_onedriver (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1788

1 0

Re: [PATCH v2 0/2] MR1795: wldap32: Free resource in error case and return error code (Coverity) - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1795

1 0

Re: [PATCH v2 0/1] MR1782: mshtml: Handle memory allocation failure in set_statustext. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1782

1 0

Re: [PATCH v2 0/1] MR1785: msi: Fix memory leak on realloc failure in search_directory (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1785

1 0

Re: [PATCH v2 0/1] MR1784: msi: Fix memory leak on realloc failure in msi_get_window_text (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1784

1 0

Re: [PATCH v2 0/1] MR1783: msi: Fix memory leak on realloc failure in create_diff_row_query (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1783

1 0

Re: [PATCH v2 0/1] MR1790: winspool: Improve the grammar of a comment in get_servername_from_name. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1790

1 0

[PATCH v2 0/1] MR1255: gitlab: Run win64 tests instead of wow64.
by Rémi Bernon 25 Jan '23

25 Jan '23

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1241. -- v2: gitlab: Run dinput 64-bit tests in a dedicated job. https://gitlab.winehq.org/wine/wine/-/merge_requests/1255

3 8

[PATCH v8 0/5] MR1588: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) 25 Jan '23

25 Jan '23

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number or at least something like "Not Specified" and not NULL. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- v8: windows.system.profile.systemmanufacturers: Implement ISmbiosInformationStatics_get_SerialNumber. windows.system.profile.systemmanufacturers/tests: Add ISmbiosInformationStatics_get_SerialNumber tests. windows.system.profile.systemmanufacturers: Stub ISmbiosInformationStatics interface. windows.system.profile.systemmanufacturers: Add stub DLL. include: Add windows.system.profile.systemmanufacturers.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

3 7

[PATCH 0/1] MR2023: dplayx/tests: Skip tests when the dll is missing.
by Hans Leidekker (＠hans) 25 Jan '23

25 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2023

3 2