October 2023 - Wine-gitlab - list.winehq.org

[PATCH v2 0/1] MR381: vkd3d-shader/tpf: Handle "COLOR" semantic the same way as "sv_target" in the parser.
by Nikolay Sivov (＠nsivov) 05 Oct '23

05 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/tpf: Return usage for all known semantic names. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/381

2 4

[PATCH 0/4] MR4020: Add tests and implementation of FILE_{RENAME,LINK}_IGNORE_READONLY_ATTRIBUTE
by Joel Holdsworth (＠jhol) 05 Oct '23

05 Oct '23

* Add tests for `FILE_RENAME_IGNORE_READONLY_ATTRIBUTE` and `FILE_LINK_IGNORE_READONLY_ATTRIBUTE`. * Disallow deletion of read-only files in `File{Rename,Link}Information{,Ex}`. * Added exception when `FILE_{RENAME,LINK}_IGNORE_READONLY_ATTRIBUTE` is specified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4020

2 4

[PATCH v4 0/1] MR3967: mpr: WNetGetUniversalNameA() and WNetGetUniversalNameW() implemented
by Alexey Alyaev (＠aalyaev) 05 Oct '23

05 Oct '23

- Implemented WNetGetUniversalName*() functions to correctly return universal/remote info levels -- v4: mpr: WNetGetUniversalNameA() and WNetGetUniversalNameW() implemented https://gitlab.winehq.org/wine/wine/-/merge_requests/3967

3 3

Re: [PATCH v6 0/1] MR3966: mpr: WNetAddConnection*() and WNetCancelConnection*() always return success
by Alexey Alyaev (＠aalyaev) 05 Oct '23

05 Oct '23

On Thu Oct 5 09:29:00 2023 +0000, Zebediah Figura wrote: > I don't think we want this kind of hack in Wine. > > Allowing for manual configuration outside of wine. > What does this mean? Well, as it stands now, if we have an application that relies on wnet API to connect/disconnect remote disks, the application will fail no matter what, as WNetAddConnection() and WNetCancelConnection*() will error out. (#) If we then go to ~/.wine/dosdevices and setup a new drive sym-linked to some remote FS mounted in ~/.wine/dosdevices/unc/*, we still cannot get around the failures in WNet* api. While, this sort of work-around is not perfect, in a way it is a success-stub rather than a fail-stub, and at least it allows the application to proceed onto the access phase (read/write/...), and either work (if manual step (#) was completed), or fail unable to do i/o. It's understood that, the proper way would be to utilize the WNet provider tables and to actually implement a provider that will always succeed on connecting/disconnecting a network drive. But the latter is a much bigger change, which may be worth it, had there been a need for something more than just a SUCCESS-STUB. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3966#note_47668

1 0

[PATCH 0/1] MR384: Draft: vkd3d: Introduce a thread-local descriptor object cache.
by Conor McCarthy (＠cmccarthy) 05 Oct '23

05 Oct '23

A TLS index is allocated for each device object. We could use a global TLS, but that would share caches for all devices. I'm not sure if that's a problem. One index per device means freed indices must be recycled, which requires a global mutex, but a global TLS index would also need a global mutex. This currently leaks cache memory when a device is freed. To fix this, allocations must be tracked. A global cache is more difficult to free, which is not normally an issue, but it is when using valgrind. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384

4 6

[PATCH v3 0/8] MR3993: windows.media.mediacontrol: Implement some ISystemMediaTransportControls properties.
by Mohamad Al-Jaf (＠maljaf) 05 Oct '23

05 Oct '23

Called by Roon. I have more patches for this, but I split them up for easier review. -- v3: windows.media.mediacontrol: Implement some ISystemMediaTransportControls properties. windows.media.mediacontrol/tests: Add some ISystemMediaTransportControls properties tests. windows.media.mediacontrol: Implement ISystemMediaTransportControlsInterop::GetForWindow(). windows.media.mediacontrol/tests: Add ISystemMediaTransportControlsInterop::GetForWindow() tests. windows.media.mediacontrol: Add ISystemMediaTransportControlsInterop stub interface. include: Add systemmediatransportcontrolsinterop.idl file. windows.media.mediacontrol: Add stub DLL. include: Add ISystemMediaTransportControls interface definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/3993

3 12

[PATCH v2 0/1] MR3999: Msdasql header
by Alistair Leslie-Hughes (＠alesliehughes) 05 Oct '23

05 Oct '23

-- v2: include: Add some DBCOLUMN defines https://gitlab.winehq.org/wine/wine/-/merge_requests/3999

2 1

[PATCH 0/2] MR4018: winemac.drv: Use @autoreleasepool instead of NSAutoreleasePool.
by Brendan Shanks (＠bshanks) 05 Oct '23

05 Oct '23

`@autoreleasepool` is the newer (although still 10+ years old) way of creating ObjC autorelease pools. It allows simpler control flow, is possibly more efficient, and is a prerequisite to adopting ARC (no immediate plans for that, but it could happen in the future). I didn't add an indentation level for `@autoreleasepool` blocks covering a whole function (the common case by far), but did indent smaller blocks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4018

2 2

Re: [PATCH 0/1] MR202: server: Hold socket reference in sock_poll_event().
by Zebediah Figura (＠zfigura) 05 Oct '23

05 Oct '23

> I think I never encountered this issue in the wild, hit it back then when was making tests for something else, sent this and forgot about it too. I don't know for sure that I've hit this in the wild, but I've *definitely* hit that assertion before and been unable to track it down. And, well, no matter what happens, the server shouldn't crash, so this is definitely worth fixing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/202#note_47654

1 0

Re: [PATCH 0/1] MR202: server: Hold socket reference in sock_poll_event().
by Paul Gofman (＠gofman) 05 Oct '23

05 Oct '23

I think I never encountered this issue in the wild, hit it back then when was making tests for something else, sent this and forgot about it too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/202#note_47653

1 0