October 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR4230: shell32: Fix string size condition check (Coverity).
by Nikolay Sivov (＠nsivov) 31 Oct '23

31 Oct '23

The issue was introduced by 68fd74e7f9bdd2310aebeb59bc86754271cdc063. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4230

3 3

[PATCH v2 0/5] MR2781: mfplat: Optimize sample copy to d3d buffer.
by Paul Gofman (＠gofman) 31 Oct '23

31 Oct '23

This is ultimately a follow up for introducing d3d manager support in h264 decoder transform. The last patch avoids unneeded GPU to CPU copy when copying a memory sample to GPU sample (in particular, when sample copier is involved). There are a couple of things to fix on the way. Patch 1 fixes the crash which otherwise happens in the test introduced in patch 2 due to memory corruption. Flipping the image instead of using absolute pitch will break the test in patch 2. Patch 3 contradicts to what MS docs says [1] for MFCreate2DMediaBuffer, fBottomUp parameter: "If TRUE, the buffer's IMF2DBuffer::ContiguousCopyTo method copies the buffer into a bottom-up format.". That doesn't match the tests in patch 2. So far I see that fBottomUp parameter only affects what is returned from Lock2D as scanline0 and pitch. Thinking of it, the behaviour of ContiguousCopyFrom makes some sense to me as Lock2D (unlike Lock which converts to contiguous buffer) is not supposed to perform any copies and flips and return the underlying representation as is. And once scanline0 and pitch for that 2d buffer indicate it should be copied bottom up additionally flipping when converting from contiguous buffer wouldn't make much sense. Then, ContiguousCopyTo could flip it actually as the docs suggest, but the test seems to clearly show that it doesn't happen (there is a separate test for clarity showing that ContiguousCopyFrom / ContiguousCopyTo yields the same data). 1. https://learn.microsoft.com/en-us/windows/win32/api/mfapi/nf-mfapi-mfcreate… -- v2: mfplat/sample: Optimize copying to 2d buffer. mfplat/sample: Refactor sample_CopyToBuffer(). mfplat/buffer: Do not flip in memory_2d_buffer_ContiguousCopy{From|To}(). mfplat/tests: Add more tests for copying 2d buffers. mfplat/buffer: Use absolute pitch in memory_1d_2d_buffer_[Un]Lock(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2781

3 6

[PATCH 0/1] MR4217: dxgi/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 31 Oct '23

31 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4217

4 3

[PATCH 0/1] MR4216: dxgi: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 31 Oct '23

31 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4216

4 3

[PATCH 0/1] MR4215: ddraw/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 31 Oct '23

31 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4215

5 4

[PATCH 0/1] MR4214: ddraw: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 31 Oct '23

31 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4214

5 4

[PATCH 0/1] MR4213: d3d9/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 31 Oct '23

31 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4213

4 3

[PATCH v2 0/1] MR4212: d3d9: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 31 Oct '23

31 Oct '23

-- v2: d3d9: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4212

3 2

[PATCH 0/4] MR4239: mf/samplegrabber: Check shutdown state when setting the clock.
by Nikolay Sivov (＠nsivov) 31 Oct '23

31 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4239

2 4

[PATCH 0/1] MR4211: d3d8/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 31 Oct '23

31 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4211

4 3