October 2023 - Wine-gitlab - list.winehq.org

[PATCH v2 0/9] MR396: vkd3d-shader/hlsl: Support non-constant offset dereferences, v2, part 1.
by Francisco Casas (＠fcasas) 12 Oct '23

12 Oct '23

First part of the continuation of the implementation of non-constant offset dereferences (a.k.a. relative addressing) for SM4, now that we use vsir registers in tpf.c. As a quick recap: while parsing HLSL we are expressing derefs as paths, and then we are lowering these paths into a single offset node (which is closer to the bytecode) using the replace_deref_path_with_offset() pass, right before register allocation. This first part of the series splits this offset node into 2 parts: - A constant uint, which will be called hlsl_deref.offset_const. - A non-hlsl_ir_constant offset node that will only be present when we need relative addressing, that we will end up calling hlsl_deref.offset_rel. Both these fields will be analog to the ones used in vsir register indexes, vkd3d_shader_register_index.rel_addr and vkd3d_shader_register_index.offset respectively, which is something we need for the second part of this series. The following patches are in my [nonconst-offsets-8](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/noncon… branch, if something is not clear in this series, it may be worth skimming through them. Supersedes !229. -- v2: vkd3d-shader/tpf: Declare indexable temps. vkd3d-shader/hlsl: Mark vars that require non-constant dereferences. vkd3d-shader/hlsl: Rename hlsl_deref.offset to hlsl_deref.rel_offset. vkd3d-shader/hlsl: Absorb hlsl_ir_constant deref offsets into const_offset. vkd3d-shader/hlsl: Express deref->offset in whole registers. vkd3d-shader/hlsl: Split deref-offset into a node and a constant uint. vkd3d-shader/hlsl: Introduce hlsl_deref_is_lowered() helper. vkd3d-shader/hlsl: Clean-up instruction block for offset node creation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/396

2 16

[PATCH v2 0/2] MR4071: msvcrt/tests: Add tests for wcsdup.
by Alex Henrie (＠alexhenrie) 12 Oct '23

12 Oct '23

These tests are to resolve the concerns about relying on the tested behaviors, that were brought up at <https://gitlab.winehq.org/wine/wine/-/merge_requests/4060#note_48218>. -- v2: msvcrt/tests: Add tests for wcsdup. msvcrt/tests: Check errno after strdup(NULL). https://gitlab.winehq.org/wine/wine/-/merge_requests/4071

5 6

[PATCH v3 0/4] MR402: vkd3d-shader: Minor fixes to clangd warnings (clangd).
by Francisco Casas (＠fcasas) 12 Oct '23

12 Oct '23

Some fixes to valid clangd warnings, since I am using it as linter. Also, I am removing enum hlsl_error_level on 4/6, since it doesn't seem to be meant to be used anywhere after 3/6. -- v3: vkd3d-shader/d3dbc: Use D3DSIO_TEXKILL instead of VKD3D_SM1_OP_TEXKILL (clangd). vkd3d-shader/hlsl: Remove enum hlsl_error_level (clangd). vkd3d-shader/tpf: Avoid translations to D3DDECLUSAGE and back (clangd). vkd3d-shader: Remove unnecessary fallthroughs (clangd). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/402

4 6

[PATCH v2 0/2] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu 12 Oct '23

12 Oct '23

-- v2: mshtml: Return proper errors when navigating with no browser. mshtml: Set outer window to uninitialized page when document obj is released. https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

3 10

Re: [PATCH v44 0/7] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 12 Oct '23

12 Oct '23

The problem with implementing mspatchc for me, is that then tests must be written for that as well :sweat: Additionally it seems like a bad idea to implement an entire module just to generate data for tests for another module. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_48550

1 0

[PATCH 0/1] MR4084: user32/tests: Improve the GetWindowModuleFileName() checks.
by Francois Gouget (＠fgouget) 12 Oct '23

12 Oct '23

Check that NULL has no special meaning. Check GetLastError() for systray windows. Trace the module filename in case of unexpected success and enclose it in quotes in case there are leading or trailing spaces. Fix the filename buffer initialization. --- The buf2[0] = 0 line at the top of the patch was introduced in 914cb228685b but buf2 was not used after that. So clearly it is buf1 that should have been initialized there. That said I'm not sure initializing buf1 & buf2 is really necessary as they are only used in case of success. I guess the fear was that GetWindowModuleFileName() would sometimes return success without touching the buffer but I'm not convinced that fear is justified. Still I decided to be conservative and preserve the initializations. I'm fine with removing them though (maybe the buf2 case is a bit special). Finally this is meant to help figure out the reason for the failure decribed in bug 55777. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4084

4 3

[PATCH v4 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Alfred Agrell (＠Alcaro) 12 Oct '23

12 Oct '23

- Make it present some frames - Make it check that the frames are from the new device, instead of checking TerminateDevice count; fixes https://bugs.winehq.org/show_bug.cgi?id=55649 - ~~Make it check for and avoid some absurd crash on Windows~~ ~~I tried everything I could think of, but Windows absolutely refuses to present a frame after changing the D3D device, instead choosing to return various absurd errors (segfaults, deadlocks, out of memory, etc). I suspect the VMR9 is haunted.~~ edit: Works on Windows now -- v4: quartz/tests: Improve VMR9 ChangeD3DDevice test. https://gitlab.winehq.org/wine/wine/-/merge_requests/3970

2 1

[PATCH 0/1] MR4083: localspl: Truncate output file when printing to file.
by Piotr Caban (＠piotr) 12 Oct '23

12 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4083

3 2

Re: [PATCH v44 0/7] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Conor McCarthy (＠cmccarthy) 12 Oct '23

12 Oct '23

Looks like I no longer have the code I used to make test data, but because it generated the minimum amount required to test the features implemented at the time, I think it would not be much help with PE files. Yes, implementing mspatchc may allow proper testing, and it wouldn't need to have especially fast or high-ratio compression, but even then it's not trivial to do. I have my hands full at the moment, but I may look at doing this later if nobody else has. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_48536

1 0

[PATCH 0/1] MR405: vkd3d-utils: Check for a NULL 'blob' pointer in D3DCreateBlob().
by Henri Verbeet (＠hverbeet) 12 Oct '23

12 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/405

2 1