November 2023 - Wine-gitlab

Re: [PATCH v11 0/2] MR4310: ntdll: Tweak the binary representation of SRWLOCK.
by Yuxuan Shui (＠yshui) 06 Nov '23

06 Nov '23

make `owners` unsigned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4310#note_51138

1 0

[PATCH v10 0/2] MR4310: ntdll: Tweak the binary representation of SRWLOCK.
by Yuxuan Shui (＠yshui) 06 Nov '23

06 Nov '23

There are applications that uses SRWLOCK in an invalid way and then checks its binary representation. ~~Specifically they releases an unlocked SRWLOCK then check its bit pattern is all-ones.~~ Tweak the representation a bit so they are happy. -- v10: ntdll: Tweak the binary representation of SRWLOCK. winnt: Add InterlockedExchangeAdd16. https://gitlab.winehq.org/wine/wine/-/merge_requests/4310

2 2

Re: [PATCH v9 0/2] MR4310: ntdll: Tweak the binary representation of SRWLOCK.
by Yuxuan Shui (＠yshui) 06 Nov '23

06 Nov '23

fixed prototype of `_InterlockedExchangeAdd16` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4310#note_51135

1 0

[PATCH v8 0/2] MR4310: ntdll: Tweak the binary representation of SRWLOCK.
by Yuxuan Shui (＠yshui) 06 Nov '23

06 Nov '23

There are applications that uses SRWLOCK in an invalid way and then checks its binary representation. ~~Specifically they releases an unlocked SRWLOCK then check its bit pattern is all-ones.~~ Tweak the representation a bit so they are happy. -- v8: ntdll: Tweak the binary representation of SRWLOCK. https://gitlab.winehq.org/wine/wine/-/merge_requests/4310

2 3

[PATCH v3 0/6] MR443: tests: Add some tests for effects groups syntax.
by Nikolay Sivov (＠nsivov) 06 Nov '23

06 Nov '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader/tpf: Initial support for writing fx_4_0/fx_4_1 binaries. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443

3 12

[PATCH v4 0/1] MR4310: ntdll: Tweak the binary representation of SRWLOCK.
by Yuxuan Shui (＠yshui) 06 Nov '23

06 Nov '23

There are applications that uses SRWLOCK in an invalid way and then checks its binary representation. ~~Specifically they releases an unlocked SRWLOCK then check its bit pattern is all-ones.~~ Tweak the representation a bit so they are happy. -- v4: ntdll: Tweak the binary representation of SRWLOCK. https://gitlab.winehq.org/wine/wine/-/merge_requests/4310

3 3

[PATCH v4 0/2] MR4232: ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr().
by Paul Gofman (＠gofman) 06 Nov '23

06 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55842 The bug blames commit 059094c1c18ddc33b04eac53a72fd0eb7510be94 ("ntdll: Define heap block's BLOCK_FLAG_LFH as 0x80.") but actually before the blamed commit that worked essentially by chance. The problem the patch is solving is that RtlValidateHeap() currently always fails for LFH blocks allocated from large block memory (vs subheap blocks). That can happen for large enough LFH block sizes. In case of the regressed game the user of RtlValidateHeap() is msvcr80.msvcrt_heap_free() which uses HeapValidate() to guess the heap used to allocate the pointer to free. I am attaching a standalone test program which can be used to reproduce the problem without the patch. [test_lfh_validate.c](/uploads/006b04a9a00ffb7949956b66a275d5cf/test_lfh_validate.c) -- v4: ntdll: Fix pending free block validation in heap_validate() for LFH blocks. ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4232

3 4

[PATCH v3 0/1] MR4310: ntdll: Tweak the binary representation of SRWLOCK.
by Yuxuan Shui (＠yshui) 06 Nov '23

06 Nov '23

There are applications that uses SRWLOCK in an invalid way and then checks its binary representation. ~~Specifically they releases an unlocked SRWLOCK then check its bit pattern is all-ones.~~ Tweak the representation a bit so they are happy. -- v3: ntdll: Tweak the binary representation of SRWLOCK. https://gitlab.winehq.org/wine/wine/-/merge_requests/4310

3 6

[PATCH 0/9] MR4311: Draft: Ucrt
by Bartosz Kosiorek (＠gang65) 06 Nov '23

06 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4311

3 12

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) 06 Nov '23

06 Nov '23

On Mon Nov 6 14:46:29 2023 +0000, Yuxuan Shui wrote: > demonstrate the leak? or demonstrate the race condition? > in the first case, our unit test already does. in the second case, i > don't see how that's useful? the race condition is pretty clearly there, > simply based on the fact that the callback might be running when you try > to cancel it. https://gist.github.com/yshui/2f1c5c8ce9d80e9eef1db4eab51344d0 this demonstrate the `CloseThreadpool` vs running callback race. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_51113

1 0