November 2023 - Wine-gitlab

Re: [PATCH v3 0/2] MR3915: ddraw/tests: Test WS_EX_TOPMOST restoration. - approved
by Zebediah Figura (＠zfigura) 02 Nov '23

02 Nov '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3915

1 0

[PATCH 0/1] MR4060: winegstreamer: Remove redundant null check before wcsdup in object_context_create.
by Alex Henrie (＠alexhenrie) 02 Nov '23

02 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4060

5 6

[PATCH 0/1] MR4164: qcap: Ensure unixlib function tables and enum stay in sync.
by Brendan Shanks (＠bshanks) 02 Nov '23

02 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4164

3 2

[PATCH 0/1] MR4122: quartz: Use debugstr_fourcc instead of debugstr_an.
by Alex Henrie (＠alexhenrie) 02 Nov '23

02 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4122

4 4

[PATCH 0/1] MR438: vkd3d-shader/tpf: Don't pass 0x4 as mask for vec4 constant src registers.
by Francisco Casas (＠fcasas) 02 Nov '23

02 Nov '23

Evan Tang reported that new fixmes appeared on the shader_runner when running some of his tests after f50d0ae2cbc5ee2a26fedd7b8aac2def62decd6c. vkd3d:652593:fixme:shader_sm4_read_src_param Unhandled mask 0x4. The change to blame seems to be this added line in sm4_src_from_constant_value(). + src->swizzle = VKD3D_SHADER_NO_SWIZZLE; On tpf binaries the last 12 bytes of each src register in an instruction specify the swizzle, and there are 5 possible combinations: Dimension NONE -------- 00 Dimension SCALAR -------- 01 Dimension VEC4, with a 4 bit writemask: ---- xxxx 00 01 Dimension VEC4, with an 8 bit swizzle: xx xx xx xx 01 01 Dimension VEC4, with a 2bit scalar dimension number: ------ xx 10 01 So far, we have only seen src registers use 4 bit writemasks in a single case: for vec4 constants, and it is always zero. So we expect this: ---- 0000 00 01 Now, I probably wanted to initialize src->swizzle to zero when writing constants, but VKD3D_SHADER_NO_SWIZZLE is not zero, it is actually the default swizzle: 11 10 01 00 And the last 4 bits (0x4) get written in the mask part, which causes the reader to complain. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/438

3 2

[PATCH 0/4] MR437: tests: Add some tests for using technique blocks when compiling for pixel/vertex profiles.
by Nikolay Sivov (＠nsivov) 02 Nov '23

02 Nov '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/437

5 7

[PATCH 0/1] MR440: vkd3d-shader/dxil: Allow empty struct types.
by Conor McCarthy (＠cmccarthy) 02 Nov '23

02 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/440

4 3

[PATCH 0/1] MR433: vkd3d-shader/dxil: Always apply the signature element start column to used_mask.
by Conor McCarthy (＠cmccarthy) 02 Nov '23

02 Nov '23

The used_mask value loaded from an additional tag/value pair is relative to the start column. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/433

4 5

[PATCH v6 0/8] MR432: ir: Validate TEMP registers.
by Giovanni Mascellani (＠giomasce) 02 Nov '23

02 Nov '23

-- v6: vkd3d-shader/ir: Validate the index of a TEMP register. vkd3d-shader/ir: Validate the DCL_TEMPS instruction. vkd3d-shader/ir: Validate the register index count. vkd3d-shader/ir: Validate the register dimension. vkd3d-shader/ir: Validate the register data type. vkd3d-shader/ir: Validate the register precision. vkd3d-shader/dxil: Use vsir_register_init() to initialize registers. vkd3d-shader: Deduplicate profile version comparison functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/432

3 9

[PATCH v5 0/2] MR424: tests: Introduce a stress tester for vkd3d-shader.
by Giovanni Mascellani (＠giomasce) 02 Nov '23

02 Nov '23

-- v5: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/424

3 4