November 2023 - Wine-gitlab

[PATCH 0/1] MR4414: server: Fully initialize pe mapping struct to avoid uninitialized memory when...
by Fabian Maurer (＠DarkShadow44) 28 Nov '23

28 Nov '23

When running wineserver under valgrind there is a bunch of uninitialised bytes warnings when sending the req_get_mapping_info reply. This warning can easily be reproduced by running `valgrind wineserver -f` and then `winecfg`. Tested using self compiled wine. Reason is the `pe_image_info_t` struct having bitfields: ``` unsigned char contains_code : 1; unsigned char wine_builtin : 1; unsigned char wine_fakedll : 1; ``` The last 5 bits are never initialized. This MR fixes this by zeroing the entire struct before it is filled. I hope "issues" like this are allowed to be fixed so valgrind has less false positives. Valgrind message for reference: ``` ==628662== 716 errors in context 3 of 3: ==628662== Syscall param writev(vector[1]) points to uninitialised byte(s) ==628662== at 0x49C3A87: writev (writev.c:26) ==628662== by 0x14C2F3: send_reply (request.c:268) ==628662== by 0x14C50F: call_req_handler (request.c:316) ==628662== by 0x14C5D2: read_request (request.c:339) ==628662== by 0x158F52: thread_poll_event (thread.c:388) ==628662== by 0x120FC9: fd_poll_event (fd.c:505) ==628662== by 0x1212A6: main_loop_epoll (fd.c:599) ==628662== by 0x121882: main_loop (fd.c:955) ==628662== by 0x12CBE0: main (main.c:238) ==628662== Address 0x53ec56e is 62 bytes inside a block of size 88 alloc'd ==628662== at 0x48416D4: malloc (vg_replace_malloc.c:431) ==628662== by 0x1348D0: mem_alloc (object.c:119) ==628662== by 0x14BEB9: set_reply_data_size (request.c:160) ==628662== by 0x1301C1: req_get_mapping_info (mapping.c:1291) ==628662== by 0x14C494: call_req_handler (request.c:305) ==628662== by 0x14C5D2: read_request (request.c:339) ==628662== by 0x158F52: thread_poll_event (thread.c:388) ==628662== by 0x120FC9: fd_poll_event (fd.c:505) ==628662== by 0x1212A6: main_loop_epoll (fd.c:599) ==628662== by 0x121882: main_loop (fd.c:955) ==628662== by 0x12CBE0: main (main.c:238) ==628662== Uninitialised value was created by a client request ==628662== at 0x134873: mark_block_uninitialized (object.c:110) ==628662== by 0x1348EA: mem_alloc (object.c:120) ==628662== by 0x134B87: alloc_object (object.c:199) ==628662== by 0x134F92: create_named_object (object.c:337) ==628662== by 0x12F12B: create_mapping (mapping.c:939) ==628662== by 0x12FFE9: req_create_mapping (mapping.c:1250) ==628662== by 0x14C494: call_req_handler (request.c:305) ==628662== by 0x14C5D2: read_request (request.c:339) ==628662== by 0x158F52: thread_poll_event (thread.c:388) ==628662== by 0x120FC9: fd_poll_event (fd.c:505) ==628662== by 0x1212A6: main_loop_epoll (fd.c:599) ==628662== by 0x121882: main_loop (fd.c:955) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4414

3 4

[PATCH v2 0/3] MR4504: cmd: fix for bug 55401
by Dmitry Sokolov (＠DmitrySokolov) 28 Nov '23

28 Nov '23

Visual Studio's native tool command prompt uses rare for loop variables: %%1, %%2. This test covers this case. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55401 -- v2: * cmd: added support of FOR loop's rare var names (%%1), fixed expansion of outer var loop name inside inner loop cmd: added support of for loop's rare var names (%%1), fixed expansion of outer var loop name inside inner loop cmd: added test for rare for loop vars https://gitlab.winehq.org/wine/wine/-/merge_requests/4504

3 8

[PATCH v3 0/1] MR4523: ntdll: RtlFindExportedRoutine returns NULL on forwarded function.
by eric pouech (＠epo) 28 Nov '23

28 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v3: ntdll: RtlFindExportedRoutine returns NULL on forwarded entries. https://gitlab.winehq.org/wine/wine/-/merge_requests/4523

3 3

[PATCH v3 0/2] MR4520: Don't let GUI's app write to console.
by eric pouech (＠epo) 28 Nov '23

28 Nov '23

-- v3: uninstall: No longer use console/file output APIs. winecfg: Output with MESSAGE. https://gitlab.winehq.org/wine/wine/-/merge_requests/4520

2 3

[PATCH v2 0/2] MR4520: Don't let GUI's app write to console.
by eric pouech (＠epo) 28 Nov '23

28 Nov '23

-- v2: uninstall: No longer use console/file output APIs. winecfg: Output with MESSAGE. https://gitlab.winehq.org/wine/wine/-/merge_requests/4520

2 2

[PATCH 0/1] MR4529: comdlg32/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 28 Nov '23

28 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4529

3 2

[PATCH v5 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.
by Conor McCarthy (＠cmccarthy) 28 Nov '23

28 Nov '23

-- v5: vkd3d-shader/dxil: Apply metadata attachments to instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

2 2

[PATCH v4 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.
by Conor McCarthy (＠cmccarthy) 28 Nov '23

28 Nov '23

-- v4: vkd3d-shader/dxil: Apply metadata attachments to instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

2 3

Re: [PATCH v2 0/9] MR4533: winex11: Detach / attach vulkan window surfaces as needed.
by Rémi Bernon 28 Nov '23

28 Nov '23

v2: Added the change to put detached surfaces offscreen with XComposite. Call `detach_client_window` directly in `attach_client_window` if client window needs to be swapped. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4533#note_54102

1 0

[PATCH v3 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.
by Conor McCarthy (＠cmccarthy) 28 Nov '23

28 Nov '23

-- v3: vkd3d-shader/dxil: Apply metadata attachments to instructions. vkd3d-shader/dxil: Implement DX intrinsic Unary. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

2 2