February 2023 - Wine-gitlab

Re: [PATCH v4 0/1] MR88: vkd3d-shader/hlsl: Support lit() intrinsic. - approved
by Alexandre Julliard (＠julliard) 21 Feb '23

21 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/88

1 0

[PATCH 0/11] MR103: DXBC handling API
by Henri Verbeet (＠hverbeet) 21 Feb '23

21 Feb '23

Public API for parsing and serialising DXBC blobs. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/103

3 14

[PATCH v2 0/4] MR2248: uiautomationcore: Implement some IUIAutomation property helper methods.
by Connor McAdams (＠cmcadams) 21 Feb '23

21 Feb '23

-- v2: uiautomationcore: Implement IUIAutomationElement::get_CurrentBoundingRectangle. uiautomationcore: Implement IUIAutomationElement::get_CurrentName. uiautomationcore: Implement IUIAutomationElement::get_CurrentControlType. https://gitlab.winehq.org/wine/wine/-/merge_requests/2248

3 7

[PATCH v3 0/3] MR101: vkd3d-shader/hlsl: Improvements to builtin typenames handling.
by Nikolay Sivov (＠nsivov) 21 Feb '23

21 Feb '23

-- v3: vkd3d-shader/hlsl: Support case-insensitive lookup for builtin 'float' type. vkd3d-shader/hlsl: Use unsigned type for the 'dword' alias. vkd3d-shader/hlsl: Support case-insensitive lookup for builtin 'dword' type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/101

3 5

[PATCH v2 0/3] MR2242: win32u: Do not set last error in wait_message() for zero count.
by Paul Gofman (＠gofman) 21 Feb '23

21 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54405 Also fixes Assassin Creed hanging on start (for a similar reason: it doesn't expect a spurious -1 last error). There is already a fix attempt sent by Ivan Chikish in !2067 (https://gitlab.winehq.org/wine/wine/-/merge_requests/2067) But I suppose it may be fixed simpler like in this patch. wait_message() with zero count is only called from NtUserPeekMessage(). I think even if for some reason driver's MsgWaitForMultipleObjectsEx returns a real error code we still don't want to set last error here when called from PeekMessage(). -- v2: wineandroid.drv: Check for zero count in _MsgWaitForMultipleObjectsEx if events are present. winemac.drv: Check for zero count in _MsgWaitForMultipleObjectsEx if events are present. winex11.drv: Check for zero count in _MsgWaitForMultipleObjectsEx if events are present. https://gitlab.winehq.org/wine/wine/-/merge_requests/2242

4 10

[PATCH 0/19] MR2250: winscard: Implementation on top of libpcsclite.
by Hans Leidekker (＠hans) 21 Feb '23

21 Feb '23

-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/2250

3 6

[PATCH v3 0/10] MR2217: Separately store the internal pixel format set by WGL_WINE_pixel_format_passthrough.
by Zebediah Figura (＠zfigura) 21 Feb '23

21 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51848 SPORE creates a swapchain on a window, then destroys it, then creates a different swapchain on the same window and uses it for the rest of its lifetime. The swapchains have different GLX visuals (the details are unimportant). The effect is that the second swapchain sees the pixel format set by the first swapchain, through GetPixelFormat(), and therefore needs to set and then restore the new pixel format on every present. This results in recreating the GLX drawable twice per frame, which is extremely expensive. This patch series changes WGL_WINE_pixel_format_passthrough to only set an "internal" pixel format. The real pixel format will still be set as it is now, but GetPixelFormat() will always return 0, signalling to wined3d that the application has not set the pixel format, and therefore there is no need to restore it. As the tests show, this change also matches Windows, which does not report that a pixel format has been set after presenting a Direct3D swapchain. This is a large series by patch count, but I fear that splitting it into two parts would make it difficult to grasp the entire picture, and purpose of the earlier patches. It also contains six patches which are simply repetitions across the three user drivers, which should ease the burden of review somewhat. -- v3: wineandroid: Separately store the internal pixel format set by WGL_WINE_pixel_format_passthrough. winemac: Separately store the internal pixel format set by WGL_WINE_pixel_format_passthrough. winex11: Separately store the internal pixel format set by WGL_WINE_pixel_format_passthrough. win32u: Allow separately storing the internal pixel format set by WGL_WINE_pixel_format_passthrough. wined3d: Do not set the pixel format if wglGetPixelFormat() returns zero and we already set the internal pixel format. winemac: Retrieve the pixel format from win32u for normal windows in wglGetPixelFormat(). wineandroid: Retrieve the pixel format from win32u for normal windows in wglGetPixelFormat(). winex11: Retrieve the pixel format from win32u for normal windows in wglGetPixelFormat(). win32u: Introduce a win32u_get_window_pixel_format() helper. win32u: Make NtUserSetWindowPixelFormat() into a proper export. https://gitlab.winehq.org/wine/wine/-/merge_requests/2217

4 13

[PATCH 0/3] MR2251: printing regression fixes
by Piotr Caban (＠piotr) 21 Feb '23

21 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2251

3 4

[PATCH v2 0/3] MR2249: winscard: Add implementation of basic functionality.
by Konstantin Romanov (＠IncubusRK) 21 Feb '23

21 Feb '23

based on libpcsclite1 \ rework of [original code by Mounir IDRASSI](https://sourceforge.net/projects/scard4wine/) to use unixlib interface First step to resolve \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39113 \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=37495 \ It will probably also require the implementation of scarddlg. In order for the tests to work fully in a virtual environment without the appropriate hardware, I suggest using the project https://github.com/Jakuje/virt_cacard Example for setting up a build server (It is supposed to be Debian): ``` apt-get install -y pcscd vsmartcard-vpcd libpcsclite1 libpcsclite-dev libcacard-dev libsofthsm2 libnss3-tools gnutls-bin opensc service pcscd restart git clone https://github.com/Jakuje/virt_cacard cd virt_cacard ./autogen.sh && ./configure && make ./setup-softhsm2.sh ``` "Insert" smartcard before runing tests: \ `cd /path/to/virt_cacard && SOFTHSM2_CONF=softhsm2.conf ./virt_cacard &` Partial test can be done if installed vsmartcard-vpcd (only test create/release context and list aviable card readers): \ ``` apt-get install -y pcscd vsmartcard-vpcd service pcscd restart ``` -- v2: winscard/test: skip when libpcsclite1 is not installed https://gitlab.winehq.org/wine/wine/-/merge_requests/2249

4 7

[PATCH 0/2] MR2249: winscard: Add implementation of basic functionality.
by Konstantin Romanov (＠IncubusRK) 21 Feb '23

21 Feb '23

based on libpcsclite1 \ rework of [original code by Mounir IDRASSI](https://sourceforge.net/projects/scard4wine/) to use unixlib interface First step to resolve \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39113 \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=37495 \ It will probably also require the implementation of scarddlg. In order for the tests to work fully in a virtual environment without the appropriate hardware, I suggest using the project https://github.com/Jakuje/virt_cacard Example for setting up a build server (It is supposed to be Debian): ``` apt-get install -y pcscd vsmartcard-vpcd libpcsclite1 libpcsclite-dev libcacard-dev libsofthsm2 libnss3-tools gnutls-bin opensc service pcscd restart git clone https://github.com/Jakuje/virt_cacard cd virt_cacard ./autogen.sh && ./configure && make ./setup-softhsm2.sh ``` "Insert" smartcard before runing tests: \ `cd /path/to/virt_cacard && SOFTHSM2_CONF=softhsm2.conf ./virt_cacard &` Partial test can be done if installed vsmartcard-vpcd (only test create/release context and list aviable card readers): \ ``` apt-get install -y pcscd vsmartcard-vpcd service pcscd restart ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2249

4 7