February 2023 - Wine-gitlab

Re: [PATCH v7 0/1] MR2229: winex11: Fix X11 WM behavior for Delphi based apps.
by Bernhard Kölbl 22 Feb '23

22 Feb '23

On Wed Feb 22 11:39:08 2023 +0000, Roberto Fernandez wrote: > Is there something I can do to get this patch in ? IDK if this is the problem, but when you submit [someone else's patch](https://www.winehq.org/pipermail/wine-devel/2021-December/203906.htm…, then [this](https://wiki.winehq.org/Submitting_Patches#Submitting_patches_written… rule applies . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2229#note_25134

1 0

Re: [PATCH v7 0/1] MR2229: winex11: Fix X11 WM behavior for Delphi based apps.
by Roberto Fernandez (＠rfz) 22 Feb '23

22 Feb '23

Is there something I can do to get this patch in ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2229#note_25131

1 0

[PATCH 0/1] MR2200: mshtml: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 22 Feb '23

22 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2200

4 4

[PATCH 0/1] MR2254: vscript/tests: Fix the testChrError() tests.
by Francois Gouget (＠fgouget) 22 Feb '23

22 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2254

3 2

[PATCH v3 0/1] MR2242: win32u: Do not set last error in wait_message() for zero count.
by Paul Gofman (＠gofman) 22 Feb '23

22 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54405 Also fixes Assassin Creed hanging on start (for a similar reason: it doesn't expect a spurious -1 last error). There is already a fix attempt sent by Ivan Chikish in !2067 (https://gitlab.winehq.org/wine/wine/-/merge_requests/2067) But I suppose it may be fixed simpler like in this patch. wait_message() with zero count is only called from NtUserPeekMessage(). I think even if for some reason driver's MsgWaitForMultipleObjectsEx returns a real error code we still don't want to set last error here when called from PeekMessage(). -- v3: win32u: Expose and use ProcessEvents from drivers instead of MsgWaitForMultipleObjectsEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/2242

4 9

[PATCH v8 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 22 Feb '23

22 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v8: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync. cryptowinrt: Import IAsyncOperation from windows.gaming.input. cryptowinrt: Stub IKeyCredentialManagerStatics interface. cryptowinrt: Add private.h file. cryptowinrt/tests: Add ICryptographicBufferStatics interface test. include: Add windows.security.credentials.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

4 13

[PATCH v2 0/4] MR2247: mf/tests: Test ProcessInput and ProcessOutput for WMV decoder DMO.
by Ziqing Hui (＠zhui) 22 Feb '23

22 Feb '23

SetInputType tests will randomly failed after PATCH 3 (It was OK in PATCH 2). I spend many time on figuring out why. And I found a weird thing: If I comment out the compare_nv12() in check_dmo_output_data_buffer_(), the test failures will be gone. I can't think out the reason. I don't understand why compare_nv12() in check_dmo_output_data_buffer_() affects SetInputType tests. And I don't want to waste too much time on the test stuff. Implementing the decoder is more important, so I marked the failed tests as flaky. -- v2: mf/tests: Test output data for WMV decoder DMO. mf/tests: Test ProcessInput and ProcessOutput for WMV decoder DMO. mf/tests: Correctly initialize DMO media type. https://gitlab.winehq.org/wine/wine/-/merge_requests/2247

4 8

[PATCH 0/2] MR2240: Winedbg to load 64bit modules for a wow64 debuggee in multi-arch config.
by eric pouech (＠epo) 22 Feb '23

22 Feb '23

This series intent is to let winedbg (and dbghelp) load the 64bit PE modules of a wow64 debuggee. At this stage, all debug info of all modules (PE and ELF) are properly loaded (and displayed with 'info wow share' command). Breakpoint and backtrace in 64bit code of a wow64 debuggee are not available. The serie contains: - extension of tests to show that 64bit load dll events are generated for a wow64 debuggee (for a 64bit debugger, not for a 32bit one) - change for adapting filtering of events I opted for doing it in ntdll and passing the machine of the mapping in request's reply. Please advisde if you'd prefer another approach. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2240

2 3

[PATCH 0/1] MR2259: include: Annotate CommandLineToArgvW with __WINE_DEALLOC.
by Alex Henrie (＠alexhenrie) 22 Feb '23

22 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2259

2 1

[PATCH 0/2] MR2245: dxgi: Implement IDXGIFactory2::CreateSwapChainForComposition().
by Zhiyi Zhang (＠zhiyi) 22 Feb '23

22 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2245

3 4