February 2023 - Wine-gitlab

[PATCH 0/4] MR2248: uiautomationcore: Implement some IUIAutomation property helper methods.
by Connor McAdams (＠cmcadams) 21 Feb '23

21 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2248

3 9

[PATCH v3 0/1] MR88: vkd3d-shader/hlsl: Support lit() intrinsic.
by Nikolay Sivov (＠nsivov) 21 Feb '23

21 Feb '23

-- v3: vkd3d-shader/hlsl: Support lit() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/88

3 2

[PATCH 0/1] MR2235: dlls/dxgi: Don't warn on DXGI_ALPHA_MODE_UNSPECIFIED with wined3d
by David Gow (＠sulix) 21 Feb '23

21 Feb '23

Wine's dxgi implementation doesn't handle the different DXGI_ALPHA_MODE values, save for DXGI_ALPHA_MODE_IGNORE on both vkd3d (d3d12) and wined3d (d3d11), but prints a fixme for DXGI_ALPHA_MODE_UNSPECIFIED for wined3d but not vkd3d. To match the behaviour between the two, and because the "Unspecified" mode seems like it should always be acceptable to ignore, don't print a fixme in the wined3d path either. This eliminates the following warning: 010c:fixme:dxgi:wined3d_swapchain_desc_from_dxgi Ignoring alpha mode 0. See the msdn docs for DXGI_ALPHA_MODE here: https://learn.microsoft.com/en-us/windows/win32/api/dxgi1_2/ne-dxgi1_2-dxgi… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2235

4 3

[PATCH v2 0/5] MR2192: Wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) 21 Feb '23

21 Feb '23

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- v2: wined3d: Move the WINED3D_RS_SUBPIXEL stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ZVISIBLE stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_LASTPIXEL stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_PLANEMASK stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ROP2 stub to wined3d_device_apply_stateblock. https://gitlab.winehq.org/wine/wine/-/merge_requests/2192

4 7

Re: [PATCH v2 0/1] MR2246: Draft: d3d11: wined3d: Implement texture reduction mode
by Henri Verbeet (＠hverbeet) 21 Feb '23

21 Feb '23

I suspect you're already aware of this, but wined3d_texture_reduction_mode_from_d3d11() should probably use D3D11_DECODE_FILTER_REDUCTION. Somewhat relatedly, the definition of D3D11_DECODE_IS_COMPARISON_FILTER will need to adjusted, or wined3d_texture_compare_from_d3d11() will return incorrect results. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2246#note_24991

1 0

[PATCH v9 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon 21 Feb '23

21 Feb '23

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. >From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v9: ntdll: Remove now unnecessary arch-specific exit frame. ntdll: Avoid calling pthread_exit on thread exit. ntdll: Return entry and suspend from server_init_process_done. ntdll: Create a pthread for the main thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

3 10

[PATCH 0/3] MR2247: mf/tests: Test ProcessInput and ProcessOutput for WMV decoder DMO.
by Ziqing Hui (＠zhui) 21 Feb '23

21 Feb '23

SetInputType tests will randomly failed after PATCH 3 (It was OK in PATCH 2). I spend many time on figuring out why. And I found a weird thing: If I comment out the compare_nv12() in check_dmo_output_data_buffer_(), the test failures will be gone. I can't think out the reason. I don't understand why compare_nv12() in check_dmo_output_data_buffer_() affects SetInputType tests. And I don't want to waste too much time on the test stuff. Implementing the decoder is more important, so I marked the failed tests as flaky. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2247

4 9

[PATCH v2 0/4] MR101: vkd3d-shader/hlsl: Improvements to builtin typenames handling.
by Nikolay Sivov (＠nsivov) 21 Feb '23

21 Feb '23

-- v2: vkd3d-shader/hlsl: Allow case-insenstive names for shader objects types. vkd3d-shader/hlsl: Initial support for string constants. vkd3d-shader/hlsl: Use unsigned type for "dword" alias. vkd3d-shader/hlsl: Support case-insensitive lookup for selected builtin types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/101

3 7

[PATCH v7 0/4] MR1889: bluetoothapis: Add BluetoothRegisterForAuthenticationEx stub.
by Mohamad Al-Jaf (＠maljaf) 21 Feb '23

21 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54112 -- v7: bluetoothapis: Add BluetoothUnregisterAuthentication stub. bluetoothapis: Add BluetoothRegisterForAuthenticationEx stub. include: Add BluetoothRegisterForAuthenticationEx prototype. bthprops.cpl: Move implementations to bluetoothapis and import them. https://gitlab.winehq.org/wine/wine/-/merge_requests/1889

4 8

[PATCH v3 0/2] MR2231: cfgmgr32: Implement CM_MapCrToWin32Err.
by Mohamad Al-Jaf (＠maljaf) 21 Feb '23

21 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53781 The Matrix Awakens MegaCity Unreal Engine 5.1 demo and Hogwarts Legacy call this. Duplicate Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54513 -- v3: cfgmgr32/tests: Add CM_MapCrToWin32Err tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2231

3 8