February 2023 - Wine-gitlab

Re: [PATCH 0/1] MR182: winex11: Use XKB key names to map key codes to scan codes.
by Timo Zuccarello (＠timozuccarello) 06 Feb '23

06 Feb '23

On Thu Oct 6 11:55:45 2022 +0000, Timo Zuccarello wrote: > I just went through the email thread (I'm still new to navigating > pipermail/mailing list archives) and I see the point, although I don't > think I can entirely grasp what VNC does. But the way I understand it is > that even if we used XKB names for the scan codes as in this MR, those > would be messed up just as well when using a VNC X server, as it maps > backwards from vkeys to scan codes? > In the XKB specification/documentation, "The key name links keys with > similar functions or in similar positions on keyboards that report > different scan codes", which gets me wondering how Windows actually > handles exotic keyboards or rather what is common practice in the > drivers for said exotic keyboards. > In any case, I agree, I suppose optional layout detection would be the > most compatible solution for now at least. @rbernon Prompted by someone who also had issues with exotic or non-qwerty keyboard layouts in #winehq, I've taken another look at this. Came across a StackOverflow post about detecting whether a display is VNC (https://stackoverflow.com/questions/29371717/linux-detecting-if-youre-runni…) Would that be an option? I.e. add an override winecfg option and by default try to detect a VNC session and if it's VNC, use previous mapping/code, otherwise use XKB? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/182#note_23078

1 0

[PATCH 0/1] MR82: vkd3d: Fix checking for failure from SleepConditionVariableCS().
by Zebediah Figura (＠zfigura) 06 Feb '23

06 Feb '23

Fixes: 552926cfca64db45e9731f675c65a7214bfa6441 -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/82

4 3

[PATCH 0/1] MR83: vkd3d-shader: Initialize the parameter allocator head.
by Zebediah Figura (＠zfigura) 06 Feb '23

06 Feb '23

This fixes a memory leak. Fixes: 007f894b9493eb80091899dab971e369f1673a4f -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/83

4 3

[PATCH v6 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon 06 Feb '23

06 Feb '23

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. >From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v6: ntdll: Remove now unnecessary arch-specific exit frame. ntdll: Avoid calling pthread_exit on thread exit. ntdll: Return entry and suspend from server_init_process_done. ntdll: Create a pthread for the main thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

1 5

[PATCH v2 0/6] MR77: hlsl: Fixes for function definition vs declaration.
by Zebediah Figura (＠zfigura) 06 Feb '23

06 Feb '23

-- v2: vkd3d-shader/hlsl: Add functions to the global list inside the func_prototype rule. vkd3d-shader/hlsl: Use the original hlsl_ir_function_decl struct rather than allocating a new one for each definition. vkd3d-shader/hlsl: Put synthetic variables into a dummy scope. vkd3d-shader/hlsl: Add a hlsl_cleanup_semantic() helper. vkd3d-shader/hlsl: Store function parameters in an array. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/77

4 12

Re: [PATCH v5 0/8] MR66: vkd3d-shader/hlsl: Broaden resources support v2 (PART 1).
by Francisco Casas (＠fcasas) 06 Feb '23

06 Feb '23

:arrow_up: Rebased on top of current master. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/66#note_23066

1 0

[PATCH 0/1] MR78: vkd3d: Initialize image aspect for NULL SRVs.
by Matteo Bruni (＠Mystral) 06 Feb '23

06 Feb '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/78

3 2

[PATCH 0/1] MR2115: programs/conhost: only update font when running with a window.
by eric pouech (＠epo) 06 Feb '23

06 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54449 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2115

3 2

[PATCH v3 0/3] MR1259: gitlab: Run some tests with nulldrv driver.
by Rémi Bernon 06 Feb '23

06 Feb '23

Allowing the job to fail to avoid failing the pipeline. Some new tests are failing with it, and some are succeeding todo_wine. -- v3: gitlab: Run user32 32-bit tests with nulldrv driver. https://gitlab.winehq.org/wine/wine/-/merge_requests/1259

1 4

[PATCH v2 0/5] MR1756: ntdll: Various performance improvements to hash_short_file_name.
by Rémi Bernon 06 Feb '23

06 Feb '23

The function is called a lot, I believe something like this would improve its performance in general. -- v2: ntdll: Lookup extension from the end in hash_short_file_name. ntdll: Use invalid char lookup table in lookup_unix_name. ntdll: Use invalid char lookup table in nt_to_unix_file_name_no_root. ntdll: Use invalid char lookup table in is_legal_8dot3_name. ntdll: Use invalid char lookup table in is_invalid_dos_char. https://gitlab.winehq.org/wine/wine/-/merge_requests/1756

1 7