April 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v5 0/2] MR2545: winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID
by Yeshun Ye (＠yeyeshun) 12 Apr '23

12 Apr '23

On Fri Apr 7 10:56:17 2023 +0000, Huw Davies wrote: > Did these failures get addressed? I don't see testbot runs for the > later versions of the commits in this MR. No, I think the function will never return 'MIXERR_INVALCONTROL', so I just run the test again without any change, and it passed. This failures maybe caused by a bug of testbot. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2545#note_29672

1 0

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Yeshun Ye (＠yeyeshun) 12 Apr '23

12 Apr '23

On Wed Apr 12 05:38:56 2023 +0000, Zhiyi Zhang wrote: > Hi Yeshun, you don't need to regularly rebase the MR on top of the > latest master. Because this area of code is largely undocumented, to > help this MR gets in, you need to add a test, even if it might not be > easy. I think you can use some of the example codes in NCALRPC_example. Thanks. I'm sorry I tried again, but still failed. I just know that the interface should not add 'implicit_handle(handle_t IXXX_HANDLE)' after 'uuid(IXXX_UUID)'. Can you help me add a simple interface in the testcases and tell me how to call the interface function? Otherwise, all I can do is give up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29671

1 0

[PATCH 0/5] MR2634: winintest:internet InternetGetConnectedStateEx*() fixes
by Francois Gouget (＠fgouget) 12 Apr '23

12 Apr '23

* Fix InternetGetConnectedStateEx() parameter checking. * InternetGetConnectedStateExA() must always null-terminate the state string. * Dump the state string if it is not as expected. * Remove a couple of redundant InternetGetConnectedStateEx*() tests. * Avoid an unnecessary lstrlenW() call in internet.c. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2634

2 5

[PATCH v3 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Mohamad Al-Jaf (＠maljaf) 11 Apr '23

11 Apr '23

Needed for mingw Firefox build. The WIDL error points to the wrong function, specifically the one after it. include/windows.ui.composition.interop.idl:35:63: error: parameter 'swapchain' of function 'CreateCompositionSurfaceForHandle' cannot derive from void * HRESULT CreateCompositionSurfaceForSwapChain([in] IUnknown *swapchain, [out, retval] ICompositionSurface **result); ^ make[1]: *** [Makefile:163749: include/windows.ui.composition.interop.h] Error 1 -- v3: include: Add windows.ui.composition.interop.idl file. widl: Add support for WinRT HANDLE parameter type. https://gitlab.winehq.org/wine/wine/-/merge_requests/2620

2 3

Re: [PATCH v5 0/2] MR2032: winex11: Allow replacing either context in wglShareLists.
by Alex Henrie (＠alexhenrie) 11 Apr '23

11 Apr '23

Thanks for the help Rémi! It looks like Alexandre was happy with the final product as well, or at least he trusts your judgment about it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2032#note_29663

1 0

Re: [PATCH v4 0/4] MR2626: wine{alsa,coreaudio,oss,pulse}: Move common mmdevdrv structs into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2626

1 0

Re: [PATCH v2 0/3] MR2632: gdi: Support stock brushes in EMR_FILLRGN and EMR_FRAMERGN. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2632

1 0

Re: [PATCH v2 0/5] MR2631: wineps: Handle more spool file records. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2631

1 0

Re: [PATCH v7 0/3] MR2496: Fix hang when a program calls IMFMediaSession_Start with an invalid source. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2496

1 0

Re: [PATCH v3 0/9] MR2627: imm32: Implement input context cache and use INPUTCONTEXT directly in some functions. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2627

1 0