April 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR2625: winex11.drv: Fix bit shifts in pixel format description for RGBA formats. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2625

1 0

Re: [PATCH v2 0/5] MR2629: msvcrt: Use remaining math functions from the bundled musl library. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2629

1 0

Re: [PATCH v3 0/1] MR2591: include: _InterlockedExchangePointer and _InterlockedCompareExchangePointer... - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2591

1 0

Re: [PATCH v5 0/2] MR2032: winex11: Allow replacing either context in wglShareLists. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2032

1 0

[PATCH v3 0/4] MR2626: wine{alsa,coreaudio,oss,pulse}: Move common mmdevdrv structs into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 11 Apr '23

11 Apr '23

-- v3: winepulse: Use mmdevdrv structs from mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2626

3 5

[PATCH v3 0/1] MR2471: winegstreamer: In video_processor, activate a videoflip converter.
by eric pouech (＠epo) 11 Apr '23

11 Apr '23

The app I'm considering opens a video_processor on its own, with a NV12 format on input and a ARGB32 format on output. Tested on Windows: the samples are flipped vertically. While Wine keeps them untouched. So added a videoflip in the video processor to be activated when needed. Current activation is based on RGB vs non RGB input/output formats. Set as draft as if somehow related to MR!2159. Comments welcomed. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v3: winegstreamer: In video_processor, activate a videoflip converter. https://gitlab.winehq.org/wine/wine/-/merge_requests/2471

3 10

Re: [PATCH v2 0/1] MR2439: ntoskrnl: Free memory before pointer gets set to NULL.
by Zebediah Figura (＠zfigura) 11 Apr '23

11 Apr '23

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/ntoskrnl.c: > irp->Tail.Overlay.Thread = (PETHREAD)KeGetCurrentThread(); > irp->Tail.Overlay.OriginalFileObject = file; > irp->RequestorMode = UserMode; > + HeapFree( GetProcessHeap(), 0, context->in_buff ); > context->in_buff = NULL; I don't think we need to be deallocating the input buffer; we're not using it. Rather we should just remove the assignment to NULL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2439#note_29633

1 0

Re: [PATCH v2 0/1] MR2439: ntoskrnl: Free memory before pointer gets set to NULL.
by Zebediah Figura (＠zfigura) 11 Apr '23

11 Apr '23

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/ntoskrnl.c: > if (ret == WAIT_OBJECT_0) > { > HeapFree( GetProcessHeap(), 0, context.in_buff ); > + context.in_buff = NULL; > status = STATUS_SUCCESS; > goto done; This seems unrelated and unnecessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2439#note_29634

1 0

[PATCH v2 0/4] MR2626: wine{alsa,coreaudio,oss,pulse}: Move common mmdevdrv structs into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 11 Apr '23

11 Apr '23

-- v2: winepulse: Use mmdevdrv structs from mmdevapi. wineoss: Use mmdevdrv structs from mmdevapi. winecoreaudio: Use mmdevdrv structs from mmdevapi. winealsa: Move common mmdevdrv structs into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2626

3 7

[PATCH 0/3] MR2632: gdi: Support stock brushes in EMR_FILLRGN and EMR_FRAMERGN.
by Piotr Caban (＠piotr) 11 Apr '23

11 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2632

3 4