September 2023 - Wine-gitlab

[PATCH v3 0/3] MR359: ci: Build crosstests in a dedicate CI job.
by Giovanni Mascellani (＠giomasce) 22 Sep '23

22 Sep '23

Mostly to avoid polluting other logs and artifacts, and also to avoid recompiling crosstests over and over. -- v3: ci: Wrap complex commands in CI scripts. ci: Build crosstests with -Wno-array-bounds. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/359

2 4

[PATCH v2 0/1] MR359: ci: Build crosstests in a dedicate CI job.
by Giovanni Mascellani (＠giomasce) 22 Sep '23

22 Sep '23

Mostly to avoid polluting other logs and artifacts, and also to avoid recompiling crosstests over and over. -- v2: ci: Build crosstests in a dedicate CI job. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/359

2 1

[PATCH 0/2] MR359: ci: Build crosstests in a dedicate CI job.
by Giovanni Mascellani (＠giomasce) 22 Sep '23

22 Sep '23

Mostly to avoid polluting other logs and artifacts, and also to avoid recompiling crosstests over and over. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/359

3 4

[PATCH v7 0/6] MR3548: windows.applicationmodel: Implement some functions.
by Mohamad Al-Jaf (＠maljaf) 22 Sep '23

22 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52665 I'm unsure how to add tests for this given it requires an app to be installed via MSIX to get a package ID in Windows otherwise `IPackageStatics::get_Current()` returns `0x80073d54`. -- v7: windows.applicationmodel: Implement IStorageItem::get_Path(). windows.applicationmodel/tests: Add IStorageItem::get_Path() tests. windows.applicationmodel: Add IStorageItem stub interface. windows.applicationmodel: Implement IPackage::get_InstalledLocation(). windows.applicationmodel: Implement IPackageStatics::get_Current(). windows.applicationmodel: Add IPackageStatics stub interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/3548

3 9

Re: [PATCH 0/6] MR3909: winewayland.drv: part 7: Basic window management - approved
by Rémi Bernon 22 Sep '23

22 Sep '23

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Fri Sep 22 06:50:36 2023 +0000, Aidan Khoury wrote: > `RtlImageNtHeader` lacks proper image boundary checks for e_lfanew, so > using it in this case is not safe. this raises the questions does native ntdll.RtlImageHeader check for e_lfanew being within image boundary? if so, it builtin implementation has to be fixed (with test case please) and if it doesn't you can still add the check on RtlImageHeader's returned value -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46285

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Thu Sep 21 20:03:38 2023 +0000, Aidan Khoury wrote: > No, but if you supply invalidly formed images to the mspatcha.dll APIs > it will raise an exception with code 0xE0000001. I made this a separate > function so I could mark it as `DECLSPEC_NORETURN`. (my question was unclear: I meant does native throw this exception?) what does native do if the exception is continued? (I doubt this helper can be DECLSPEC_NOTRETURN) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46284

1 0

Re: [PATCH v2 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Huw Davies (＠huw) 22 Sep '23

22 Sep '23

> What about If I changed the commit message to winmm: MCI_MapMsgAtoW return error code directly instead of a boolean. That's my point: it doesn't currently return a boolean, it returns a tri-state. One of those values tells the caller to skip calling `MCI_UnmapMsgAtoW()`. Your change gets rid of this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_46283

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Fri Sep 22 06:33:23 2023 +0000, Aidan Khoury wrote: > Updated in https://gitlab.winehq.org/wine/wine/-/merge_requests/3870/diffs?diff_id=709… > :thumbsup: actually, if there's a bug in imagehlp.CalcCheckSum, the general way of handling is to write a test case that demonstrate the bug, and implement the fix in the offending function -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46282

1 0

[PATCH 0/1] MR3920: winecoreaudio: Use os_unfair_lock when available instead of OSSpinLock.
by Brendan Shanks (＠bshanks) 22 Sep '23

22 Sep '23

OSSpinLock is deprecated, Apple recommends os_unfair_lock as the improved replacement. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3920

4 3