January 2024 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR4961: ncrypt/tests: Don't use uninitialized variable in test_get_property.
by Jacek Caban (＠jacek) 29 Jan '24

29 Jan '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4961

2 1

[PATCH v4 0/3] MR598: vkd3d-shader/ir: Lower monolithic switches to selection ladders.
by Giovanni Mascellani (＠giomasce) 29 Jan '24

29 Jan '24

This is a preliminary pass for the control flow graph structurizer. The plan, at least for the first version of the structurizer, is to have this pass, then another pass that converts all SSA registers to TEMPs (and correspondingly PHI nodes to MOVs/MOVCs), then a simple structurizer based on the so-called Böhm–Jacopini theorem. Some changes to the SPIR-V backend will also be needed, for supporting BOOL TEMP registers and fixing some details of 64 bit types. But this pass is already quite complicated, so large enough for its own MR. -- v4: vkd3d-shader/ir: Fixup PHI nodes when lowering switches to selection ladders. vkd3d-shader/ir: Lower monolithic switches to selection ladders. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/598

4 8

[PATCH v4 0/2] MR587: vkd3d-shader/dxil: Implement DX intrinsic Tertiary.
by Conor McCarthy (＠cmccarthy) 29 Jan '24

29 Jan '24

I'll revise the operand codes once !572 is upstream. -- v4: vkd3d-shader/spirv: Support 64-bit source value for bitfield instructions. vkd3d-shader/dxil: Implement DX intrinsic Tertiary. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/587

3 3

[PATCH v4 0/2] MR583: vkd3d-shader/dxil: SRV/UAV support part 2.
by Conor McCarthy (＠cmccarthy) 29 Jan '24

29 Jan '24

-- v4: vkd3d-shader/dxil: Implement DX intrinsic RawBufferLoad. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/583

4 6

[PATCH v9 0/4] MR458: vkd3d-shader/hlsl: Handle register(cX) reservations.
by Francisco Casas (＠fcasas) 29 Jan '24

29 Jan '24

Currently we are not properly handling register(cX) reservations for SM1, this is one of the things required for the SNK shaders (CW Bug Bug 18092). register(cX) reservations also change the offset in the $Globals buffer in SM4, so support for this is also included. --- Patch 1/4 is required to specify: ``` [require] shader model < 4.0 ``` so that the tests that follow do not get run with the vulkan backend on SM4. I think nobody disagreed with that patch. -- v9: vkd3d-shader/hlsl: Turn register(cX) reservations into buffer offset for SM4. vkd3d-shader/hlsl: Make register(cX) reservations work for SM1. tests: Test register(cX) reservations. tests: Rename register-reservations.shader_test to register-reservations-resources.shader_test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/458

3 5

[PATCH v4 0/9] MR4946: user32: Rewrite the rawinput buffer tests with keyboard input, and fix GetRawInputBuffer.
by Rémi Bernon 29 Jan '24

29 Jan '24

-- v4: server: Fix rawinput buffer sizes and alignment on WoW64. server: Move rawinput message conversion from win32u. server: Stop using hardware_msg_data in rawinput_message. server: Combine HID usage page and usage together. server: Stop using union rawinput in hw_input_t. dinput/tests: Add more tests for HID rawinput buffer. dinput/tests: Add a helper to wait on HID input reads. user32/tests: Rewrite the rawinput buffer test with keyboard input. user32/tests: Run rawinput device tests in the separate desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/4946

2 12

[PATCH 0/1] MR4960: explorer: Restore a per-desktop ShowSystray registry setting.
by Rémi Bernon 29 Jan '24

29 Jan '24

With a global fallback setting under HKCU\Software\Wine\Explorer. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56243 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4960

1 1

[PATCH v11 0/4] MR4551: Server-side thread priorities implementation (Part 1)
by Marc-Aurel Zent (＠mzent) 29 Jan '24

29 Jan '24

This is the current proton thread priority implementation by @rbernon rebased for upstream with a few `#ifdef`s added since AFAIK Linux is the only operating system where threads have a unique PID which can be used to set niceness on. ~~I also ran `./tools/make_requests` on https://gitlab.winehq.org/mzent/wine/-/commit/6705d3481be0409f7e971c1d2c7a3… as well and `autoconf` on https://gitlab.winehq.org/mzent/wine/-/commit/d7bafe40c411753662b2ad97148a6… (which does blow up the line count a bit).~~ A few tiny changes ~~(with the ready variable for example)~~ are in anticipation for Part 2, which also adds Mach thread priorities and recalculates thread priorities on process priority change. Since this is a rather large MR, I hope the split here is appropriate ~~(with the second part being slightly smaller)~~, but I think logically it makes the most sense here. -- v11: server: Check wineserver privileges on init with -20 niceness. server: Use setpriority to update thread niceness when safe. ntdll: Set RLIMIT_NICE to its hard limit. server: Introduce new set_thread_priority helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/4551

3 10

Re: [PATCH v15 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Alexandre Julliard (＠julliard) 29 Jan '24

29 Jan '24

Alexandre Julliard (@julliard) commented about dlls/kernelbase/tests/process.c: > HANDLE file, mapping; > void *ptr; > BOOL ret; > + SYSTEM_INFO si; > + DWORD dError; > + size_t szFile = 1024UL*1024; // 1M > + HANDLE hFileMapping; > + PVOID pAllocation; > + PVOID pMapStart; > + PVOID pMapStartOff; > + PVOID pMapEnd; > + BOOL bVirtualFree; > + PVOID pMappedFileView; Please no Hungarian notation, and no C++ comments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4822#note_59331

1 0

Re: [PATCH v15 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Alexandre Julliard (＠julliard) 29 Jan '24

29 Jan '24

Alexandre Julliard (@julliard) commented about dlls/kernelbase/tests/process.c: > static LPVOID (WINAPI *pVirtualAlloc2)(HANDLE, void *, SIZE_T, DWORD, DWORD, MEM_EXTENDED_PARAMETER *, ULONG); > static LPVOID (WINAPI *pVirtualAlloc2FromApp)(HANDLE, void *, SIZE_T, DWORD, DWORD, MEM_EXTENDED_PARAMETER *, ULONG); > static PVOID (WINAPI *pVirtualAllocFromApp)(PVOID, SIZE_T, DWORD, DWORD); > +static BOOL (WINAPI *pVirtualFree)(LPVOID,SIZE_T,DWORD); This is not necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4822#note_59330

1 0