January 2024 - Wine-gitlab - list.winehq.org

[PATCH 0/2] MR4836: ntdll: Implement SystemFirmwareTable_Enumerate in NtQuerySystemInformation
by Dāvis Mosāns 13 Jan '24

13 Jan '24

This MR implements `EnumSystemFirmwareTables()` and `NtQuerySystemInformation(SystemFirmwareTableInformation)` with `SystemFirmwareTable_Enumerate` which are currently not implemented. For more context/background info see !4832 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4836

2 3

Re: [PATCH v3 0/1] MR4830: dinput: implement DIPROP_AUTOCENTER
by Rémi Bernon 13 Jan '24

13 Jan '24

On Sat Jan 13 18:12:01 2024 +0000, Tyson Whitehead wrote: > Just a note that I have some more changes coming to this > * set `DIPROP_AUTOCENTER` on at start (currently defaults to off) > * update the tests Only had a quick look so far and it looks okay, so feel free to add these too. Fwiw in general we prefer to add tests first, with todo_wine as needed, and then remove the todo_wine as things are implemented. This better shows the desired behavior which is being implemented. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4830#note_57341

1 0

Re: [PATCH v3 0/1] MR4830: dinput: implement DIPROP_AUTOCENTER
by Tyson Whitehead (＠twhitehead) 13 Jan '24

13 Jan '24

Just a note that I have some more changes coming to this * set `DIPROP_AUTOCENTER` on at start (currently defaults to off) * update the tests -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4830#note_57338

1 0

[PATCH 0/1] MR4833: ntdll: Improve NtQuerySystemInformation(SystemCodeIntegrityInformation)
by Dāvis Mosāns 13 Jan '24

13 Jan '24

This makes it match more closely how it works on Windows but it's still not a proper implementation. For more context/background info see !4832 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4833

1 1

[PATCH 0/1] MR4831: wing32: Avoid crash in WinGGetDIBPointer when called with NULL bitmap info.
by Bernhard Übelacker 13 Jan '24

13 Jan '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56135 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4831

2 2

[PATCH v2 0/1] MR4830: dinput: implement DIPROP_AUTOCENTER
by Tyson Whitehead (＠twhitehead) 13 Jan '24

13 Jan '24

Autocenter is a default effect playing on the device following power up or reset. It is disabled by stopping all effects. On at least some devices (all?) it is a spring effect playing in slot 1. Capturing Windows USB packets reveals it dinput acquire does (1) a reset (this enabled autocenter) and, if autocenter is disabled, (2) a stop all effects (this disabled autocenter). This logic works regardless of whether autocenter is a spring effect playing in slot 1 or not. It does mean autocenter can only be set when the device is not acquired. Testing on Windows reveals setting autocenter properties while acquired returns DIERR_ACQUIRED even if the device is exclusively acquired, so this is consistent. -- v2: dinput: implement DIPROP_AUTOCENTER https://gitlab.winehq.org/wine/wine/-/merge_requests/4830

3 2

[PATCH 0/1] MR4830: dinput: implement DIPROP_AUTOCENTER
by Tyson Whitehead (＠twhitehead) 13 Jan '24

13 Jan '24

Autocenter is a default effect playing on the device following power up or reset. It is disabled by stopping all effects. On at least some devices (all?) it is a spring effect playing in slot 1. Capturing Windows USB packets reveals it dinput acquire does (1) a reset (this enabled autocenter) and, if autocenter is disabled, (2) a stop all effects (this disabled autocenter). This logic works regardless of whether autocenter is a spring effect playing in slot 1 or not. It does mean autocenter can only be set when the device is not acquired. Testing on Windows reveals setting autocenter properties while acquired returns DIERR_ACQUIRED even if the device is exclusively acquired, so this is consistent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4830

3 2

[PATCH v10 0/1] MR4809: Draft: wip! winewayland.drv: Try to support smooth scroll events
by Ray Strode (＠halfline) 13 Jan '24

13 Jan '24

Wayland has 3 types of scrolling events: - axis. Used for e.g., touchpad 2 finger smooth scrolling - axis_discrete. Used for mouse scroll wheels (i.e., notches) - axis_value120. Used for high resolution input devices Wine currently only supports axis_discrete, meaning that 2 finger scroll events get ignored. This commit tries to add basic support for axis scrolling events, by translating the smooth motion in scroll increments using some primitive assumptions about line height and number of lines to scroll. -- v10: wip! winewayland.drv: Try to support smooth scroll events https://gitlab.winehq.org/wine/wine/-/merge_requests/4809

3 3

[PATCH v4 0/30] MR559: Draft: vkd3d-shader/ir: Validate block-based control flow.
by Giovanni Mascellani (＠giomasce) 12 Jan '24

12 Jan '24

Other validation stuff I plan to send as soon as !450 and !550 are in. I guess the CI is going to timeout because of too many commits, so I'll preemptively stop it. -- v4: vkd3d-shader/ir: Validate modifiers and shift for SSA destinations. vkd3d-shader/ir: Do not allow IMMCONST and IMMCONST64 as destination registers. vkd3d-shader/ir: Check that all instructions appear in a block. vkd3d-shader/ir: Validate RET instructions. vkd3d-shader/ir: Validate SWITCH_MONOLITHIC instructions. tests: Add a couple of degenerate switch instances. vkd3d-shader/ir: Validate BRANCH instructions. vkd3d-shader/ir: Validate LABEL instructions. vkd3d-shader/ir: Validate LABEL registers. vkd3d-shader/ir: Validate that structured CF does not appear in block-based shaders. vkd3d-shader/ir: Check that SSA registers are used validly. vkd3d-shader/ir: Check that SSA registers have consistent dimensions. vkd3d-shader/ir: Check that TEMP registers have consistent dimensions. vkd3d-shader/ir: Use vkd3d_free() instead of free(). vkd3d-shader/ir: Simplify control flow in vsir_validate_register(). vkd3d-shader/dxil: Handle the DXIL SWITCH instruction. vkd3d-shader/dxil: Handle the DXIL PHI instruction. vkd3d-shader/dxil: Handle the DXIL BR instruction conditional variant. vkd3d-shader/dxil: Handle the DXIL BR instruction unconditional variant. vkd3d-shader/dxil: Introduce a code block terminator struct. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/559

1 0

[PATCH v2 0/1] MR4654: Draft: msvcrt: Protect setlocale against concurrent accesses.
by Bernhard Übelacker 12 Jan '24

12 Jan '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55467 -- v2: msvcrt: Protect setlocale against concurrent accesses. https://gitlab.winehq.org/wine/wine/-/merge_requests/4654

4 13