January 2026 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR9841: winex11.drv: Don't send -1 fullscreen monitor indices to window managers. - approved
by Alexandre Julliard (＠julliard) 05 Jan '26

05 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9841

1 0

Re: [PATCH v2 0/1] MR9838: opengl32: Avoid leaking memory on error paths (Coverity). - approved
by Alexandre Julliard (＠julliard) 05 Jan '26

05 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9838

1 0

Re: [PATCH v3 0/1] MR9851: win32u: Return failure from ResizePalette called with a count of zero. - approved
by Alexandre Julliard (＠julliard) 05 Jan '26

05 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9851

1 0

Re: [PATCH v3 0/1] MR9847: winex11: Drop SCIM workaround. - approved
by Alexandre Julliard (＠julliard) 05 Jan '26

05 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9847

1 0

[PATCH v2 0/2] MR9710: winegstreamer: Read input in chunks of 256KiB instead of 512KiB.
by Charlotte Pabst (＠CharlottePabst) 05 Jan '26

05 Jan '26

Supersedes !8183. JR East Train Simulator's IMFByteStream implementation relies on the following two properties: - Reads are always aligned on a 256KiB boundary. - Reads are never larger than 256KiB. When chunking was initially benchmarked[1], a chunk size of 512KiB only performed marginally better than 256KiB, so this change has a negligible performance impact while being more correct. I'm testing using a WAV handler here because it's easy to create the data for it in memory (avoids including a large video file in git), but the same behavior can be observed with other handlers, such as MP4. [1] https://gitlab.winehq.org/wine/wine/-/merge_requests/2390#note_27314 -- v2: winegstreamer: Read input in chunks of 256KiB. mfsrcsnk/tests: Test that byte streams are read in chunks of 0x40000. https://gitlab.winehq.org/wine/wine/-/merge_requests/9710

2 3

[PATCH 0/1] MR9841: winex11.drv: Don't send -1 fullscreen monitor indices to window managers.
by Zhiyi Zhang (＠zhiyi) 05 Jan '26

05 Jan '26

Fix a regression from 3bea06b8. This partly reverts 6a2e414d, which introduced this bug initially. With 3bea06b8, it becomes much more likely that indices (-1, -1, -1, -1) got sent to window managers. This can happen, for example, a game with a 1920x1080 window changes the display resolution to 3840x2160, then changes the window size to 3840x2160. After the resolution change and before the window size change, xinerama_get_fullscreen_monitors() will return monitor indices (-1, -1, -1, -1) because 1920x1080 is not fullscreen. While sending a _NET_WM_FULLSCREEN_MONITORS client message with fullscreen monitor indices (-1, -1, -1, -1) clears the _NET_WM_FULLSCREEN_MONITORS property for a window on KWin, it can also make the window to disappear and lose focus. See KWin X11Window::fullscreenMonitorsArea()[1] and X11Window::updateFullscreenMonitors()[2]. Note that QRect is constructed with an empty rect at the beginning of X11Window::fullscreenMonitorsArea(). So fullscreen monitor indices (-1, -1, -1, -1) will produce an empty rect for moveResize() in X11Window::updateFullscreenMonitors() and cause the window to disappear. While indices (-1, 0, 0, 0) might work, I think it's better not to change _NET_WM_FULLSCREEN_MONITORS when the window is not fullscreen because removing the property is not part of any standard. [1]: https://invent.kde.org/plasma/kwin-x11/-/blob/v6.5.4/src/x11window.cpp?ref_… [2]: https://invent.kde.org/plasma/kwin-x11/-/blob/v6.5.4/src/x11window.cpp?ref_… Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59180 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9841

3 2

[PATCH 0/2] MR9710: winegstreamer: Read input in chunks of 256KiB instead of 512KiB.
by Charlotte Pabst (＠CharlottePabst) 05 Jan '26

05 Jan '26

Supersedes !8183. JR East Train Simulator's IMFByteStream implementation relies on the following two properties: - Reads are always aligned on a 256KiB boundary. - Reads are never larger than 256KiB. When chunking was initially benchmarked[1], a chunk size of 512KiB only performed marginally better than 256KiB, so this change has a negligible performance impact while being more correct. I'm testing using a WAV handler here because it's easy to create the data for it in memory (avoids including a large video file in git), but the same behavior can be observed with other handlers, such as MP4. [1] https://gitlab.winehq.org/wine/wine/-/merge_requests/2390#note_27314 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9710

4 4

[PATCH 0/1] MR9838: opengl32: Avoid leaking memory on error paths (Coverity).
by Sven Baars (＠sbaars) 05 Jan '26

05 Jan '26

Fixes 11728e0a9c58f1b7a8d320b05f1ce40e4fa3c790. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9838

3 2

[PATCH v7 0/5] MR9843: wtsapi32: Fix session id and desktop handling when using CreateProcessAsUserW with tokens from WTSQueryUserToken
by Katharina Bogad (＠hackathi) 04 Jan '26

04 Jan '26

This Merge request resolves [Wine-Bug #58588](https://bugs.winehq.org/show_bug.cgi?id=58588). The underlying problem was that services started on their own, non-interactive winstation, but within the current user's session. This is trivially not the case for system services on Windows: they run, by design, in other user contexts (e.g. NTAUTHORITY\SYSTEM). Whenever a service wants to start a process within another user's graphical session, it needs to set the session id to the correct value. This may be done using the WTS API. This MR implements this functionality in a (hopefully) wine-compatible way: 1. Patch wineserver so tokens can be transferred to other sessions 2. Implement NtSetInformationToken for TokenSessionId 3. Change the session of non-interactive services to session 0 (from the default session 1) in addition to setting their desktop to `__wineservice_winstation\Default` 4. Let CreateProcessAsUserW reset the desktop to the default value `__winsta0\Default` if the session of the to-be-created process is not a service session. This avoids implementing all user and session handling in-depth while still allowing the underlying functionality to work. A real-world user of this mechanism is the Dassault 3DEXPERIENCE launcher, which runs as a system service and wants to open interactive child processes within a user's scope. -- v7: kernelbase: Let CreateProcessInternalW overwrite the desktop if needed https://gitlab.winehq.org/wine/wine/-/merge_requests/9843

3 7

Re: [PATCH v29 0/1] MR9414: shlwapi: Handling of "C:\...xx" in PathCanonicalize[AW].
by Thomas Csovcsity (＠thc13) 04 Jan '26

04 Jan '26

On Sun Jan 4 22:52:45 2026 +0000, Alexandre Julliard wrote: > Please don't rebase your MR every day, it's a waste of CI resources, and > makes it look like it's not ready. We are currently in code freeze so it > will have to wait anyway. ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9414#note_126394

1 0