[Bug 59896] New: comctl32_v6 misses LVM_ENABLEGROUPVIEW
http://bugs.winehq.org/show_bug.cgi?id=59896 Bug ID: 59896 Summary: comctl32_v6 misses LVM_ENABLEGROUPVIEW Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: comctl32 Assignee: wine-bugs@list.winehq.org Reporter: t.kani@gmx.net Distribution: --- Created attachment 81223 --> http://bugs.winehq.org/attachment.cgi?id=81223 screenshot , testcase and a demo app While working on an app i recognized that comctl32_v6 does not suppport groupview. I attached a screenshot , testcase and a demo app using it. The Elements are visible in wine only the group Header is missing. Kind regards Thorka -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59896 Tho <t.kani@gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |testcase Version|unspecified |11.11 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59896 KRosUser <kyle.kcsoftwares@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.kcsoftwares@gmail.com --- Comment #1 from KRosUser <kyle.kcsoftwares@gmail.com> --- Known as unimplemented feature: https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/comctl32/listview.c#L... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59896 beebix@schmusemail.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |beebix@schmusemail.de --- Comment #2 from beebix@schmusemail.de --- Hello; I worked on this a while back and have a partial implementation. I'll try to free up some time and post the current status though it's unlikely I'll be able to get it to production-ready quality in the next few months. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59896 Oleg Nikulin <owl2@etersoft.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |owl2@etersoft.ru --- Comment #3 from Oleg Nikulin <owl2@etersoft.ru> --- (In reply to beebix from comment #2)
Hello; I worked on this a while back and have a partial implementation. I'll try to free up some time and post the current status though it's unlikely I'll be able to get it to production-ready quality in the next few months. Hello, Could you please share your current work, even if it's not production-ready yet? I've also stumbled upon an app in which listview groups aren't displayed in wine. It would be very helpful to have a work-in-progress patch as a starting point. Thanks in advance
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59896 --- Comment #4 from beebix@schmusemail.de --- Created attachment 81236 --> http://bugs.winehq.org/attachment.cgi?id=81236 LV groups be and fe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59896 --- Comment #5 from beebix@schmusemail.de --- Created attachment 81237 --> http://bugs.winehq.org/attachment.cgi?id=81237 LV groups be and fe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59896 --- Comment #6 from beebix@schmusemail.de --- Hi Oleg, heres the source for the group's back and frontend. The backend was almost finished, but of course it wouldn't have been of any use to you without the frontend implementation. I went ahead and generated that using Opus. Needless to say, it's not ready for production as is. Mainly its missing essential rendering optimizations, heavily relies on hard coded values, completely breaks the virtualization of the list control by invalidating the entire item range, and uses a highly inefficient $O(N \times G)$ loop for assigning items to groups. ... But as it passes the test at least here you might want it anyway. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59896 --- Comment #7 from Oleg Nikulin <owl2@etersoft.ru> --- (In reply to beebix from comment #5)
Created attachment 81237 [details] LV groups be and fe Thank you for the patches! Unfortunately the group_view_fe.diff seems to be broken. When I try to apply it to the latest Wine I get the following error: error: patch fragment without header at line 6: @@ -1403,10 +1427,14 @@ static BOOL iterator_frameditems_absolute(ITERATOR* i, const LISTVIEW_INFO* info?
Patch header is missing in the beginning of the file. I tried inspecting the patch manually. The FE patch seems to be incomplete as it references some fields, such as hdpaGroupItems, which are not added by the patches. Also the FE patch seems to partially overlap with the BE patch: some BE changes are duplicated there. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla