[Bug 55775] New: game made from unity is not ingame playing video.
https://bugs.winehq.org/show_bug.cgi?id=55775 Bug ID: 55775 Summary: game made from unity is not ingame playing video. Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: mfplat Assignee: wine-bugs(a)winehq.org Reporter: l12436(a)yahoo.com.tw Distribution: --- Created attachment 75260 --> https://bugs.winehq.org/attachment.cgi?id=75260 console output of game that use mf as video playback There are some various game that use mf in win10 as default. but there are no video when they are using mf as dll to play video, there are video when disable mfplat.dll in winecfg. forcing some of the game back using quartz.dll. Test on game "Night Security" in steam at 3F in game. There are TV on the room. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55775 TOM <l12436(a)yahoo.com.tw> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|game made from unity is not |game made from unity is not |ingame playing video. |play in-game video. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 Stian Low <wineryyyyy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wineryyyyy@gmail.com --- Comment #1 from Stian Low <wineryyyyy@gmail.com> --- Created attachment 81545 --> http://bugs.winehq.org/attachment.cgi?id=81545 Screenshots videos playing as of wine-11.13 and renderer=vulkan darker than gl fixed via `winetricks /v win8` and default win10 via MR-10567 TV screens on wall seem to appear as expected. Please let me know if there is a specific scene to better test that videos are working because its less clear than others for this type of game. Game uses UnityPlayer.dll 2021.3.24 which seems to support falling back to software video decoding vs version 2019 which so far requires MR-11398 to force it until MR-11404 is ready which should change the way both versions handle video playback: https://bugs.winehq.org/show_bug.cgi?id=50277#c58 MR-10567 addresses renderer=vulkan darker than gl: https://gitlab.winehq.org/wine/wine/-/merge_requests/10567 Main menu is missing text for Steam version I'm using which may be a regression if not particular to the Thai version I'm using which may otherwise be handled by: https://bugs.winehq.org/show_bug.cgi?id=59680 I'll test English version to confirm. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #2 from TOM <l12436.tw@gmail.com> --- If said NightSecurity, there are a 3F, enter it, and go to the left door, there are a TV there, that is a video. before you click it, it should has some snow effect. after you click it, It should has video. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #3 from TOM <l12436.tw@gmail.com> --- For Rune factory 5, this game has intro video. as well as when you are a game, there are also lots of video. that is still black for me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #4 from Stian Low <wineryyyyy@gmail.com> --- (In reply to TOM from comment #2)
If said NightSecurity, there are a 3F, enter it, and go to the left door, there are a TV there, that is a video. before you click it, it should has some snow effect. after you click it, It should has video.
Thanks for clarifying. Retesting. (In reply to Stian Low from comment #1)
Main menu is missing text for Steam version I'm using which may be a regression if not particular to the Thai version I'm using which may
Or Vietnamese. Please excuse my lack of fluency. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #5 from Stian Low <wineryyyyy@gmail.com> --- (In reply to TOM from comment #3)
For Rune factory 5, this game has intro video. as well as when you are a game, there are also lots of video. that is still black for me.
Thanks for confirming Rune Factory 5 is still bugged. If UnityPlayer.dll contains text 2019 for version then its typically the indicator MR-11398 applies for forcing software video decoding. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #6 from TOM <l12436.tw@gmail.com> --- Yes, some language is lack of font text, I did not know If that is game issue, or system did not has that font or wine issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #7 from TOM <l12436.tw@gmail.com> --- After disable dxvk and test on d3dconfig vk_swap_srgb=1,renderer=vulkan without apply MR-11398, video in NightSecurity is still black, and game will also not render correctly after video is leave. after apply MR-11398 still black, but this time, even audio is not played. it working on the dxvk 3.0.2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #8 from TOM <l12436.tw@gmail.com> --- If you want to save more time, there are also another game, the bathhouse restored edition has the video directly on its title. so you can just open it to see if it actually shown. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #9 from Stian Low <wineryyyyy@gmail.com> --- (In reply to TOM from comment #7)
after apply MR-11398 still black, but this time, even audio is not played.
Apologies. I should have clarified that MR-11398 requires to be run such as special D3D flag because it does not run by default: WINE_D3D_CONFIG=no_create_flags=0x800 wine "Night Security.exe" Please retest if that part was missing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #10 from TOM <l12436.tw@gmail.com> --- Created attachment 81546 --> http://bugs.winehq.org/attachment.cgi?id=81546 This it should look like. use dxvk 3.0.2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #11 from Stian Low <wineryyyyy@gmail.com> --- (In reply to TOM from comment #7)
After disable dxvk and test on d3dconfig vk_swap_srgb=1,renderer=vulkan
vk_swap_srgb=1 or from an old patch that no longer applies for MR-10567. MR-10567 may be ignored completely for video tests because it only addresses fixing renderer=vulkan for win10. MR-11398 contains the patch for WINE_D3D_CONFIG=no_create_flags=0x800: https://gitlab.winehq.org/wine/wine/-/merge_requests/11398 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #12 from Stian Low <wineryyyyy@gmail.com> --- (In reply to TOM from comment #10)
Created attachment 81546 [details] This it should look like. use dxvk 3.0.2
Thanks for the reference. I'm still trying to make it to 3F via a guide. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #13 from TOM <l12436.tw@gmail.com> --- No, after test several times even with remove vk_swap_srgb still black screen. no snow effect or video played. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #14 from Stian Low <wineryyyyy@gmail.com> --- (In reply to TOM from comment #13)
No, after test several times even with remove vk_swap_srgb still black screen. no snow effect or video played.
I will confirm soon. (In reply to Stian Low from comment #12)
I'm still trying to make it to 3F via a guide.
For anyone trying to reproduce: https://www.gamenguides.com/night-security-%E5%A4%9C%E9%96%93%E8%AD%A6%E5%82... Intro videos for bootstrap testing would have been a very brilliant and convenient feature for this game :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #15 from TOM <l12436.tw@gmail.com> --- yes, the bathhouse restored version would be very convenient. the video just directly on title, though it need 25G. I still keep Night security as test because it is relative small. you once you got the 3F, it will saved. so you can back to test again. Only first time need to get to the 3F -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #16 from Stian Low <wineryyyyy@gmail.com> --- Created attachment 81549 --> http://bugs.winehq.org/attachment.cgi?id=81549 Screenshot 2F tv with static with MR-10567 disabled 2F has a TV that seems to play a video with static. Does this count? If not then almost to 3F to test that TV. If 2F TV is a valid test then videos work without even enabling MR-10567 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #17 from Stian Low <wineryyyyy@gmail.com> --- Created attachment 81550 --> http://bugs.winehq.org/attachment.cgi?id=81550 Screenshot 3F TV with static with MR-10567 disabled 3F TV has similar result as 2F TV -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #18 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #17)
Created attachment 81550 [details] Screenshot 3F TV with static with MR-10567 disabled
3F TV has similar result as 2F TV
Sorry I meant MR-11398 is disabled. But to clarify videos seem to be working for wine-11.13-d30dcd75bc9 without any MR/patches applied. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #19 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #18)
to clarify videos seem to be working for wine-11.13-d30dcd75bc9 without any MR/patches applied.
I'll test the other games you reported. My goal is to collect all bugs fixed by MR-11398. Night Security videos seem to be fixed by earlier commits. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #20 from TOM <l12436.tw@gmail.com> --- for some reason, I did not reproduce your result, It still black screen for me -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #21 from Stian Low <wineryyyyy@gmail.com> --- (In reply to TOM from comment #20)
for some reason, I did not reproduce your result, It still black screen for me
What is the latest commit you tested? Screenshots were for commit d30dcd75bc9 without any MR/patches or extras. If it still does not work for that commit then your system may be missing some multimedia dependencies. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #22 from TOM <l12436.tw@gmail.com> --- (In reply to Stian Low from comment #21)
(In reply to TOM from comment #20)
for some reason, I did not reproduce your result, It still black screen for me
What is the latest commit you tested?
Screenshots were for commit d30dcd75bc9 without any MR/patches or extras.
1012f3d99507b80d4869eabf0853567660a7ecbb with two fix due to If not fixed, steam wont start
If it still does not work for that commit then your system may be missing some multimedia dependencies.
That is what I though, but same env with dxvk will work. maybe your vulkan implement need newer OS ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #23 from Stian Low <wineryyyyy@gmail.com> --- Created attachment 81563 --> http://bugs.winehq.org/attachment.cgi?id=81563 Screnshot 2L video still playing for vanilla wine-11.14-1012f3d9950 without any extras (In reply to TOM from comment #22)
1012f3d99507b80d4869eabf0853567660a7ecbb with two fix due to If not fixed, steam wont start
Commit 1012f3d9950 also works for me without any extra patches, MRs, etc. mfplat logs are spammed as soon as elevator arrives at 2L: 0024:fixme:wincodecs:BitmapImpl_QueryInterface unknown interface {6f15aaf2-d208-4e89-9ab4-489535d34f9c} 0024:fixme:mfplat:media_engine_IsSeeking (00007FA327CF2D30): stub. uuid(6f15aaf2-d208-4e89-9ab4-489535d34f9c) interface ID3D11Texture2D : ID3D11Resource Despite these logs the videos still plays without any obvious bugs. BitmapImpl_QueryInterface log matches Stories Untold has bugged videos fixed by MR-11398: - https://bugs.winehq.org/show_bug.cgi?id=44675#c17 I'll retest other games you mentioned to try to produce some consistent results between us. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #24 from TOM <l12436.tw@gmail.com> --- Created attachment 81564 --> http://bugs.winehq.org/attachment.cgi?id=81564 my log for +mfplat during NightSecurity -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #25 from TOM <l12436.tw@gmail.com> --- (In reply to Stian Low from comment #23)
Created attachment 81563 [details] Screnshot 2L video still playing for vanilla wine-11.14-1012f3d9950 without any extras
(In reply to TOM from comment #22)
1012f3d99507b80d4869eabf0853567660a7ecbb with two fix due to If not fixed, steam wont start
Commit 1012f3d9950 also works for me without any extra patches, MRs, etc.
mfplat logs are spammed as soon as elevator arrives at 2L: 0024:fixme:wincodecs:BitmapImpl_QueryInterface unknown interface {6f15aaf2-d208-4e89-9ab4-489535d34f9c} 0024:fixme:mfplat:media_engine_IsSeeking (00007FA327CF2D30): stub.
uuid(6f15aaf2-d208-4e89-9ab4-489535d34f9c) interface ID3D11Texture2D : ID3D11Resource
Despite these logs the videos still plays without any obvious bugs.
BitmapImpl_QueryInterface log matches Stories Untold has bugged videos fixed by MR-11398: - https://bugs.winehq.org/show_bug.cgi?id=44675#c17
I'll retest other games you mentioned to try to produce some consistent results between us.
That weird. Did I missing something ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #26 from Stian Low <wineryyyyy@gmail.com> --- (In reply to TOM from comment #25)
That weird. Did I missing something ?
Rather I missed telling you that `winecfg /v win8` was enabled for my tests. Please retest for win8. Until now win8 has only been used as a workaround for default win10 renderer=vulkan too dark which is why it was enabled for my tests. Switching to win10 makes BitmapImpl_QueryInterface logs disappear and GetSharedHandle logs get spammed instead which indicates that MR-11398 probably fixes NightSecurity too but only for win10. I'll retest and confirm. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #27 from Stian Low <wineryyyyy@gmail.com> --- Created attachment 81569 --> http://bugs.winehq.org/attachment.cgi?id=81569 Video bug reproduced for `winecfg /v win10` (win8 works) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #28 from TOM <l12436.tw@gmail.com> --- Yes, I can confirm that win8 is working, but cause steam show win8 not supported. it actually a workaround for people who only want it working. I also test a funny thing, I alt+tab out while the video play. the audio did not stop. but video is stopped -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #29 from TOM <l12436.tw@gmail.com> --- I test on Rune factory 5, the intro video still not play, black screen with audio -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #30 from Stian Low <wineryyyyy@gmail.com> --- Created attachment 81570 --> http://bugs.winehq.org/attachment.cgi?id=81570 Screenshot MR-11398 not fixing videos for win10 for wine-11.14-1012f3d9950 (In reply to TOM from comment #28)
Yes, I can confirm that win8 is working, but cause steam show win8 not supported. it actually a workaround for people who only want it working.
Thanks for confirming. MR-11398 does not fix videos for win10 which is the first case so far of not fixing videos when GetSharedHandle logs are spammed. This log confirms MR-11398 skips d3d device creation for D3D11_CREATE_DEVICE_VIDEO_SUPPORT 0x800 which has fixed all Haven video bug duplicates so far but not Night Security: 0024:fixme:d3d11:d3d11_create_device Failing due to d3d device creation flags 0x800 forced unsupported. Therefore MR-11398 may need to be improved with a more robust solution to also fix Night Security for win10. MR-11404 is the primary solution I'm working for supporting GetSharedHandle method of playing videos: - https://gitlab.winehq.org/wine/wine/-/merge_requests/11404#note_145814 I think wine should be able to support both GetSharedHandle method (currently missing) and the current software video decoding fallback method but I will prioritize whichever one fixes the most games quickest. DXVK seems to use GetSharedHandle method based feedback for MR-11404 but does not apply to gl and damavand/vulkan which MR-11404 will support: - https://gitlab.winehq.org/wine/wine/-/merge_requests/11404#note_145808 For now I'm continuing to collect of all video bugs and notes to prepare testing those merge requests. Thanks again for all your help debugging these issues. It's been very enlightening. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #31 from TOM <l12436.tw@gmail.com> --- I still got some of other NSFW game with video like UMEMARO3D, some very old game only play video as story like ToLove, and some very old using wmv as video. also some of SFW like VL2000 which is avi and never working so far. tell me if you need some of the video I told to debug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #32 from Stian Low <wineryyyyy@gmail.com> --- (In reply to TOM from comment #31)
I still got some of other NSFW game with video like UMEMARO3D, some very old game only play video as story like ToLove, and some very old using wmv as video.
also some of SFW like VL2000 which is avi and never working so far. tell me if you need some of the video I told to debug.
Thanks. I will also include for tests. But, older and non-Unity games are unlikely to be duplicates of Haven video bug (~2016+) and may need separate bug reports and fixes if they aren't duplicates of existing bugs or one another. For now fixing Unity is priority because it will likely fix the highest number of games. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #33 from TOM <l12436.tw@gmail.com> --- OK, thanks for the information. I also thought those will be lower priority. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #34 from Stian Low <wineryyyyy@gmail.com> --- Created attachment 81678 --> http://bugs.winehq.org/attachment.cgi?id=81678 Screenshots Rune Factory 5 video fixed via wine-11.14-4dbf7bef7a0 via MR-11398 for renderer=gl and vulkan (damavand darker fixed via `winecfg /v win8` and MR-10567) (In reply to Chunhao Hung from comment #29)
I test on Rune factory 5, the intro video still not play, black screen with audio
Duplicates Haven video bug-50277: - https://bugs.winehq.org/show_bug.cgi?id=50277 MR-11398 fixes via skipping GetSharedHandle rendering like most of all the other Unity games: - https://gitlab.winehq.org/wine/wine/-/merge_requests/11398 `WINE_D3D_CONFIG=no_create_flags=0x800` wine "Rune Factory 5.exe" MR-11404 still in process to support GetSharedHandle which I'll focus this week: - https://gitlab.winehq.org/wine/wine/-/merge_requests/11404#note_147541 MR-10567 will fix renderer=vulkan dark rendering for win10 without requiring `winecfg /v win8` as workaround also a common bug for these Unity games: - https://gitlab.winehq.org/wine/wine/-/merge_requests/10567 Other bugs: - Launcher flickers when hovering over controls for renderer=gl - Launcher invisible (except floating game characters) for renderer=vulkan but still responds to keyboard so Shift+Tab then Enter will effectively click the Launch button -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #35 from Chunhao Hung <l12436.tw@gmail.com> --- Thanks for the test. I also found that dxvk has 0x800 skip, but it put too inside cause it is not working when running RuneFactory5. after move code outside. the video is actually working on dxvk as well. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #36 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Chunhao Hung from comment #35)
Thanks for the test. I also found that dxvk has 0x800 skip, but it put too inside cause it is not working when running RuneFactory5. after move code outside. the video is actually working on dxvk as well.
I have not checked how dxvk handles these videos recently but it supposedly supports GetSharedHandle also: - https://gitlab.winehq.org/wine/wine/-/merge_requests/11404#note_145808 Maybe dxvk figured out that UnityPlayer fallback was a workaround until it supported GetSharedHandle. Here's a list of mostly related bugs collected: https://bugs.winehq.org/buglist.cgi?quicksearch=%2F11398&list_id=866762 https://bugs.winehq.org/buglist.cgi?quicksearch=%2F11404&list_id=866763 Maybe I was mistaken thinking these long standing commonly reported bugs affecting so many games were considered high priority by winehq because they seem to have been gone under the radar. WineHQ constantly corrects reporters not to report DXVK tests/bugs but these types of video bugs are the very cause that drives users/reporters to use DXVK vs wine. If keeping wine behind DXVK is a business strategy then perhaps its considered a waste of time to try to fix these bugs. Regardless I will try to get d3d maintainers to merge fixes because I prefer plain vanilla wine vs steam/proton/dxvk. Perhaps dxvk exists because the dev also had difficulty getting these bugs fixed and decided splitting dxvk as separate effort was more worthwhile which steam also considered worth funding independently. Must be nice to be fed for such hard effort. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #37 from Chunhao Hung <l12436.tw@gmail.com> --- OK, my also report mainly for wine bug. dxvk part is just a test, This is the first time that I saw wine support bug dxvk does not. I also thought they support, but now it seems not ? regardless, I also want vanilla wine support video play as well. some game did not actually good for dxvk. for video play and d3d I always check If I using dxvk or vailla. I only report for wine that is actually wine bug. if not, I will also updated if I found out. thanks for the test and constantly implement for video player issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 Zeb Figura <z.figura12@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com --- Comment #38 from Zeb Figura <z.figura12@gmail.com> --- (In reply to Stian Low from comment #36)
WineHQ constantly corrects reporters not to report DXVK tests/bugs but these types of video bugs are the very cause that drives users/reporters to use DXVK vs wine.
If keeping wine behind DXVK is a business strategy then perhaps its considered a waste of time to try to fix these bugs.
As I've told you before, Wine lags behind DXVK because we have had at most one developer working on Direct3D, often less than full time, for the past several years. I'm fully aware that the situation is not ideal, but there's nothing I can do to fix it. Therefore I'd appreciate leaving off the passive-aggressive comments. We ask users to test with upstream Wine rather than DXVK because this is a Wine bug tracker. We have nothing to fix when DXVK bugs are reported. For what it's worth, I only bother asking things like that when it looks like a graphics bug. I'm not about to throw the book at someone who files a sound-related bug while using DXVK.
Perhaps dxvk exists because the dev also had difficulty getting these bugs fixed and decided splitting dxvk as separate effort was more worthwhile which steam also considered worth funding independently. Must be nice to be fed for such hard effort.
No, DXVK exists because Philip wanted to write his own Direct3D implementation. He never had intention of working with upstream. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #39 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Zeb Figura from comment #38)
Therefore I'd appreciate leaving off the passive-aggressive comments.
Which part is passive aggressive and should be left off?
As I've told you before, Wine lags behind DXVK because we have had at most one developer working on Direct3D, often less than full time, for the past several years.
Thanks for clarifying d3d lags due to limited resources. I'm trying to fix the lags. Forgive me if my guess that limited resource allocation may due to business strategy is considered offensive to you. It seems a legitimate decision to be made given potential steam partnerships and resource allocations there. Perhaps I misunderstood your reply that "priorities are difficult" as these d3d bugs are considered lower priority.
I'm fully aware that the situation is not ideal, but there's nothing I can do to fix it.
I'm doing what I'm able to fix/workaround bugs as a newcomer/outsider. Perhaps not auto rejecting other's fixes/workarounds may satisfy some level of what may be considered fixes especially when otherwise harmless and provide clarity. Haven video bugs are long standing with much confusion and speculation around the cause and I've spent considerable time testing, clarifying, relating duplicates, and submitting patches/merge requests to fix. That effort is not passive but very active. Forgive me if I consider my free time spent toward fixing these bugs important which may come off as a bit aggressive regarding achieving the goal of actually fixing them. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #40 from Austin English <austinenglish@gmail.com> ---
Which part is passive aggressive and should be left off?
If keeping wine behind DXVK is a business strategy then perhaps its considered a waste of time to try to fix these bugs.
Perhaps dxvk exists because the dev also had difficulty getting these bugs fixed and decided splitting dxvk as separate effort was more worthwhile which steam also considered worth funding independently. Must be nice to be fed for such hard effort.(In reply to Stian Low from comment #39)
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #41 from Zeb Figura <z.figura12@gmail.com> --- (In reply to Stian Low from comment #39)
(In reply to Zeb Figura from comment #38)
Therefore I'd appreciate leaving off the passive-aggressive comments.
Which part is passive aggressive and should be left off?
I apologize, I seem to have misread the intent behind your message. I should have been more gracious.
As I've told you before, Wine lags behind DXVK because we have had at most one developer working on Direct3D, often less than full time, for the past several years.
Thanks for clarifying d3d lags due to limited resources. I'm trying to fix the lags.
Forgive me if my guess that limited resource allocation may due to business strategy is considered offensive to you. It seems a legitimate decision to be made given potential steam partnerships and resource allocations there.
No, it's broadly true; the phrasing seemed more accusatory (i.e. that lagging behind is intentional, rather than a consequence of CW's choices to prioritize other work) but I gather this was unintentional.
Perhaps I misunderstood your reply that "priorities are difficult" as these d3d bugs are considered lower priority.
To be clear, when I say they are lower priority I don't mean that they are *low* priority. I would rate shared resources as the #2 priority, after "finish Damavand", and I'm not even sure that's right. Also to clarify, that's just priorities as in "what I personally work on". Review of someone else's patches is always the highest priority. I know it doesn't seem that way, and I apologize; I really don't want to be as slow with review as I am.
I'm doing what I'm able to fix/workaround bugs as a newcomer/outsider. Perhaps not auto rejecting other's fixes/workarounds may satisfy some level of what may be considered fixes especially when otherwise harmless and provide clarity.
I'm sorry you feel that your fixes are being automatically rejected; that's not at all my intent, and, to be overly honest, I'm specifically hesitant to reject anything from a new contributor for fear of driving them off. As you point out, we desperately need new contributors. The only patch I've considered rejecting is 11398, because (1) it doesn't actually encourage anyone to fix the bug properly; in fact it reduces the incentive; (2) it's rather indirect for a workaround, compared to other workarounds we have in d3d; (3) it's not clear to me it's going to be that hard. But I also see the point of fixing a larger class of applications now, and it's simple enough too, so it's hard to decide. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #42 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Austin English from comment #40)
Which part is passive aggressive and should be left off?
Thanks for clarifying. I was being blunt which may have come off as aggressive but not intended as in some passive way. I was explaining to reporter that I'll try to get these bugs fixed but I have spent considerable time tracking the history of this particular bug to better understand how best to fix it which includes: 1. Attempts by some codeweavers around the time Haven bug was originally reported back in 2020 to commit what was approved for proton but rejected for vanilla - https://list.winehq.org/hyperkitty/list/wine-devel@list.winehq.org/message/C... 2. MR-11398 which is a far more trivial fix/workaround but also at risk of being rejected - https://gitlab.winehq.org/wine/wine/-/merge_requests/11398#note_146433 So I may have over speculated about why dxvk exists. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #43 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Zeb Figura from comment #41)
I apologize, I seem to have misread the intent behind your message. I should have been more gracious.
No worries. I've seen how badly other reporters misbehave sometimes so I can see how my bluntness may have triggered association with them.
No, it's broadly true; the phrasing seemed more accusatory (i.e. that lagging behind is intentional, rather than a consequence of CW's choices to prioritize other work) but I gather this was unintentional.
Thanks again for clarifying. I was not implying it would necessarily be a bad thing if the lag was intentional to give Steam an edge during partnerships. If that's not the case then I'll consider my efforts more worthwhile and not in conflict with a strategy unknown to me.
To be clear, when I say they are lower priority I don't mean that they are *low* priority. I would rate shared resources as the #2 priority, after "finish Damavand", and I'm not even sure that's right. Also to clarify, that's just priorities as in "what I personally work on". Review of someone else's patches is always the highest priority. I know it doesn't seem that way, and I apologize; I really don't want to be as slow with review as I am.
I know folks are busy and not all reviews are the same. MR-11398 review is more trivial and comes down to a simple decision. MR-10567 is far less trivial (and vital to finish Damavand) and I've let reviewers know I understand that more thorough review may take more time: - https://gitlab.winehq.org/wine/wine/-/merge_requests/10567#note_146816
I'm sorry you feel that your fixes are being automatically rejected; that's
Only MR-11398 seemed like an automatic rejection.
The only patch I've considered rejecting is 11398, because (1) it doesn't actually encourage anyone to fix the bug properly; in fact it reduces the incentive; (2) it's rather indirect for a workaround, compared to other workarounds we have in d3d; (3) it's not clear to me it's going to be that hard. But I also see the point of fixing a larger class of applications now, and it's simple enough too, so it's hard to decide.
I agree it may reduce incentive to fix the bug but that would imply because its considered at least partially fixed. I intend to fix the other bug via MR-11404 regardless which has its own more edge use cases that MR-11398 does not fix but helps clarify. MR-11398 would enable replies to reporters to simply test if videos are fixed via `WINE_D3D_CONFIG=no_create_flags=0x800` and if so then it clarifies the problem. Otherwise bugs become clouded with the rest of the sea of related/duplicate bugs. MR-11398 may give some folks incentive to use wine video workarounds vs DXVK until D3D flag is no longer required to force it anymore via MR-11404. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #44 from Chunhao Hung <l12436.tw@gmail.com> --- I just want to share my opinion. I understand that the MR-11398 workaround might break some applications, so I think it makes sense to make it opt-in through a config option, either an environment variable or a registry setting. Personally, I would prefer an environment variable. This workaround seems to help video playback in a number of Unity games, so I think it is nice to have. But I also agree that it may reduce the incentive to fix the real underlying issue. Because of that, I think it should only be treated as a temporary workaround, and it should be removable at any time once the proper implementation is done. Maybe it could also be documented on the Wine wiki with a clear note that it is temporary. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #45 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Zeb Figura from comment #41)
point out, we desperately need new contributors.
For the record I've applied to join Codeweavers to help at a more full-time but was told I need more gitlab volume/activity to qualify. I'm still open to joining but I seem to be considered unworthy for one reason or another. Satisfying gitlab volume criteria is more difficult for me because I've chosen to focus on less trivial long-standing d3d bugs vs other much lower hanging fruit. (Although some of my trivial low hanging fruit seem not to be merged either: https://gitlab.winehq.org/wine/wine/-/merge_requests/11083#note_146454) I only have so much free time so I choose to focus on what aligns with my highest priorities/interests in d3d/graphics and what I calculated as having highest impact. Haven video bug seems to meet that criteria and MR-11398 as a trivial breakthrough. I understand d3d may take higher level of scrutiny/vetting compared to other modules and that newcomers/outsiders require a higher level of proof but it does seem to stall me a bit moving forward onto fixing other bugs and whatever gitlab volume may need to be satisfied to be considered a worthy candidate. Perhaps its unwise/stubborn of me to stay focused on fixing these bug since it impedes potentially increasing gitlab volume elsewhere and with other lower hanging fruit but I consider fixing these bugs to have higher weight regardless of it only counting as 1 commit toward whatever gitlab volume needs to be satisfied. A pound of feathers weighs the same as a pound of bricks but may not have the same impact. I choose brick. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #46 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #43)
MR-11398 may give some folks incentive to use wine video workarounds vs DXVK until D3D flag is no longer required to force it anymore via MR-11404.
MR-11398 is also a test case for me to better gauge the level of time/effort it may take to get MR-11404 and other d3d fixes merged. If MR-11398 is problematic and takes considerable time to merge (if at all) then other d3d fixes may take even more time which I must plan to balance with my own priorities to eat. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55775 --- Comment #47 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Chunhao Hung from comment #44)
I just want to share my opinion.
Thanks for feedback.
I understand that the MR-11398 workaround might break some applications, so I think it makes sense to make it opt-in through a config option, either an environment variable or a registry setting. Personally, I would prefer an environment variable.
`WINE_D3D_CONFIG=no_create_flags=0x800` is implemented like the others so environment variable overrides registry when defined: [Software\\Wine\\Direct3D] "csmt"=dword:00000001 "no_create_flags"=dword:00000800
This workaround seems to help video playback in a number of Unity games, so I think it is nice to have
Unity games seem far more common and impacted by `D3D11_CREATE_DEVICE_VIDEO_SUPPORT` not failing vs vice versa for apps which may require `D3D11_CREATE_DEVICE_VIDEO_SUPPORT` not failing. I'm still seeking any apps that require `D3D11_CREATE_DEVICE_VIDEO_SUPPORT` so please let me know of any so that MR-11398 may be more thoroughly tested.
Because of that, I think it should only be treated as a temporary workaround, and it should be removable at any time once the proper implementation is done. Maybe it could also be documented on the Wine wiki with a clear note that it is temporary.
I implemented in such a way to hopefully keep for long term debugging convenience purposes in case issues like Haven video bugs are ever encountered again which may allow users to find solutions without requiring dev efforts to discover cause of problems. Keeping long term potentially risks users reporting bugs due to misusing the feature but users savvy enough to use WINE_D3D_CONFIG seem to be aware of the impact such as changing `WINE_D3D_CONFIG=csmt=0x2` -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla